ICEmobile
  1. ICEmobile
  2. MOBI-640

rework tabset component to use core rendering strategy

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.2 Final
    • Fix Version/s: 1.3 Beta
    • Component/s: Faces, Spring
    • Labels:
      None
    • Environment:
      icemobile

      Description

      currently many open jira's for tabset. Will link to this one and deal with them for tablet.

      1) use common core rendering
      2) proper rendering of bottom orientation and get working for large view
      3) correct state regardless of whether contentPanes are client or not.
      4) common attributes between jsf and jsp
      5) disabled support

        Issue Links

          Activity

          Hide
          Judy Guglielmin added a comment -

          rev 33519 has initial checkin of tabSet where disabled is implemented in JSF, core rendering is used as much as is possible (not a lot) and common interface to ensure attributes are same.
          JSP has new tabSetController component which only takes child of tabPane
          <mobi:tabSetControl id="tabsetOne"
          orientation="$

          {tabInfo.orientation}

          "
          autoWidth="$

          {tabInfo.autoWidth}

          "
          disabled="$

          {tabInfo.disabled}

          "
          height="$

          {tabInfo.height}

          "
          autoHeight="$

          {tabInfo.autoHeight}

          "
          style="$

          {tabInfo.style}

          "
          styleClass="$

          {tabInfo.styleClass}

          "
          selectedId="$

          {tabInfo.selectedId}

          ">
          <mobi:tabPane id="pane1" title="Sailor">
          <%@ include file="../includes/pane1.jsp"%>
          </mobi:tabPane>
          <mobi:tabPane id="pane2" title="Breaker">
          <%@ include file="../includes/pane2.jsp"%>
          </mobi:tabPane>
          <mobi:tabPane id="pane3" title="Skate">
          <%@ include file="../includes/pane3.jsp"%>
          </mobi:tabPane>
          </mobi:tabSetControl>

          buffered approach taken with new tags. Still some work to do to enhance performance, but tests in new JSP test app show promise. (MOBI-659 test app not yet checked in).

          Show
          Judy Guglielmin added a comment - rev 33519 has initial checkin of tabSet where disabled is implemented in JSF, core rendering is used as much as is possible (not a lot) and common interface to ensure attributes are same. JSP has new tabSetController component which only takes child of tabPane <mobi:tabSetControl id="tabsetOne" orientation="$ {tabInfo.orientation} " autoWidth="$ {tabInfo.autoWidth} " disabled="$ {tabInfo.disabled} " height="$ {tabInfo.height} " autoHeight="$ {tabInfo.autoHeight} " style="$ {tabInfo.style} " styleClass="$ {tabInfo.styleClass} " selectedId="$ {tabInfo.selectedId} "> <mobi:tabPane id="pane1" title="Sailor"> <%@ include file="../includes/pane1.jsp"%> </mobi:tabPane> <mobi:tabPane id="pane2" title="Breaker"> <%@ include file="../includes/pane2.jsp"%> </mobi:tabPane> <mobi:tabPane id="pane3" title="Skate"> <%@ include file="../includes/pane3.jsp"%> </mobi:tabPane> </mobi:tabSetControl> buffered approach taken with new tags. Still some work to do to enhance performance, but tests in new JSP test app show promise. ( MOBI-659 test app not yet checked in).
          Hide
          Judy Guglielmin added a comment -

          old style tabSet still available so any other work on this could be done with new Jira.

          Show
          Judy Guglielmin added a comment - old style tabSet still available so any other work on this could be done with new Jira.

            People

            • Assignee:
              Judy Guglielmin
              Reporter:
              Judy Guglielmin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: