ICEmobile
  1. ICEmobile
  2. MOBI-545

panelPopup not rendering styleClass attribute

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 1.1 Final
          • Fix Version/s: 1.2 Final
          • Component/s: Faces
          • Labels:
            None
          • Environment:
            n/a

            Description


            The panelPopup jsf comp is not rendering the styleClass attribute

              Activity

              Ascending order - Click to sort in descending order
              Migration created issue -
              Migration made changes -
              Field Original Value New Value
              Reporter Migration [ remote ] User Philip.breau [ philip.breau ]
              Philip Breau made changes -
              Fix Version/s 1.2 Final [ 10371 ]
              Hide
              Permalink
              Philip Breau added a comment -

              retested, and still an issue

              Show
              Philip Breau added a comment - retested, and still an issue
              Philip Breau made changes -
              Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32650 Thu Dec 06 18:08:14 MST 2012 judy.guglielmin MOBI-545 for both JSP and JSF
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.panelpopup/panelpopup.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/PanelPopupCoreRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32651 Thu Dec 06 18:09:01 MST 2012 judy.guglielmin MOBI-545 test case for
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/latest/panelPopup.xhtml
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/PopupBean.java
              Hide
              Permalink
              Judy Guglielmin added a comment -

              for both jsp and jsf

              Show
              Judy Guglielmin added a comment - for both jsp and jsf
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32660 Fri Dec 07 12:56:01 MST 2012 judy.guglielmin MOBI-545 took off ability for user to style background and added ability for jsf style dyanmic update
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/jsp/src/main/javascript/icemobile.js
              Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.panelpopup/panelpopup.js
              Commit graph MODIFY /icemobile/trunk/icemobile/core/src/main/java/org/icemobile/renderkit/PanelPopupCoreRenderer.java
              Hide
              Permalink
              Philip Breau added a comment -

              it's being rendered now on both the background and the container div

              Show
              Philip Breau added a comment - it's being rendered now on both the background and the container div
              Philip Breau made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              so user defined styling can only be used for the container of the popup rather than background as well as container? Assumption was made that they would have ability to create own styling for all. if just for container, then need to know if that is same for all popups.

              Show
              Judy Guglielmin added a comment - so user defined styling can only be used for the container of the popup rather than background as well as container? Assumption was made that they would have ability to create own styling for all. if just for container, then need to know if that is same for all popups.
              Hide
              Permalink
              Philip Breau added a comment -

              Users wouldn't want to use styleClass to change to the style of the background. In general the styleClass should only be rendered on the root element of the main visual structure of a component. Are you rendering the 'style' attribute on both elements too? What do you think would happen if they used a styleClass and set the padding? The way it is now, that would affect the background overlay too, and be an unintended consequence. If the user ever wants to customize the background overlay they should override the built-in style class for that. And the class for the bg overlay should be the same CSS class for all of our components.

              Show
              Philip Breau added a comment - Users wouldn't want to use styleClass to change to the style of the background. In general the styleClass should only be rendered on the root element of the main visual structure of a component. Are you rendering the 'style' attribute on both elements too? What do you think would happen if they used a styleClass and set the padding? The way it is now, that would affect the background overlay too, and be an unintended consequence. If the user ever wants to customize the background overlay they should override the built-in style class for that. And the class for the bg overlay should be the same CSS class for all of our components.
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 32660

              Show
              Judy Guglielmin added a comment - rev 32660
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Assignee Judy Guglielmin [ judy.guglielmin ]
              Resolution Fixed [ 1 ]
              Philip Breau made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  Philip Breau
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: