ICEmobile
  1. ICEmobile
  2. MOBI-545

panelPopup not rendering styleClass attribute

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.2 Final
    • Component/s: Faces
    • Labels:
      None
    • Environment:
      n/a

      Description


      The panelPopup jsf comp is not rendering the styleClass attribute

        Activity

        Hide
        Judy Guglielmin added a comment -

        rev 32660

        Show
        Judy Guglielmin added a comment - rev 32660
        Hide
        Philip Breau added a comment -

        Users wouldn't want to use styleClass to change to the style of the background. In general the styleClass should only be rendered on the root element of the main visual structure of a component. Are you rendering the 'style' attribute on both elements too? What do you think would happen if they used a styleClass and set the padding? The way it is now, that would affect the background overlay too, and be an unintended consequence. If the user ever wants to customize the background overlay they should override the built-in style class for that. And the class for the bg overlay should be the same CSS class for all of our components.

        Show
        Philip Breau added a comment - Users wouldn't want to use styleClass to change to the style of the background. In general the styleClass should only be rendered on the root element of the main visual structure of a component. Are you rendering the 'style' attribute on both elements too? What do you think would happen if they used a styleClass and set the padding? The way it is now, that would affect the background overlay too, and be an unintended consequence. If the user ever wants to customize the background overlay they should override the built-in style class for that. And the class for the bg overlay should be the same CSS class for all of our components.
        Hide
        Judy Guglielmin added a comment -

        so user defined styling can only be used for the container of the popup rather than background as well as container? Assumption was made that they would have ability to create own styling for all. if just for container, then need to know if that is same for all popups.

        Show
        Judy Guglielmin added a comment - so user defined styling can only be used for the container of the popup rather than background as well as container? Assumption was made that they would have ability to create own styling for all. if just for container, then need to know if that is same for all popups.
        Hide
        Philip Breau added a comment -

        it's being rendered now on both the background and the container div

        Show
        Philip Breau added a comment - it's being rendered now on both the background and the container div
        Hide
        Judy Guglielmin added a comment -

        for both jsp and jsf

        Show
        Judy Guglielmin added a comment - for both jsp and jsf
        Hide
        Philip Breau added a comment -

        retested, and still an issue

        Show
        Philip Breau added a comment - retested, and still an issue

          People

          • Assignee:
            Unassigned
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: