ICEmobile
  1. ICEmobile
  2. MOBI-416

Components missing 'disabled' attributes

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Final
    • Fix Version/s: 1.3 Beta
    • Component/s: Faces, Spring
    • Labels:
      None
    • Environment:
      n/a

      Description


      The following JSF and JSP component are missing the disabled attribute:

      JSP
      ****************************
      accordion
      carousel
      fetchContact
      inputtext
      qrscan
      tabSet

      JSF
      ****************************
      contentNavBar
      tabSet

      We'll also need tests for all the components to see if the attribute is properly implemented.

        Activity

        Hide
        Judy Guglielmin added a comment - - edited

        the contentNavBar would not require a disabled -that would be in the contentMenuItem child of the component, which does have a disabled attribute.
        Not sure how a "disabled" attribute would pertain to carousel or qrscan??
        The carousel is typically a layout. If there is a link button within the carousel element/item, then the disabled should be on that element/component. Reviewing the carousel component, we should probably implement a carouselItem (an optional child component within the carousel that can have disabled attribute).

        Show
        Judy Guglielmin added a comment - - edited the contentNavBar would not require a disabled -that would be in the contentMenuItem child of the component, which does have a disabled attribute. Not sure how a "disabled" attribute would pertain to carousel or qrscan?? The carousel is typically a layout. If there is a link button within the carousel element/item, then the disabled should be on that element/component. Reviewing the carousel component, we should probably implement a carouselItem (an optional child component within the carousel that can have disabled attribute).
        Hide
        Steve Maryka added a comment - - edited

        svn rev 31805. Fixes for fetchContact, inputText, and qrscan have been checked in.

        Show
        Steve Maryka added a comment - - edited svn rev 31805. Fixes for fetchContact, inputText, and qrscan have been checked in.
        Hide
        Steve Maryka added a comment - - edited

        Accordion, carousel, and tabSet still need doing.

        Show
        Steve Maryka added a comment - - edited Accordion, carousel, and tabSet still need doing.
        Hide
        Judy Guglielmin added a comment -

        panelPopup testing completed in mobitest an dpassing panelPopup rev 32647

        Show
        Judy Guglielmin added a comment - panelPopup testing completed in mobitest an dpassing panelPopup rev 32647
        Hide
        Judy Guglielmin added a comment -

        many of these are done (accordion, carousel, tabSet)...but these will be completed when core rendering strategy is done for each component. Propose to close this one and have a jira for each component that is to use core rendering and then place the requirement for disabled with definition there.
        For example, just completed audioPlayer and videoPlayer and there is no html5 property of disabled on either of the html5 elements that these represent (possibly could use muted property??)..so doesn't always equate. Each component must be determined on it's own.

        Show
        Judy Guglielmin added a comment - many of these are done (accordion, carousel, tabSet)...but these will be completed when core rendering strategy is done for each component. Propose to close this one and have a jira for each component that is to use core rendering and then place the requirement for disabled with definition there. For example, just completed audioPlayer and videoPlayer and there is no html5 property of disabled on either of the html5 elements that these represent (possibly could use muted property??)..so doesn't always equate. Each component must be determined on it's own.
        Hide
        Judy Guglielmin added a comment -

        see last comment. As components are brought into core rendering strategy, this will be addressed.

        Show
        Judy Guglielmin added a comment - see last comment. As components are brought into core rendering strategy, this will be addressed.

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: