ICEmobile
  1. ICEmobile
  2. MOBI-233

Rationalize IDs and names for upload components

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE 1.0
          • Fix Version/s: 1.1 Final
          • Component/s: Containers, Faces, Spring
          • Labels:
            None
          • Environment:
            ICEmobile

            Description

            The names for a variety of upload components are appended with "-file". This introduces complexity for the JSP implementation since the developer is directly exposed to the parameter names.

            The strategy is to remove these extra suffixes and modify the serialization code in the browser to include type information in the name (which can then be stripped off prior to upload).

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29082 Wed May 16 17:38:42 MDT 2012 ted.goddard remove file suffix from upload names (MOBI-233)
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/ICEmobile-SX/ViewController.m
              Commit graph MODIFY /icemobile/trunk/icemobile/client/blackberry/container/src/org/icemobile/client/blackberry/blackberry-interface.js
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Shared/NativeInterface.m
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/video/VideoCaptureRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/microphone/MicrophoneRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/client/android/container/assets/icefaces/native-interface.js
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/ICEmobile-SX/ViewController.h
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Container/NativeInterface.m
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Container/MainViewController.mm
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/camera/CameraRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Container/native-interface.js
              Ted Goddard created issue -
              Ted Goddard made changes -
              Field Original Value New Value
              Assignee Steve Maryka [ steve.maryka ] Ted Goddard [ ted.goddard ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29102 Thu May 17 15:18:39 MDT 2012 ted.goddard remove _mic suffix case for ICEmobile-SX (MOBI-233)
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/microphone/MicrophoneRenderer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29109 Thu May 17 16:40:00 MDT 2012 ted.goddard prepend and unpack type information in parameter names on android (MOBI-233)
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/client/android/integration/util/src/org/icemobile/client/android/UtilInterface.java
              Commit graph MODIFY /icemobile/trunk/icemobile/client/android/container/assets/icefaces/native-interface.js
              Hide
              Permalink
              Ted Goddard added a comment -

              For android this required changes to native-interface.js addHidden calls and changes to UtilInterface to split the type-name packed name during before upload.

              Show
              Ted Goddard added a comment - For android this required changes to native-interface.js addHidden calls and changes to UtilInterface to split the type-name packed name during before upload.
              Ted Goddard made changes -
              Assignee Ted Goddard [ ted.goddard ] Greg Dick [ greg.dick ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29300 Tue Jun 05 11:29:37 MDT 2012 greg.dick mobi-233 made addHidden and addHiddenFormElement consistent with all platforms
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/client/blackberry/container/src/org/icemobile/client/blackberry/blackberry-interface.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29303 Tue Jun 05 11:38:46 MDT 2012 greg.dick MOBI-233, MOBI-219, MOBI-231 A number of changes for authorization, audio controller and using the new api in native-interface.js
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/client/blackberry/container/src/org/icemobile/client/blackberry/ICEmobileContainer.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29305 Tue Jun 05 11:41:38 MDT 2012 greg.dick MOBI-233 Changed to accommodate the new field names
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/client/blackberry/container/src/org/icemobile/client/blackberry/script/upload/AjaxUpload.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29344 Wed Jun 06 13:25:45 MDT 2012 ted.goddard send name without -text for barcode scan value (MOBI-233)
              Files Changed
              Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/scan/ScanRenderer.java
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Shared/NativeInterface.m
              Commit graph MODIFY /icemobile/trunk/icemobile/client/blackberry/container/src/org/icemobile/client/blackberry/ContainerController.java
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/ICEmobile.xcodeproj/project.pbxproj
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Container/OldNativeInterface.m
              Commit graph MODIFY /icemobile/trunk/icemobile/client/ios/icemobile/Container/OldNativeInterface.h
              Commit graph MODIFY /icemobile/trunk/icemobile/client/android/container/src/org/icemobile/client/android/ICEmobileContainer.java
              Hide
              Permalink
              Greg Dick added a comment -

              In Summary, the 'name' attribute has been added to the following tags:

              Geolocation,
              Input Text,
              QR Scan tag,
              Flipswitch,
              Command Button,
              Panel Popup

              The user supplied id can be replaced by an autogenerated one, or by an auyogenerated class if we want to avoid the use of ids altogether, since findElementByClass appears to have some traction. We could also adopt a strategy for not calling findElementBy* for a unique id or class, and adopt an algorithm that searches for parents or children with identifying marks and this would remove the need for unique identifiers entirely, performance pending of course.

              Show
              Greg Dick added a comment - In Summary, the 'name' attribute has been added to the following tags: Geolocation, Input Text, QR Scan tag, Flipswitch, Command Button, Panel Popup The user supplied id can be replaced by an autogenerated one, or by an auyogenerated class if we want to avoid the use of ids altogether, since findElementByClass appears to have some traction. We could also adopt a strategy for not calling findElementBy* for a unique id or class, and adopt an algorithm that searches for parents or children with identifying marks and this would remove the need for unique identifiers entirely, performance pending of course.
              Greg Dick made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Fix Version/s 1.1 Final [ 10343 ]
              Resolution Fixed [ 1 ]
              Migration made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Greg Dick
                  Reporter:
                  Ted Goddard
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: