ICEmobile
  1. ICEmobile
  2. MOBI-233

Rationalize IDs and names for upload components

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE 1.0
    • Fix Version/s: 1.1 Final
    • Component/s: Containers, Faces, Spring
    • Labels:
      None
    • Environment:
      ICEmobile

      Description

      The names for a variety of upload components are appended with "-file". This introduces complexity for the JSP implementation since the developer is directly exposed to the parameter names.

      The strategy is to remove these extra suffixes and modify the serialization code in the browser to include type information in the name (which can then be stripped off prior to upload).

        Activity

        Hide
        Ted Goddard added a comment -

        For android this required changes to native-interface.js addHidden calls and changes to UtilInterface to split the type-name packed name during before upload.

        Show
        Ted Goddard added a comment - For android this required changes to native-interface.js addHidden calls and changes to UtilInterface to split the type-name packed name during before upload.
        Hide
        Greg Dick added a comment -

        In Summary, the 'name' attribute has been added to the following tags:

        Geolocation,
        Input Text,
        QR Scan tag,
        Flipswitch,
        Command Button,
        Panel Popup

        The user supplied id can be replaced by an autogenerated one, or by an auyogenerated class if we want to avoid the use of ids altogether, since findElementByClass appears to have some traction. We could also adopt a strategy for not calling findElementBy* for a unique id or class, and adopt an algorithm that searches for parents or children with identifying marks and this would remove the need for unique identifiers entirely, performance pending of course.

        Show
        Greg Dick added a comment - In Summary, the 'name' attribute has been added to the following tags: Geolocation, Input Text, QR Scan tag, Flipswitch, Command Button, Panel Popup The user supplied id can be replaced by an autogenerated one, or by an auyogenerated class if we want to avoid the use of ids altogether, since findElementByClass appears to have some traction. We could also adopt a strategy for not calling findElementBy* for a unique id or class, and adopt an algorithm that searches for parents or children with identifying marks and this would remove the need for unique identifiers entirely, performance pending of course.

          People

          • Assignee:
            Greg Dick
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: