ICEmobile
  1. ICEmobile
  2. MOBI-224

create tabSet component to take advantage of contentPane features

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Beta
    • Fix Version/s: 1.1 Beta
    • Component/s: None
    • Labels:
      None
    • Environment:
      jsf 2 icefaces 3

      Description

      tabSet as per prototype. Initial transitions will be just based on opacity and visibility. Use of contentPane similar to contentStack.

        Activity

        Judy Guglielmin created issue -
        Judy Guglielmin made changes -
        Field Original Value New Value
        Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
        Judy Guglielmin made changes -
        Fix Version/s 1.1 Beta [ 10320 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28974 Tue May 08 18:03:28 MDT 2012 judy.guglielmin MOBI-224 initial checkin for tabSet. Still have to work on transitions and had to modify accordion as well as contentPane
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layoutComponents.html
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/accordion/AccordionRenderer.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/renderkit/BaseLayoutRenderer.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layout/accordion.xhtml
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/build.xml
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28987 Wed May 09 17:35:06 MDT 2012 judy.guglielmin MOBI-224 more work done on client side, but still not there with transitions for non-client side contentpane. Still need to do event fire on tab change and any clientBehavior support. did some height support (calc of max height) and ability for developer to specify fixed height. Most importantly have to get transitions working for non-client contentpane
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
        Commit graph ADD /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layout/tabSet.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28997 Thu May 10 15:19:14 MDT 2012 judy.guglielmin MOBI-224 having issues with transition firing when going back to server for content. When js debugger is used, everything works perfectly. The renderer just makes everything hidden and js will trigger the transition. When page it original from server, it's all good, but when updated on updateProperties, not sure what exactly is happening but no transition is fired. Current css for iPad contains all moz and ie definitions for transitions. Behavior is currently identical on FF, safari and Chrome desktop, but iphone the transition is sometimes fired when it isn't on dekstop browsers. Note that client version of contentPane, transition is always fired.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/iphone/default-tabset.css
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/iphone
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/build.xml
        Hide
        Judy Guglielmin added a comment -

        rev 28997 has most of features but still missing a few things
        Notably, am having some difficulty with the transitions firing consistently when contentPane is not cacheType = "client". Have tried this several ways. When js debugger is on in any desktop browser, the transition fires all the time. When not in use, the transitions don't always fire. Possibly a timing situation?
        Another notable thing we may have to deal with is disabling the tags until the transition is complete. If you click on a tab before the transition is complete, the content may not get rendered.
        Still to do.....add in listener on server side to fire when tabs are changed (would only work when going to server side though). Also no mobi:ajax support yet.

        Show
        Judy Guglielmin added a comment - rev 28997 has most of features but still missing a few things Notably, am having some difficulty with the transitions firing consistently when contentPane is not cacheType = "client". Have tried this several ways. When js debugger is on in any desktop browser, the transition fires all the time. When not in use, the transitions don't always fire. Possibly a timing situation? Another notable thing we may have to deal with is disabling the tags until the transition is complete. If you click on a tab before the transition is complete, the content may not get rendered. Still to do.....add in listener on server side to fire when tabs are changed (would only work when going to server side though). Also no mobi:ajax support yet.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29000 Thu May 10 16:49:59 MDT 2012 judy.guglielmin MOBI-224 a little more stable for transitions. Placed different rates and delays for fading in and out for better display of the different transitions. If transitioning from or to a client cached pane, transitions are good. When transitioning between 2 surver-side cache-types no transitions. Can't always count on updateProperties as dom diff sometimes wipes out the init script for this object. Have to consider
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29032 Mon May 14 14:17:27 MDT 2012 judy.guglielmin MOBI-224 replaced getElementByTag for the "div" as if you put divs into the panes, it gets confused (originally had "sections" but changed it out).
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29044 Tue May 15 11:53:07 MDT 2012 judy.guglielmin MOBI-224. tabChangeListener implemented and tested. modification of submit to allow for possibilities that last server-side notification of tab change was same as current when there could have been one or more done on client-side without server knowing. Ensure updateProperties script is rendered in this case as well
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/iphone/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29045 Tue May 15 11:54:06 MDT 2012 judy.guglielmin MOBI-224 need this version of ContentPaneRenderer for prev commit for tabset. Also test is updated.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/contentpane/ContentPaneRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layout/tabSet.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29073 Wed May 16 15:37:22 MDT 2012 judy.guglielmin MOBI-224 license headers and modify for mark's specs/comments on MOBI-218.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29195 Fri May 25 11:07:58 MDT 2012 patrick.corless MOBI-224 added simple tabset example as a placeholder for new component.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/resources/org/icemobile/samples/mobileshowcase/view/resources/messages.properties
        Commit graph ADD /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset-desc.xhtml
        Commit graph ADD /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/tabset/TabsetBean.java
        Commit graph ADD /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/tabset
        Commit graph ADD /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/content/content-stack.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/navigation/LayoutAndNavigationMenu.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/showcase.xhtml
        Commit graph ADD /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset-example.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/contentstack-example.xhtml
        Hide
        Patrick Corless added a comment -

        I've updated showcase with a simple example of the tabset. I know this component is still flex but only seemed to work correctly on the mobile devices and not in an native browser. When testing on chrome, firefox and safari once a tab is selected it is no longer possible to select another tab or show the content of the selected tab.

        On the mobile devices if a click though my three tabs in the demo, things seem to work. When do the tab click through test again, left to right, the component no longer responds.

        Show
        Patrick Corless added a comment - I've updated showcase with a simple example of the tabset. I know this component is still flex but only seemed to work correctly on the mobile devices and not in an native browser. When testing on chrome, firefox and safari once a tab is selected it is no longer possible to select another tab or show the content of the selected tab. On the mobile devices if a click though my three tabs in the demo, things seem to work. When do the tab click through test again, left to right, the component no longer responds.
        Hide
        Judy Guglielmin added a comment -

        Did you test it in mobitest first? It worked on all desktop browsers as well as iOS devices. If there is a scenario within mobile showcase, what is the component placed within? Were there any javascript console issues? Did you have it within a form? Not in a form? Please provide some markup. Would have to see how it is being used to be able to comment.

        Show
        Judy Guglielmin added a comment - Did you test it in mobitest first? It worked on all desktop browsers as well as iOS devices. If there is a scenario within mobile showcase, what is the component placed within? Were there any javascript console issues? Did you have it within a form? Not in a form? Please provide some markup. Would have to see how it is being used to be able to comment.
        Hide
        Patrick Corless added a comment -

        I've completed an iphone theme and in doing so would like to see an component enhancement that would allows a users to specify the orientation of the tabset's tab. From a mobile point of view I think top and bottom orientation is all that is needed.

        From a style point of view there is only a slight tweak for the root div element of the rendered output.

        <div class="mobi-tabset mobi-tabset-tabs-top">
        </div>

        If the users specified <mobi:tabset orientation="bottom" /> the renderd output would be:

        <div class="mobi-tabset mobi-tabset-tabs-bottom">
        </div>

        Show
        Patrick Corless added a comment - I've completed an iphone theme and in doing so would like to see an component enhancement that would allows a users to specify the orientation of the tabset's tab. From a mobile point of view I think top and bottom orientation is all that is needed. From a style point of view there is only a slight tweak for the root div element of the rendered output. <div class="mobi-tabset mobi-tabset-tabs-top"> </div> If the users specified <mobi:tabset orientation="bottom" /> the renderd output would be: <div class="mobi-tabset mobi-tabset-tabs-bottom"> </div>
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29262 Thu May 31 09:37:01 MDT 2012 judy.guglielmin MOBI-224 fix broadcast and queue event so that it's particular to this version of tabset (not just instance of any tabset).
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Hide
        Patrick Corless added a comment -

        The fixedHeight attribute appear to have no effect on the component. The div with mobi-tabset-content will always be assigned a zero height which would also indicated the calculation to find the child hight is now working correctly.

        Show
        Patrick Corless added a comment - The fixedHeight attribute appear to have no effect on the component. The div with mobi-tabset-content will always be assigned a zero height which would also indicated the calculation to find the child hight is now working correctly.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29318 Tue Jun 05 15:01:12 MDT 2012 patrick.corless MOBI-224 addition of tabset themes and component tweeks for new attributes, orientation, parentFooter, parentHeader and autoWidth.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/iphone/default-tabset.css
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/honeycomb
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/android/default-tabset.css
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/honeycomb/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetMeta.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/bberry/default-tabset.css
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/bberry
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/list/bberry/default-list.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/stylesheet/bberry/bberry_default.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/carousel/bberry/default-carousel.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Commit graph ADD /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/android
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/build.xml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29320 Tue Jun 05 15:06:25 MDT 2012 patrick.corless MOBI-224 addition of tabset to component showcase.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/resources/components/exampleTabset.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/view/small.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/input.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/menubutton.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/media/video.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/media/image.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/flip-switch.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/media/audio.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/qrcode.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion-example.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/accordion.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/notification.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/submitnotification.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/contentstack-example.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/showcase_small.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/content/content-stack.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/list.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelconfirmation.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/button.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/microphone.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/camcorder.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/device/camera.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/theme.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/tabset-example.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/carousel.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/accordion/AccordionBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/geolocation.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/contentstack.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/date.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/tabset/TabsetBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/fieldset.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelpopup.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/showcase.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29329 Wed Jun 06 09:31:39 MDT 2012 patrick.corless MOBI-224 removed fixed height from panel stack css.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/iphone/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/android/default-tabset.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/bberry/default-tabset.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29330 Wed Jun 06 09:32:28 MDT 2012 patrick.corless MOBI-224 addition of embedded tabset test.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layoutComponents.html
        Commit graph MODIFY /icemobile/trunk/icemobile/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/LayoutBean.java
        Commit graph ADD /icemobile/trunk/icemobile/components/tests/mobitest/src/main/webapp/layout/panelStack-tabSet.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29357 Wed Jun 06 17:28:11 MDT 2012 ted.goddard removed noisy info logging (MOBI-224)
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29360 Thu Jun 07 08:15:35 MDT 2012 patrick.corless MOBI-224 tweak to ipad tabset theme, removed fix height.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/tabset/ipad/default-tabset.css
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29390 Thu Jun 07 17:00:44 MDT 2012 patrick.corless MOBI-224 changed caching type to facelet="true" for composite tabset component.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/samples/mobileshowcase/src/main/webapp/resources/components/exampleTabset.xhtml
        Hide
        Judy Guglielmin added a comment -

        checked in with new jsf branch the fixes for all mobitest tests on tabSet. Still some problems with new styling when in dataTable.
        Problem in showcase is with new attribute for defaultId. It can't be relied upon since the tagHandler can't know what anything other than selectedId is. (tagHandler is executed first and order it is processed in for contentPanes is not consistent or known).
        When I used currentId in showcase with tabSet component (not composite component) it was fine. currentId needs to be assigned to a backing bean value.

        Show
        Judy Guglielmin added a comment - checked in with new jsf branch the fixes for all mobitest tests on tabSet. Still some problems with new styling when in dataTable. Problem in showcase is with new attribute for defaultId. It can't be relied upon since the tagHandler can't know what anything other than selectedId is. (tagHandler is executed first and order it is processed in for contentPanes is not consistent or known). When I used currentId in showcase with tabSet component (not composite component) it was fine. currentId needs to be assigned to a backing bean value.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29503 Thu Jun 14 09:18:13 MDT 2012 patrick.corless MOBI-224 added component tree count test to facelets for panelStack and tabset example.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/layout/ContentMenuSingleBean.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/includes/other.xhtml
        Commit graph ADD /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/java/org/icefaces/mobile/CompTreeMonitor.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29616 Thu Jun 21 10:37:43 MDT 2012 judy.guglielmin MOBI-224 fixed problem with tabSet in multi row data table with auto height returning 0 for height.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.tabset/tabset.js
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29656 Fri Jun 22 14:46:24 MDT 2012 judy.guglielmin MOBI-224 tabset examples updated
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/tabSetIncontentStack.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/includes/other.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/tabSetInMultiRowDataTable.xhtml
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #29674 Mon Jun 25 13:50:01 MDT 2012 judy.guglielmin MOBI-224 rework tabset component to minimize updates with DomDiff
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/resources/org.icefaces.component.tabset/tabset.js
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/includes/other.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/tests/mobitest/src/main/webapp/layout/tabSet.xhtml
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSetRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/jsf/components/component/src/org/icefaces/mobi/component/tabset/TabSet.java
        Hide
        Judy Guglielmin added a comment -

        component completed and released in 1.1 Beta. Any further improvements should be a new jira

        Show
        Judy Guglielmin added a comment - component completed and released in 1.1 Beta. Any further improvements should be a new jira
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Migration made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: