ICEmobile
  1. ICEmobile
  2. MOBI-224

create tabSet component to take advantage of contentPane features

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.1 Beta
    • Fix Version/s: 1.1 Beta
    • Component/s: None
    • Labels:
      None
    • Environment:
      jsf 2 icefaces 3

      Description

      tabSet as per prototype. Initial transitions will be just based on opacity and visibility. Use of contentPane similar to contentStack.

        Activity

        Hide
        Judy Guglielmin added a comment -

        rev 28997 has most of features but still missing a few things
        Notably, am having some difficulty with the transitions firing consistently when contentPane is not cacheType = "client". Have tried this several ways. When js debugger is on in any desktop browser, the transition fires all the time. When not in use, the transitions don't always fire. Possibly a timing situation?
        Another notable thing we may have to deal with is disabling the tags until the transition is complete. If you click on a tab before the transition is complete, the content may not get rendered.
        Still to do.....add in listener on server side to fire when tabs are changed (would only work when going to server side though). Also no mobi:ajax support yet.

        Show
        Judy Guglielmin added a comment - rev 28997 has most of features but still missing a few things Notably, am having some difficulty with the transitions firing consistently when contentPane is not cacheType = "client". Have tried this several ways. When js debugger is on in any desktop browser, the transition fires all the time. When not in use, the transitions don't always fire. Possibly a timing situation? Another notable thing we may have to deal with is disabling the tags until the transition is complete. If you click on a tab before the transition is complete, the content may not get rendered. Still to do.....add in listener on server side to fire when tabs are changed (would only work when going to server side though). Also no mobi:ajax support yet.
        Hide
        Patrick Corless added a comment -

        I've updated showcase with a simple example of the tabset. I know this component is still flex but only seemed to work correctly on the mobile devices and not in an native browser. When testing on chrome, firefox and safari once a tab is selected it is no longer possible to select another tab or show the content of the selected tab.

        On the mobile devices if a click though my three tabs in the demo, things seem to work. When do the tab click through test again, left to right, the component no longer responds.

        Show
        Patrick Corless added a comment - I've updated showcase with a simple example of the tabset. I know this component is still flex but only seemed to work correctly on the mobile devices and not in an native browser. When testing on chrome, firefox and safari once a tab is selected it is no longer possible to select another tab or show the content of the selected tab. On the mobile devices if a click though my three tabs in the demo, things seem to work. When do the tab click through test again, left to right, the component no longer responds.
        Hide
        Judy Guglielmin added a comment -

        Did you test it in mobitest first? It worked on all desktop browsers as well as iOS devices. If there is a scenario within mobile showcase, what is the component placed within? Were there any javascript console issues? Did you have it within a form? Not in a form? Please provide some markup. Would have to see how it is being used to be able to comment.

        Show
        Judy Guglielmin added a comment - Did you test it in mobitest first? It worked on all desktop browsers as well as iOS devices. If there is a scenario within mobile showcase, what is the component placed within? Were there any javascript console issues? Did you have it within a form? Not in a form? Please provide some markup. Would have to see how it is being used to be able to comment.
        Hide
        Patrick Corless added a comment -

        I've completed an iphone theme and in doing so would like to see an component enhancement that would allows a users to specify the orientation of the tabset's tab. From a mobile point of view I think top and bottom orientation is all that is needed.

        From a style point of view there is only a slight tweak for the root div element of the rendered output.

        <div class="mobi-tabset mobi-tabset-tabs-top">
        </div>

        If the users specified <mobi:tabset orientation="bottom" /> the renderd output would be:

        <div class="mobi-tabset mobi-tabset-tabs-bottom">
        </div>

        Show
        Patrick Corless added a comment - I've completed an iphone theme and in doing so would like to see an component enhancement that would allows a users to specify the orientation of the tabset's tab. From a mobile point of view I think top and bottom orientation is all that is needed. From a style point of view there is only a slight tweak for the root div element of the rendered output. <div class="mobi-tabset mobi-tabset-tabs-top"> </div> If the users specified <mobi:tabset orientation="bottom" /> the renderd output would be: <div class="mobi-tabset mobi-tabset-tabs-bottom"> </div>
        Hide
        Patrick Corless added a comment -

        The fixedHeight attribute appear to have no effect on the component. The div with mobi-tabset-content will always be assigned a zero height which would also indicated the calculation to find the child hight is now working correctly.

        Show
        Patrick Corless added a comment - The fixedHeight attribute appear to have no effect on the component. The div with mobi-tabset-content will always be assigned a zero height which would also indicated the calculation to find the child hight is now working correctly.
        Hide
        Judy Guglielmin added a comment -

        checked in with new jsf branch the fixes for all mobitest tests on tabSet. Still some problems with new styling when in dataTable.
        Problem in showcase is with new attribute for defaultId. It can't be relied upon since the tagHandler can't know what anything other than selectedId is. (tagHandler is executed first and order it is processed in for contentPanes is not consistent or known).
        When I used currentId in showcase with tabSet component (not composite component) it was fine. currentId needs to be assigned to a backing bean value.

        Show
        Judy Guglielmin added a comment - checked in with new jsf branch the fixes for all mobitest tests on tabSet. Still some problems with new styling when in dataTable. Problem in showcase is with new attribute for defaultId. It can't be relied upon since the tagHandler can't know what anything other than selectedId is. (tagHandler is executed first and order it is processed in for contentPanes is not consistent or known). When I used currentId in showcase with tabSet component (not composite component) it was fine. currentId needs to be assigned to a backing bean value.
        Hide
        Judy Guglielmin added a comment -

        component completed and released in 1.1 Beta. Any further improvements should be a new jira

        Show
        Judy Guglielmin added a comment - component completed and released in 1.1 Beta. Any further improvements should be a new jira

          People

          • Assignee:
            Judy Guglielmin
            Reporter:
            Judy Guglielmin
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: