ICEmobile
  1. ICEmobile
  2. MOBI-147

Mobie dateSpinner cancel button no longer hides the dialog

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0 Beta
    • Fix Version/s: 1.1 Beta
    • Component/s: None
    • Labels:
      None
    • Environment:
      any

      Description

      When using the mobi component showcase dateSpinner example the cancel button is no longer functional. The button should close and disregard any changes made by the user. The dateTimeSpinner seems to be unaffected and the cancel button works as expected.

        Activity

        Patrick Corless created issue -
        Patrick Corless made changes -
        Field Original Value New Value
        Assignee Steve Maryka [ steve.maryka ] Judy Guglielmin [ judy.guglielmin ]
        Hide
        Patrick Corless added a comment -

        Judy can you take a look at this, suspect it's pretty straight forward.

        Show
        Patrick Corless added a comment - Judy can you take a look at this, suspect it's pretty straight forward.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #27339 Tue Jan 24 12:10:18 MST 2012 judy.guglielmin MOBI-147
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/component/datespinner/DateSpinnerRenderer.java
        Hide
        Judy Guglielmin added a comment -

        rev 27339 resolved

        Show
        Judy Guglielmin added a comment - rev 27339 resolved
        Judy Guglielmin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        John Roll added a comment -

        does not work if mobile device is in "landscape" orientation, both on iPhone and Android.

        John Roll, Williams

        Show
        John Roll added a comment - does not work if mobile device is in "landscape" orientation, both on iPhone and Android. John Roll, Williams
        Hide
        Patrick Corless added a comment -

        Client is reporting problems with this issue, will investigate further.

        Show
        Patrick Corless added a comment - Client is reporting problems with this issue, will investigate further.
        Patrick Corless made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28048 Tue Feb 28 08:16:13 MST 2012 patrick.corless MOBI-147 updated touch event assignment for spinner component and moved the layout to an absolute position and added auto center/scroll code.
        Files Changed
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/ipad/default-time.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/bberry/default-time.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/bberry/default-date.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/honeycomb/default-date.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/ipad/default-date.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/android/default-date.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/iphone/default-time.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/honeycomb/default-time.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.datespinner/datespinner.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/iphone/default-date.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.util/component.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/android/default-time.css
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/resources/org.icefaces.component.timespinner/timespinner.js
        Commit graph MODIFY /icemobile/trunk/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28056 Tue Feb 28 08:54:09 MST 2012 patrick.corless MOBI-12 updated showcase for new components features, MOBI-152, MOBI-153, MOBI-147, MOBI-156.
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/layout/panelPopup/PanelPopupBean.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mediacast/src/main/java/org/icemobile/samples/mediacast/UploadServlet.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mediacast/src/main/java/org/icemobile/samples/mediacast/MediaController.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelpopup-example.xhtml
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mobileshowcase/src/main/java/org/icemobile/samples/mobileshowcase/view/examples/input/menubutton/MenuButtonBean.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/input/submitnotification-example.xhtml
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/samples/mobileshowcase/src/main/webapp/WEB-INF/includes/examples/layout/panelconfirmation-example.xhtml
        Hide
        Patrick Corless added a comment -

        The was a very interesting but to try and track down. It terns out that there is a know issue with Safari with regards to fixed layout and touch events. When the parent panel is scrolled the touch events scroll with the parent panel, leaving the popup panel buttons untouchable. Changing the orientation only exacerbated the problem.

        The solution was to change the popup panel to use an absolution position and implement auto centring code that would center the panel during a scroll or window resize. The main point being that if the popop was called at the bottom a long page the dialog will always be center for easy manipulation.

        Show
        Patrick Corless added a comment - The was a very interesting but to try and track down. It terns out that there is a know issue with Safari with regards to fixed layout and touch events. When the parent panel is scrolled the touch events scroll with the parent panel, leaving the popup panel buttons untouchable. Changing the orientation only exacerbated the problem. The solution was to change the popup panel to use an absolution position and implement auto centring code that would center the panel during a scroll or window resize. The main point being that if the popop was called at the bottom a long page the dialog will always be center for easy manipulation.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #28068 Tue Feb 28 09:18:55 MST 2012 patrick.corless MOBI-147 updated touch event assignment for spinner component and moved the layout to an absolute position and added auto center/scroll code.
        Files Changed
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinnerRenderer.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/ipad/default-time.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/honeycomb/default-time.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/bberry/default-date.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/iphone/default-date.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/resources/org.icefaces.component.datespinner/datespinner.js
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/iphone/default-time.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/bberry/default-time.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/android/default-time.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/honeycomb/default-date.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/resources/org.icefaces.component.util/component.js
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/DateSpinner.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/DateSpinnerRenderer.java
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/ipad/default-date.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/resources/org.icefaces.component.timespinner/timespinner.js
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/datespinner/android/default-date.css
        Commit graph MODIFY /icemobile/branches/icemobile-1.0.0.A/icemobile/components/component/src/org/icefaces/mobi/component/timespinner/TimeSpinner.java
        Hide
        Judy Guglielmin added a comment -

        patrick can this Jira be resolved?

        Show
        Judy Guglielmin added a comment - patrick can this Jira be resolved?
        Judy Guglielmin made changes -
        Assignee Judy Guglielmin [ judy.guglielmin ] Patrick Corless [ patrick.corless ]
        Hide
        Patrick Corless added a comment -

        Closing, issue has been fixed.

        Show
        Patrick Corless added a comment - Closing, issue has been fixed.
        Patrick Corless made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s 1.1 Beta [ 10320 ]
        Fix Version/s 1.0 Final [ 10292 ]
        Resolution Fixed [ 1 ]
        Migration made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Patrick Corless
            Reporter:
            Patrick Corless
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: