ICEfaces-EE
  1. ICEfaces-EE
  2. IPCK-439

EL used in HTML code is not rendered when using the HtmlTagDecorator

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.2.0.GA
          • Fix Version/s: EE-3.3.0.GA
          • Component/s: Core Extensions
          • Labels:
            None
          • Environment:
            All
          • Assignee Priority:
            P1
          • Salesforce Case Reference:
          • Workaround Exists:
            Yes
          • Workaround Description:
            In the case for the link tag, the ice:outputStyle or h:outputStylesheet tags can be used.

            Description

            With the following context parameter set:

                <context-param>
                    <param-name>javax.faces.FACELETS_DECORATORS</param-name>
                    <param-value>com.icesoft.facelets.HtmlTagDecorator</param-value>
                </context-param>

            The EL expression in the following code is not rendered:

                    <link rel="stylesheet" type="text/css"
                          href="#{facesContext.externalContext.requestContextPath}/css/style.css" ></link>

            The following is what the tag gets rendered as:

            <link rel="stylesheet" type="text/css" />

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arran Mccullough added a comment -

              Attached test case that shows issue. Upon load of the page, look at the rendered source.

              Show
              Arran Mccullough added a comment - Attached test case that shows issue. Upon load of the page, look at the rendered source.
              Hide
              Permalink
              Mark Collette added a comment -

              showcase won't load due to an exception due to an app bug that relied on UIInstructions being a peer that instead becomes a parent XhtmlComponent with this feature enabled. Fixed that first.

              icefaces3 trunk
              Subversion 36268

              icefaces EE 33 branch tag
              Subversion 36269

              Show
              Mark Collette added a comment - showcase won't load due to an exception due to an app bug that relied on UIInstructions being a peer that instead becomes a parent XhtmlComponent with this feature enabled. Fixed that first. icefaces3 trunk Subversion 36268 icefaces EE 33 branch tag Subversion 36269
              Hide
              Permalink
              Mark Collette added a comment -

              Fixed it so that attributes using EL or not would both now be rendered through. Fixed it so that only html tags would be converted, and it no longer interferes with other namespaces. So, ace:menu and f:param now work in conjunction with this feature.

              ICE-9358 was causing log warning about a non-final non-static field in the renderer for this, so I looked into that and also found that we had to triple declare the xhtml tag names, in a Map in a class and in two xml files, plus use separate renderers per tag name. I spent some time trying to find a way using the 1.8 approach to remove all of that, but it involved extra configuration, which I've been told was a no-go. So, I only refactored the renderers to remove the log warning.

              icefaces EE 3.3 tag branch
              Subversion 34794

              Show
              Mark Collette added a comment - Fixed it so that attributes using EL or not would both now be rendered through. Fixed it so that only html tags would be converted, and it no longer interferes with other namespaces. So, ace:menu and f:param now work in conjunction with this feature. ICE-9358 was causing log warning about a non-final non-static field in the renderer for this, so I looked into that and also found that we had to triple declare the xhtml tag names, in a Map in a class and in two xml files, plus use separate renderers per tag name. I spent some time trying to find a way using the 1.8 approach to remove all of that, but it involved extra configuration, which I've been told was a no-go. So, I only refactored the renderers to remove the log warning. icefaces EE 3.3 tag branch Subversion 34794
              Hide
              Permalink
              Mark Collette added a comment -

              For broader testing, just enable the context-param in the EE showcase's web.xml.

              Show
              Mark Collette added a comment - For broader testing, just enable the context-param in the EE showcase's web.xml.
              Hide
              Permalink
              Liana Munroe added a comment -

              Confirmed fixed Build 14, ee-3.3.0 GA, however icefaces-ee-ext.jar must be in the classpath and the following config param must be added to the web.xml :
              <context-param>
              <param-name>javax.faces.FACELETS_DECORATORS</param-name>
              <param-value>com.icesoft.facelets.HtmlTagDecorator</param-value>
              </context-param>

              Show
              Liana Munroe added a comment - Confirmed fixed Build 14, ee-3.3.0 GA, however icefaces-ee-ext.jar must be in the classpath and the following config param must be added to the web.xml : <context-param> <param-name>javax.faces.FACELETS_DECORATORS</param-name> <param-value>com.icesoft.facelets.HtmlTagDecorator</param-value> </context-param>
              Hide
              Permalink
              Ken Fyten added a comment -

              The svn commit for rvn# 34794 made to icefaces-ee3/tags/icefaces-ee-3.3.0.GA was not also made to the icefaces-ee3/trunk. Please do so now.

              Show
              Ken Fyten added a comment - The svn commit for rvn# 34794 made to icefaces-ee3/tags/icefaces-ee-3.3.0.GA was not also made to the icefaces-ee3/trunk. Please do so now.
              Hide
              Permalink
              Mark Collette added a comment -

              Ported the fix over to the ICEfaces EE trunk. Had a problem where the stale icefaces-ee-ext.jar was still being used and "ant bundle.clean" wasn't removing it, so had to manually remove all the built jars in icefaces/lib as well as the bundle folder contents.

              ICEfaces EE trunk
              Subversion 34924

              Show
              Mark Collette added a comment - Ported the fix over to the ICEfaces EE trunk. Had a problem where the stale icefaces-ee-ext.jar was still being used and "ant bundle.clean" wasn't removing it, so had to manually remove all the built jars in icefaces/lib as well as the bundle folder contents. ICEfaces EE trunk Subversion 34924

                People

                • Assignee:
                  Mark Collette
                  Reporter:
                  Arran Mccullough
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: