ICEfaces
  1. ICEfaces
  2. ICE-9983

Setting org.icefaces.ace.theme context param to 'none' renders a RES_NOT_FOUND stylesheet

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      Ace

      Description

      According to the wiki documentation, if you do not want an ACE theme to load, you should set the org.icefaces.ace.theme context param to 'none'. Doing this causes the following link stylesheet to be rendered:

      <link href="RES_NOT_FOUND" rel="stylesheet" type="text/css">

      Which results in a 404 error from the server.

      The following is printed to the console: WARNING: JSF1064: Unable to find or serve resource, theme.css, from library, ace-none.

        Activity

        Hide
        Arturo Zambrano added a comment -

        Committed fix to 4.0 trunk at revision 40915 and to 3.3 EE maintenance branch at revision 40914.

        The code to handle the 'none' parameter value must have been lost while moving from relying on the head renderer to the themeSelect component to serve the theme resource. In both codebases, the fix consists in adding code to check if "none" was specified as the org.icefaces.ace.theme context param. In the case of the 4.0 trunk, we'll serve an empty theme.css resource, because of the ResourceHandler approach to serve the resource, which expect a non-null Resource object. In the case of the 3.3 EE maintenance branch, we simply avoid creating a theme Resource.

        Show
        Arturo Zambrano added a comment - Committed fix to 4.0 trunk at revision 40915 and to 3.3 EE maintenance branch at revision 40914. The code to handle the 'none' parameter value must have been lost while moving from relying on the head renderer to the themeSelect component to serve the theme resource. In both codebases, the fix consists in adding code to check if "none" was specified as the org.icefaces.ace.theme context param. In the case of the 4.0 trunk, we'll serve an empty theme.css resource, because of the ResourceHandler approach to serve the resource, which expect a non-null Resource object. In the case of the 3.3 EE maintenance branch, we simply avoid creating a theme Resource.
        Hide
        Carmen Cristurean added a comment -

        Verified with IF4 trunk/ EE-3.3.0-maintenance branch# 40915 in FF28, Chrome34, IE10.

        Show
        Carmen Cristurean added a comment - Verified with IF4 trunk/ EE-3.3.0-maintenance branch# 40915 in FF28, Chrome34, IE10.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: