ICEfaces
  1. ICEfaces
  2. ICE-9888

update qtip js library to resolve jquery-ui css clashes

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2.BETA1, EE-3.3.0.GA_P01
          • Fix Version/s: EE-3.3.0.GA_P02, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf2 ace jquery-ui qtip
          • Assignee Priority:
            P1

            Description

            The <ace:tooltip> uses the qTip2 JavaScript library to handle tooltips. The qTip2 library is included in the JavaScript file that is bundled with icefaces-ee-ace.jar (META-INF/resources/icefaces/ace/util/ace-components.js).

            Unfortunately, the current qTip2 bundled with icefaces has css class names that conflict with the css names used in jquery-ui, preventing users from customizing the other components separately.

            qTip2 has meanwhile fixed this issue, see:-

            https://github.com/qTip2/qTip2/commit/b210209977e845155014a6adfd912308814a4dc0, dated 2012-11-02.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Judy Guglielmin added a comment -

              For assignment and prioritization

              Show
              Judy Guglielmin added a comment - For assignment and prioritization
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Updated qtip to version 2.2

              Committed update to 4.0 trunk at revision 40510 and to 3.3. EE maintenance branch at revision 40512.

              Custom fixes in .js file:

              • replaced occurrences of jQuery for ice.ace.jq
              • removed 'else' keyword when registering plugin with jQuery
              • commented out aria-atomic attributes, which were causing Javascript errors on IE7

              Custom fixes in .css file:

              • added custom extensions
              • added rounded corners in custom extensions
              • removed max width
              • removed font size
              • added box shadow

              I did not re-apply custom fixes applied to the previous version at these revisions:
              30594
              33161
              33766
              31915 I tried re-applying this one, but the internal API is now different, and applying this fix causes rendering problems after the first time a tooltip was displayed.

              These custom fixes might not be necessary with the new qtip code. Qtip 2.2 already comes with ARIA support, and performance seems to have improved.

              Testing notes: please run all regression tests.

              Show
              Arturo Zambrano added a comment - Updated qtip to version 2.2 Committed update to 4.0 trunk at revision 40510 and to 3.3. EE maintenance branch at revision 40512. Custom fixes in .js file: replaced occurrences of jQuery for ice.ace.jq removed 'else' keyword when registering plugin with jQuery commented out aria-atomic attributes, which were causing Javascript errors on IE7 Custom fixes in .css file: added custom extensions added rounded corners in custom extensions removed max width removed font size added box shadow I did not re-apply custom fixes applied to the previous version at these revisions: 30594 33161 33766 31915 I tried re-applying this one, but the internal API is now different, and applying this fix causes rendering problems after the first time a tooltip was displayed. These custom fixes might not be necessary with the new qtip code. Qtip 2.2 already comes with ARIA support, and performance seems to have improved. Testing notes: please run all regression tests.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: