Details
Improvement
Major
Description
Try to replace YUI Compressor and ShrinkSafe JS minifiers with Google's Closure Compiler ( https://developers.google.com/closure/compiler/ ). This will allows us to use only one minification tool across all sub-projects.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
1) The GMAp issue is caused by an evaluation of code that references a local variable. Since local variables are renamed by the compressor the evaluation fails.
The fix changes slightly the code to avoid evaluating the local variables, instead evaluate only the passed in options which were meant to be evaluated.
Show
Mircea Toma
added a comment - - edited 1) The GMAp issue is caused by an evaluation of code that references a local variable. Since local variables are renamed by the compressor the evaluation fails.
The fix changes slightly the code to avoid evaluating the local variables, instead evaluate only the passed in options which were meant to be evaluated.
2) I cannot reproduce the warnings shown during the build. I even ran the build with code that was freshly check-out, the results was the same.
Show
Mircea Toma
added a comment - 2) I cannot reproduce the warnings shown during the build. I even ran the build with code that was freshly check-out, the results was the same.
Note that ICEfaces 4 should use Ant 1.8.4 as a minimum version.
Confirming that no warnings occur if building Icefaces4 with Ant 1.8.4.
Show
Carmen Cristurean
added a comment - Confirming that no warnings occur if building Icefaces4 with Ant 1.8.4.
Created issue ICE-9809 to make sure the warnings are fixed, not just ignored.
Show
Mircea Toma
added a comment - Created issue ICE-9809 to make sure the warnings are fixed, not just ignored.
Replaces ShrinkSafe and YUICompressor minifiers with ClosureCompiler. Also modified build files to use this new tool.