ICEfaces
  1. ICEfaces
  2. ICE-9751

ability for tooltip to work when require.js is present

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P01
          • Fix Version/s: 4.0, EE-3.3.0.GA_P03
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            jsf2 ace
          • Assignee Priority:
            P2
          • Salesforce Case Reference:

            Description

            jquery.qtip-2.0.0.js is already require.js aware....
            (function(factory) {
            "use strict";
            if(typeof define === 'function' && define.amd) {
            define(['jquery'], factory);
            }
            else if(ice.ace.jq && !ice.ace.jq.fn.qtip) { remove else for ICE-9751
            factory(ice.ace.jq);
            }
            }

            need to take "else" out of the loading so it will load ice.ace whether require.js exists or not.

              Activity

              Ascending order - Click to sort in descending order
              Judy Guglielmin created issue -
              Judy Guglielmin made changes -
              Field Original Value New Value
              Salesforce Case Reference 5007000000YZ1EqAAL
              Hide
              Permalink
              Judy Guglielmin added a comment -

              for targetting...

              Show
              Judy Guglielmin added a comment - for targetting...
              Judy Guglielmin made changes -
              Assignee Ken Fyten [ ken.fyten ]
              Ken Fyten made changes -
              Assignee Ken Fyten [ ken.fyten ] Judy Guglielmin [ judy.guglielmin ]
              Fix Version/s 4.0 [ 10770 ]
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #39457 Thu Dec 19 04:02:32 MST 2013 judy.guglielmin ICE-9751
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-2.0.0.js
              Hide
              Permalink
              Judy Guglielmin added a comment - - edited

              rev 35942 for 3.3.0-P02
              rev 39457 for ICEfaces 4 trunk

              Show
              Judy Guglielmin added a comment - - edited rev 35942 for 3.3.0-P02 rev 39457 for ICEfaces 4 trunk
              Judy Guglielmin made changes -
              Description reference in tooltip.js to this.jq.tooltip may be causing problems with 3rd party js libraries (require.js).
              if (!this.cfg.forDelegate) {
              this.jq.qtip(this.cfg);
              } else {
              delete self.cfg.events.show; delete self.cfg.events.hide; // will call them manually
              ice.ace.DelegateTooltips[self.cfg.id] = {};
              var delegateNode = this.jq.children().get(0);
              this.jq.delegate('*', this.cfg.show.event, function(event) {

              .....
              should be ice.ace.jq instead of this.jq as other libraries may have reference to this.jq and no qtip library reference.               		jquery.qtip-2.0.0.js is already require.js aware....
              (function(factory) {
              "use strict";
              if(typeof define === 'function' && define.amd) {
              define(['jquery'], factory);
              }
              else if(ice.ace.jq && !ice.ace.jq.fn.qtip) { remove else for ICE-9751
              factory(ice.ace.jq);
              }
              }

              need to take "else" out of the loading so it will load ice.ace whether require.js exists or not.
              Judy Guglielmin made changes -
              Summary assure proper javascript namespace for panelTooltip ability for tooltip to work when require.js is present
              Hide
              Permalink
              Judy Guglielmin added a comment -

              see last comment for revision numbers both targets

              Show
              Judy Guglielmin added a comment - see last comment for revision numbers both targets
              Judy Guglielmin made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #40505 Tue Apr 01 11:58:57 MDT 2014 art.zambrano ICE-9888 removed 'else' keyword (ICE-9751)
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-2.0.0.js
              Hide
              Permalink
              Judy Guglielmin added a comment -

              based on support case info (SC 12930), modify js for loading with require.js

              Show
              Judy Guglielmin added a comment - based on support case info (SC 12930), modify js for loading with require.js
              Judy Guglielmin made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Judy Guglielmin made changes -
              Fix Version/s 4.0 [ 11382 ]
              Fix Version/s EE-3.3.0.GA_P03 [ 11572 ]
              Fix Version/s 4.0.BETA [ 10770 ]
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #41775 Fri Jul 11 16:57:18 MDT 2014 judy.guglielmin ICE-9751
              Files Changed
              Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-2.0.0.js
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 41774 ->3.3.0 mtce (P03)
              rev 41775 -> IF4

              Show
              Judy Guglielmin added a comment - rev 41774 ->3.3.0 mtce (P03) rev 41775 -> IF4
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Judy Guglielmin
                  Reporter:
                  Judy Guglielmin
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: