ICEfaces
  1. ICEfaces
  2. ICE-9731

Update CKEditor to version 4.3

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      InternetExplorer 11
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)
    • Workaround Exists:
      Yes
    • Workaround Description:
      Hide
      Add this tag int the header of the page

      <meta http-equiv="X-UA-Compatible" content="IE=10" />
      Show
      Add this tag int the header of the page <meta http-equiv="X-UA-Compatible" content="IE=10" />

      Description

      In order to support IE11 in ace:richTextEntry, it is necessary to update our CKEditor library to version 4.3.

      Enter a small piece of text into the richt text editor. Now select a word in the middle of the text and try to change the color of the selected text.

      Every time you click in the command bar of the rich text editor (to select the tool) the selection will be removed and the color will be aplyed to the the new cursor position, which is the

        Issue Links

          Activity

          Hide
          Arturo Zambrano added a comment - - edited

          Chrome, The content area now consumes most of the web page vertically, the component is not limited in height.

          Reviewing the CKEditor documentation, for both the 3.x and 4.x versions, reveals that the height cannot be expressed in percent units (%) and that the default height is 200px, as stated in these documentation pages:

          http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html#.height
          http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-height

          Moreover, the height only applies to the editable area, while the width applies to the entire editor.

          The TLD documentation was updated to match the CKEditor description for these attributes.

          Therefore, with a default height of 200px (and avoiding the use of percent units), the editor will now be bound by that height, unless a different explicit height is set.

          Committed these changes to the 4.0 trunk at revision 40783 and to the 3.3 EE maintenance branch at revision 40784.

          Committed these changes to 3.3 EE maintenance branch for ice:inputRichText at revision 40787.

          Show
          Arturo Zambrano added a comment - - edited Chrome, The content area now consumes most of the web page vertically, the component is not limited in height. Reviewing the CKEditor documentation, for both the 3.x and 4.x versions, reveals that the height cannot be expressed in percent units (%) and that the default height is 200px, as stated in these documentation pages: http://docs.cksource.com/ckeditor_api/symbols/CKEDITOR.config.html#.height http://docs.ckeditor.com/#!/api/CKEDITOR.config-cfg-height Moreover, the height only applies to the editable area, while the width applies to the entire editor. The TLD documentation was updated to match the CKEditor description for these attributes. Therefore, with a default height of 200px (and avoiding the use of percent units), the editor will now be bound by that height, unless a different explicit height is set. Committed these changes to the 4.0 trunk at revision 40783 and to the 3.3 EE maintenance branch at revision 40784. Committed these changes to 3.3 EE maintenance branch for ice:inputRichText at revision 40787.
          Hide
          Arturo Zambrano added a comment -

          Revisions 40794 and 40795... TLD doc and behaviour update regarding the 'skin' attribute: the attribute only applies to IE7 skins (old editor); all other browsers will use the 'moono' skin.

          Show
          Arturo Zambrano added a comment - Revisions 40794 and 40795... TLD doc and behaviour update regarding the 'skin' attribute: the attribute only applies to IE7 skins (old editor); all other browsers will use the 'moono' skin.
          Hide
          Arturo Zambrano added a comment -

          Resolving issue. Spinning off background colour issue to ICE-9971.

          Show
          Arturo Zambrano added a comment - Resolving issue. Spinning off background colour issue to ICE-9971 .
          Hide
          Liana Munroe added a comment -

          Affects component-showcase, icefaces ee-3.3.0 maintenance branch.
          While verifying the fix for ICE-9970 I noticed that the Component showcase Rich Text Demo save function does not work in IE7.
          This is only the case with the component-showcase demo page. When testing the ice:inputRichText Demo in showcase ICE components there is no issue.

          IE 7 error when trying to save data.
          Line 2
          CHar 14523
          Error: 'name' is null or not an object
          Code: 0

          Issues only happens when using component-showcase .war, does not happen with showcase ICE component demo.

          Show
          Liana Munroe added a comment - Affects component-showcase, icefaces ee-3.3.0 maintenance branch. While verifying the fix for ICE-9970 I noticed that the Component showcase Rich Text Demo save function does not work in IE7. This is only the case with the component-showcase demo page. When testing the ice:inputRichText Demo in showcase ICE components there is no issue. IE 7 error when trying to save data. Line 2 CHar 14523 Error: 'name' is null or not an object Code: 0 Issues only happens when using component-showcase .war, does not happen with showcase ICE component demo.
          Hide
          Arturo Zambrano added a comment -

          This last issue in the comment above is not related to the ice:inputRichText component, but to the ice:selectOneMenu component in the form. Closing this issue and documenting the ice:selectOneMenu issue in ICE-9974.

          Show
          Arturo Zambrano added a comment - This last issue in the comment above is not related to the ice:inputRichText component, but to the ice:selectOneMenu component in the form. Closing this issue and documenting the ice:selectOneMenu issue in ICE-9974 .

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Jose Gonzalez
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: