ICEfaces
  1. ICEfaces
  2. ICE-9681

Modify DOMResponseWriter to render passthrough attribute

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 4.0.BETA
          • Fix Version/s: 4.0.BETA, 4.0
          • Component/s: Framework
          • Labels:
            None
          • Environment:
            ICEfaces
          • Assignee Priority:
            P1

            Description

            Component passthrough attributes seem to be response's writer responsibility (at least that is true in Mojarra). We need to implement this new feature in our DOMResponseWriter to match the writer's behaviour.

              Issue Links

              blocks

              New Feature - A new feature of the product, which has yet to be developed. ICE-9436 Support for JSF 2.2 HTML 5 passthrough attributes

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Mircea Toma added a comment -

                Read passthrough attributes from the component, if available, and render them just before the DOMResponseWriter.endElement method returns.

                Show
                Mircea Toma added a comment - Read passthrough attributes from the component, if available, and render them just before the DOMResponseWriter.endElement method returns.
                Hide
                Permalink
                Ken Fyten added a comment -

                This commit has broken the icefaces4/trunk build:

                compile:
                [javac] Compiling 188 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/build/classes
                [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java:275: cannot find symbol
                [javac] symbol : method getPassThroughAttributes(boolean)
                [javac] location: class javax.faces.component.UIComponent
                [javac] Map<String, Object> passthroughAttributes = component.getPassThroughAttributes(false);
                [javac] ^
                [javac] Note: Some input files use or override a deprecated API.
                [javac] Note: Recompile with -Xlint:deprecation for details.
                [javac] Note: Some input files use unchecked or unsafe operations.
                [javac] Note: Recompile with -Xlint:unchecked for details.
                [javac] 1 error

                BUILD FAILED

                Show
                Ken Fyten added a comment - This commit has broken the icefaces4/trunk build: compile: [javac] Compiling 188 source files to /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/build/classes [javac] /Users/Ken/Code/svn/icefaces4-trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMResponseWriter.java:275: cannot find symbol [javac] symbol : method getPassThroughAttributes(boolean) [javac] location: class javax.faces.component.UIComponent [javac] Map<String, Object> passthroughAttributes = component.getPassThroughAttributes(false); [javac] ^ [javac] Note: Some input files use or override a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error BUILD FAILED
                Hide
                Permalink
                Mircea Toma added a comment -

                Use reflection to invoke UIComponent.getPassThroughAttributes method since this is present only in JSF 2.2.

                Show
                Mircea Toma added a comment - Use reflection to invoke UIComponent.getPassThroughAttributes method since this is present only in JSF 2.2.

                  People

                  • Assignee:
                    Mircea Toma
                    Reporter:
                    Mircea Toma
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: