ICEfaces
  1. ICEfaces
  2. ICE-9639

Regression: JS Errors When Removing Focus From Certain Components

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P01
    • Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces3 trunk revision 38556
      All browsers
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      There are JS errors occuring when tabbing away (blur) from certain components. I've noticed it with: textEntry, textAreaEntry, autoCompleteEntry, selectMenu, comboBox, and checkboxButton. This is also preventing the ajax events and listeners from firing for textEntry and textAreaEntry.

      In Firefox:
      ReferenceError: setFocus is not defined
      http://localhost:8080/focusManager/javax.faces.resource/util/ace-components.uncompressed.js.jsf?ln=icefaces.ace&v=3_4_0_131008
      Line 2929

      In IE:
      Message: 'setFocus' is undefined
      Line: 2929
      Char: 9
      Code: 0
      URI: http://localhost:8080/focusManager/javax.faces.resource/util/ace-components.uncompressed.js.jsf?ln=icefaces.ace&v=3_4_0_131008

        Activity

        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38598 Mon Oct 14 11:00:21 MDT 2013 mircea.toma ICE-9639 Applying focus to the first or the specified component only when 'ice.focus' parameter is missing, thus making sure to not interfere at all with the focus retention feature.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/FocusManager.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38581 Thu Oct 10 16:39:09 MDT 2013 mircea.toma ICE-9639 Modified FocusManager to set focus on the first entry only when ice.focus parameter is missing or it's equal to ''. This helps avoiding any interference with the focus retention feature. FocusManager is now also applying the focus through the FocusController (used for focus retention) to avoid sending multiple focus commands to the browser.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/JavaScriptRunnerSetup.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/util/FocusController.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/FocusManager.java
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #38563 Tue Oct 08 16:01:33 MDT 2013 mircea.toma ICE-9639 Modified ACE components that are referencing _setFocus_ function in their JS code to be using now _ice.setFocus_ (which is part of the public bridge API).
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/textentry/textentry.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/combobox/combobox.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/textareaentry/textareaentry.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/datetimeentry.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js
        Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/util/PassThruAttributeWriter.java

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Cruz Miraback
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: