[ICE-9639] Regression: JS Errors When Removing Focus From Certain Components - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Critical
Resolution: Fixed
Affects Version/s: EE-3.3.0.GA_P01
Fix Version/s: 4.0.BETA, EE-3.3.0.GA_P02, 4.0
Component/s: ACE-Components
Labels:
None
Environment:
ICEfaces3 trunk revision 38556
All browsers

Assignee Priority:
P1
Salesforce Case Reference:

Description

There are JS errors occuring when tabbing away (blur) from certain components. I've noticed it with: textEntry, textAreaEntry, autoCompleteEntry, selectMenu, comboBox, and checkboxButton. This is also preventing the ajax events and listeners from firing for textEntry and textAreaEntry.

In Firefox:
ReferenceError: setFocus is not defined
http://localhost:8080/focusManager/javax.faces.resource/util/ace-components.uncompressed.js.jsf?ln=icefaces.ace&v=3_4_0_131008
Line 2929

In IE:
Message: 'setFocus' is undefined
Line: 2929
Char: 9
Code: 0
URI: http://localhost:8080/focusManager/javax.faces.resource/util/ace-components.uncompressed.js.jsf?ln=icefaces.ace&v=3_4_0_131008

Activity

Ascending order - Click to sort in descending order

Cruz Miraback created issue - 08/Oct/13 3:00 PM

Ken Fyten made changes - 08/Oct/13 3:04 PM

Field	Original Value	New Value
Assignee		Mircea Toma [ mircea.toma ]
Security		Private [ 10001 ]
Priority	Major [ 3 ]	Critical [ 2 ]
Assignee Priority		P1 [ 10010 ]

Hide

Permalink

Mircea Toma added a comment - 08/Oct/13 3:56 PM

Modified ACE components that are referencing setFocus function in their JS code to be using now ice.setFocus (which is part of the public bridge API). When compat resources are not loaded setFocus function is not defined. The compat resources are now loaded only when needed, see ~~ICE-9622~~.

Show

Mircea Toma added a comment - 08/Oct/13 3:56 PM Modified ACE components that are referencing setFocus function in their JS code to be using now ice.setFocus (which is part of the public bridge API). When compat resources are not loaded setFocus function is not defined. The compat resources are now loaded only when needed, see ICE-9622 .

Mircea Toma made changes - 08/Oct/13 3:56 PM

Status	Open [ 1 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#38563	Tue Oct 08 16:01:33 MDT 2013	mircea.toma	~~ICE-9639~~ Modified ACE components that are referencing _setFocus_ function in their JS code to be using now _ice.setFocus_ (which is part of the public bridge API).
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/combobox/ComboBoxRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/textentry/textentry.js MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/selectmenu/selectmenu.js MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/combobox/combobox.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/autocompleteentry/AutoCompleteEntryRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/selectmenu/SelectMenuRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/textareaentry/textareaentry.js MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datetimeentry/datetimeentry.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/simpleselectonemenu/SimpleSelectOneMenuRenderer.java MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/autocompleteentry/autocompleteentry.js MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/util/PassThruAttributeWriter.java

Hide

Permalink

Cruz Miraback added a comment - 09/Oct/13 11:58 AM

The changes for this caused a regression in icecore:focusManager (revision# 38563). When using this config, after the page has loaded the focus can not be changed from where it is placed initially. When trying to move focus, either by clicking or tabbing away from the field, the focus immediately moves back.

Show

Cruz Miraback added a comment - 09/Oct/13 11:58 AM The changes for this caused a regression in icecore:focusManager (revision# 38563). When using this config, after the page has loaded the focus can not be changed from where it is placed initially. When trying to move focus, either by clicking or tabbing away from the field, the focus immediately moves back.

Cruz Miraback made changes - 09/Oct/13 11:58 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 09/Oct/13 2:19 PM

How can I reproduce this new regression?

Show

Mircea Toma added a comment - 09/Oct/13 2:19 PM How can I reproduce this new regression?

Hide

Permalink

Cruz Miraback added a comment - 09/Oct/13 2:29 PM

I just placed a test app at 'iceads1/Public/QA/JIRAs/~~ICE-9639~~.war'. Upon further testing it seems to only be an issue when an ACE component (ace:textEntry in this case) is first in the form.

Show

Cruz Miraback added a comment - 09/Oct/13 2:29 PM I just placed a test app at 'iceads1/Public/QA/JIRAs/ ICE-9639 .war'. Upon further testing it seems to only be an issue when an ACE component (ace:textEntry in this case) is first in the form.

Hide

Permalink

Mircea Toma added a comment - 10/Oct/13 4:35 PM

Modified FocusManager to set focus on the first entry only when ice.focus parameter is missing or it's equal to ''. This helps avoiding any interference with the focus retention feature. FocusManager is now also applying the focus through the FocusController (used for focus retention) to avoid sending multiple focus commands to the browser.

Show

Mircea Toma added a comment - 10/Oct/13 4:35 PM Modified FocusManager to set focus on the first entry only when ice.focus parameter is missing or it's equal to ''. This helps avoiding any interference with the focus retention feature. FocusManager is now also applying the focus through the FocusController (used for focus retention) to avoid sending multiple focus commands to the browser.

Mircea Toma made changes - 10/Oct/13 4:35 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#38581	Thu Oct 10 16:39:09 MDT 2013	mircea.toma	~~ICE-9639~~ Modified FocusManager to set focus on the first entry only when ice.focus parameter is missing or it's equal to ''. This helps avoiding any interference with the focus retention feature. FocusManager is now also applying the focus through the FocusController (used for focus retention) to avoid sending multiple focus commands to the browser.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/event/JavaScriptRunnerSetup.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/context/DOMPartialViewContext.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/util/FocusController.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/FocusManager.java

Hide

Permalink

Cruz Miraback added a comment - 11/Oct/13 7:55 AM

I'm still getting the focus issue as described, testing on trunk revision# 38584 in Firefox24, Chrome30, and IE10 using the test app at 'iceads1/Public/QA/JIRAs/~~ICE-9639~~.war'. I'm unable to move focus away from the first component in the form.

Show

Cruz Miraback added a comment - 11/Oct/13 7:55 AM I'm still getting the focus issue as described, testing on trunk revision# 38584 in Firefox24, Chrome30, and IE10 using the test app at 'iceads1/Public/QA/JIRAs/ ICE-9639 .war'. I'm unable to move focus away from the first component in the form.

Cruz Miraback made changes - 11/Oct/13 7:55 AM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Hide

Permalink

Mircea Toma added a comment - 14/Oct/13 10:56 AM

Applying focus to the first or the specified component only when 'ice.focus' parameter is missing, thus making sure to not interfere at all with the focus retention feature.

Show

Mircea Toma added a comment - 14/Oct/13 10:56 AM Applying focus to the first or the specified component only when 'ice.focus' parameter is missing, thus making sure to not interfere at all with the focus retention feature.

Mircea Toma made changes - 14/Oct/13 10:56 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#38598	Mon Oct 14 11:00:21 MDT 2013	mircea.toma	~~ICE-9639~~ Applying focus to the first or the specified component only when 'ice.focus' parameter is missing, thus making sure to not interfere at all with the focus retention feature.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/impl/component/FocusManager.java

Hide

Permalink

Mircea Toma added a comment - 13/Nov/13 3:42 PM

Apply setFocus patch to the maintenance branch.

Show

Mircea Toma added a comment - 13/Nov/13 3:42 PM Apply setFocus patch to the maintenance branch.

Mircea Toma made changes - 13/Nov/13 3:42 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Mircea Toma made changes - 13/Nov/13 3:43 PM

Fix Version/s

EE-3.3.0.GA_P02 [ 11371 ]

Mircea Toma made changes - 13/Nov/13 3:43 PM

Affects Version/s

EE-3.3.0.GA_P01 [ 11174 ]

Hide

Permalink

Mircea Toma added a comment - 14/Nov/13 8:04 AM

Replaced setFocus() function usages with ice.setFocus(). setFocus() function is defined only when any of the compat components are loaded.

Show

Mircea Toma added a comment - 14/Nov/13 8:04 AM Replaced setFocus() function usages with ice.setFocus(). setFocus() function is defined only when any of the compat components are loaded.

Mircea Toma made changes - 14/Nov/13 8:04 AM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Hide

Permalink

Liana Munroe added a comment - 09/Dec/13 4:44 PM

Issue no longer seen on icefaces-ee-3.3.0.GA-maintenance revision #39255.

Show

Liana Munroe added a comment - 09/Dec/13 4:44 PM Issue no longer seen on icefaces-ee-3.3.0.GA-maintenance revision #39255.

Ken Fyten made changes - 29/Jan/14 10:57 AM

Affects Version/s

4.0 [ 10770 ]

Ken Fyten made changes - 29/Jan/14 10:57 AM

Security

Private [ 10001 ]

Judy Guglielmin made changes - 05/Feb/14 9:43 AM

Salesforce Case Reference

5007000000ZC1GcAAL

Ken Fyten made changes - 30/Oct/14 11:28 AM

Fix Version/s

4.0 [ 11382 ]

Ken Fyten made changes - 14/Nov/14 5:19 PM

Status

Resolved [ 5 ]

Closed [ 6 ]

Hide

Permalink

Kyle Stiemann added a comment - 04/Nov/15 7:04 AM

A workaround for this issue (as noted in ICE-8444) is to include the icefaces-compat.jar as a dependency.

Show

Kyle Stiemann added a comment - 04/Nov/15 7:04 AM A workaround for this issue (as noted in ICE-8444 ) is to include the icefaces-compat.jar as a dependency.

People

Assignee:

Mircea Toma

Reporter:

Cruz Miraback

Votes:

0 Vote for this issue

Watchers:

4 Start watching this issue

Dates

Created:

08/Oct/13 3:00 PM

Updated:

04/Nov/15 7:04 AM

Resolved:

14/Nov/13 8:04 AM