Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.3.0.GA_P02
    • Fix Version/s: EE-3.3.0.GA_P02, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces 3.x ACE Components
    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

      Description

      Add a new ace:buttonGroup container component.

      This container would provide the following features:

      - A visual border around the buttons (CSS/Theme)
      - Optional mutual exclusivity between buttons in the group (only one checkboxButton in the group can be selected at one time, selecting a new checkboxButton deselects the previously selected one.
      - Optional Header label and facet support.

        Activity

        Hide
        yip.ng added a comment - - edited

        Rendering and styling done as required in JIRA Description: screenshot-01.png. That's the easy part. Next is the more difficult task of enforcing mutual exclusivity.

        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup#37280
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroup.java#37280
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37280
        A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37280

        Show
        yip.ng added a comment - - edited Rendering and styling done as required in JIRA Description: screenshot-01.png . That's the easy part. Next is the more difficult task of enforcing mutual exclusivity. A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroup.java#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37280
        Hide
        yip.ng added a comment - - edited

        Suggestion from meeting (by Mark): Grouping could be logical as well, not just within container.

        Mutual exclusivity done: video.

        Logical grouping done similarly to "spread" layout of 1.8 <ice:selectManyCheckbox>. (Adding "group" attribute to checkboxButton: screenshot-02.png.)

        Apart from new code to do grouping and mutual exclusivity, no change was made to the existing checkboxButton code whatsoever. Therefore its behavior is exactly the same as before.

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37298
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37298
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\checkboxbutton\checkboxbutton.js#37298
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonMeta.java#37298
        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java#37298

        Show
        yip.ng added a comment - - edited Suggestion from meeting (by Mark): Grouping could be logical as well, not just within container. Mutual exclusivity done: video . Logical grouping done similarly to "spread" layout of 1.8 <ice:selectManyCheckbox>. (Adding "group" attribute to checkboxButton: screenshot-02.png .) Apart from new code to do grouping and mutual exclusivity, no change was made to the existing checkboxButton code whatsoever. Therefore its behavior is exactly the same as before. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\checkboxbutton\checkboxbutton.js#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonMeta.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java#37298
        Hide
        yip.ng added a comment -

        Radio button group also done. See ICE-9477 for radio button component.

        M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37347

        Show
        yip.ng added a comment - Radio button group also done. See ICE-9477 for radio button component. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37347
        Hide
        Carmen Cristurean added a comment - - edited

        In showcase -> buttonGroup - Overview (revision #37856/ 382388): console error when choosing radio buttons in Firefox and IE (not an issue in Chrome).

        FF23:
        TypeError: g is null
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=o87tz3
        Line 5780

        IE10:
        SCRIPT5007: Unable to get property 'type' of undefined or null reference
        coalesced.js.jsf, line 5780 character 984

        These errors are actually caused by the radioButton component, as they can be reproduced also on the ace:RadioButton Overview and Custom Style demos in showcase.

        Show
        Carmen Cristurean added a comment - - edited In showcase -> buttonGroup - Overview (revision #37856/ 382388): console error when choosing radio buttons in Firefox and IE (not an issue in Chrome). FF23: TypeError: g is null http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=o87tz3 Line 5780 IE10: SCRIPT5007: Unable to get property 'type' of undefined or null reference coalesced.js.jsf, line 5780 character 984 These errors are actually caused by the radioButton component, as they can be reproduced also on the ace:RadioButton Overview and Custom Style demos in showcase.
        Hide
        Arturo Zambrano added a comment -

        Committed fix for last issue at revision 38263. Removed some unnecessary lazy-loading code that was causing the error.

        Show
        Arturo Zambrano added a comment - Committed fix for last issue at revision 38263. Removed some unnecessary lazy-loading code that was causing the error.
        Hide
        Carmen Cristurean added a comment -

        Verified fix for last issue with rev# 38267 in Chrome/FF23/IE10 using showcase sample and radioButton test app.

        Show
        Carmen Cristurean added a comment - Verified fix for last issue with rev# 38267 in Chrome/FF23/IE10 using showcase sample and radioButton test app.
        Hide
        Judy Guglielmin added a comment -

        rev 40068 to 3.3.0 mtce branch and 37373 for QA on repo

        Show
        Judy Guglielmin added a comment - rev 40068 to 3.3.0 mtce branch and 37373 for QA on repo
        Hide
        Carmen Cristurean added a comment -

        Re-opening because of the following errors found in showcase (Firefox only; using Jenkins EE 3 trunk Build # 425):

        1) buttonGroup > Overview:
        Clicking inside the form with the buttonGroup and tabbing through triggers browser console errors when checkboxes gain focus:

        TypeError: e is undefined
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=mhw7pq
        Line 38498

        2) checkBoxButton> Custom Style: similar error when clicking in first checkbox and then tabbing through.

        Show
        Carmen Cristurean added a comment - Re-opening because of the following errors found in showcase (Firefox only; using Jenkins EE 3 trunk Build # 425): 1) buttonGroup > Overview: Clicking inside the form with the buttonGroup and tabbing through triggers browser console errors when checkboxes gain focus: TypeError: e is undefined http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=mhw7pq Line 38498 2) checkBoxButton> Custom Style: similar error when clicking in first checkbox and then tabbing through.
        Hide
        Carmen Cristurean added a comment -

        The browser console error is still reproducible in Firefox with EE-3.3.0-maintenance rev.41200:
        TypeError: c is undefined
        http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb
        Line 466

        Show
        Carmen Cristurean added a comment - The browser console error is still reproducible in Firefox with EE-3.3.0-maintenance rev.41200: TypeError: c is undefined http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb Line 466
        Hide
        Mircea Toma added a comment -

        Make sure to pass in the event object to the ice.ace.checkboxbutton.onAriaKeypress method when wring the keypress event callback.

        The trunk was fixed by ICE-9728.

        Show
        Mircea Toma added a comment - Make sure to pass in the event object to the ice.ace.checkboxbutton.onAriaKeypress method when wring the keypress event callback. The trunk was fixed by ICE-9728.
        Hide
        Carmen Cristurean added a comment -

        Testing with EE-3.3.0-maintenance branch rev. 41221/FF29, Chrome35, IE10, no JS errors have been found.

        Show
        Carmen Cristurean added a comment - Testing with EE-3.3.0-maintenance branch rev. 41221/FF29, Chrome35, IE10, no JS errors have been found.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Ken Fyten
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: