ICEfaces
  1. ICEfaces
  2. ICE-9476

New ace:buttonGroup container

          Details

          • Type: New Feature New Feature
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: EE-3.3.0.GA_P02
          • Fix Version/s: EE-3.3.0.GA_P02, 4.0
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            ICEfaces 3.x ACE Components
          • Assignee Priority:
            P2
          • Affects:
            Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial

            Description

            Add a new ace:buttonGroup container component.

            This container would provide the following features:

            - A visual border around the buttons (CSS/Theme)
            - Optional mutual exclusivity between buttons in the group (only one checkboxButton in the group can be selected at one time, selecting a new checkboxButton deselects the previously selected one.
            - Optional Header label and facet support.

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Ken Fyten made changes -
              Field Original Value New Value
              Assignee yip.ng [ yip.ng ]
              Fix Version/s 3.4 [ 10770 ]
              Assignee Priority P2 [ 10011 ]
              yip.ng made changes -
              Attachment screenshot-01.png [ 16177 ]
              Hide
              Permalink
              yip.ng added a comment - - edited

              Rendering and styling done as required in JIRA Description: screenshot-01.png. That's the easy part. Next is the more difficult task of enforcing mutual exclusivity.

              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup#37280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroup.java#37280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37280
              A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37280

              Show
              yip.ng added a comment - - edited Rendering and styling done as required in JIRA Description: screenshot-01.png . That's the easy part. Next is the more difficult task of enforcing mutual exclusivity. A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroup.java#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37280 A: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37280
              yip.ng made changes -
              Attachment screenshot-01.png [ 16177 ]
              yip.ng made changes -
              Attachment screenshot-01.png [ 16178 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37280 Tue Jul 30 17:24:34 MDT 2013 yip.ng ICE-9476: New ace:buttonGroup container.
              Files Changed
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroupRenderer.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroupMeta.java
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup
              Commit graph ADD /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroup.java
              Hide
              Permalink
              yip.ng added a comment - - edited

              Suggestion from meeting (by Mark): Grouping could be logical as well, not just within container.

              Mutual exclusivity done: video.

              Logical grouping done similarly to "spread" layout of 1.8 <ice:selectManyCheckbox>. (Adding "group" attribute to checkboxButton: screenshot-02.png.)

              Apart from new code to do grouping and mutual exclusivity, no change was made to the existing checkboxButton code whatsoever. Therefore its behavior is exactly the same as before.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37298
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37298
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\checkboxbutton\checkboxbutton.js#37298
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonMeta.java#37298
              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java#37298

              Show
              yip.ng added a comment - - edited Suggestion from meeting (by Mark): Grouping could be logical as well, not just within container. Mutual exclusivity done: video . Logical grouping done similarly to "spread" layout of 1.8 <ice:selectManyCheckbox>. (Adding "group" attribute to checkboxButton: screenshot-02.png .) Apart from new code to do grouping and mutual exclusivity, no change was made to the existing checkboxButton code whatsoever. Therefore its behavior is exactly the same as before. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupMeta.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\resources\icefaces.ace\checkboxbutton\checkboxbutton.js#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonMeta.java#37298 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\checkboxbutton\CheckboxButtonRenderer.java#37298
              yip.ng made changes -
              Attachment screenshot-02.png [ 16181 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37298 Thu Aug 01 15:08:56 MDT 2013 yip.ng ICE-9476: New ace:buttonGroup container.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroupRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroupMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/checkboxbutton/CheckboxButtonMeta.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/checkboxbutton/checkboxbutton.js
              Hide
              Permalink
              yip.ng added a comment -

              Radio button group also done. See ICE-9477 for radio button component.

              M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37347

              Show
              yip.ng added a comment - Radio button group also done. See ICE-9477 for radio button component. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\buttongroup\ButtonGroupRenderer.java#37347
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #37347 Thu Aug 08 16:21:50 MDT 2013 yip.ng ICE-9476: New ace:buttonGroup container.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/buttongroup/ButtonGroupRenderer.java
              Ken Fyten made changes -
              Assignee yip.ng [ yip.ng ] Arturo Zambrano [ artzambrano ]
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Hide
              Permalink
              Carmen Cristurean added a comment - - edited

              In showcase -> buttonGroup - Overview (revision #37856/ 382388): console error when choosing radio buttons in Firefox and IE (not an issue in Chrome).

              FF23:
              TypeError: g is null
              http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=o87tz3
              Line 5780

              IE10:
              SCRIPT5007: Unable to get property 'type' of undefined or null reference
              coalesced.js.jsf, line 5780 character 984

              These errors are actually caused by the radioButton component, as they can be reproduced also on the ace:RadioButton Overview and Custom Style demos in showcase.

              Show
              Carmen Cristurean added a comment - - edited In showcase -> buttonGroup - Overview (revision #37856/ 382388): console error when choosing radio buttons in Firefox and IE (not an issue in Chrome). FF23: TypeError: g is null http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=o87tz3 Line 5780 IE10: SCRIPT5007: Unable to get property 'type' of undefined or null reference coalesced.js.jsf, line 5780 character 984 These errors are actually caused by the radioButton component, as they can be reproduced also on the ace:RadioButton Overview and Custom Style demos in showcase.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix for last issue at revision 38263. Removed some unnecessary lazy-loading code that was causing the error.

              Show
              Arturo Zambrano added a comment - Committed fix for last issue at revision 38263. Removed some unnecessary lazy-loading code that was causing the error.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #38263 Mon Sep 23 15:37:04 MDT 2013 art.zambrano ICE-9476, ICE-9477 removed unnecessary lazy loading code that was causing error
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/radiobutton/radiobutton.js
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Verified fix for last issue with rev# 38267 in Chrome/FF23/IE10 using showcase sample and radioButton test app.

              Show
              Carmen Cristurean added a comment - Verified fix for last issue with rev# 38267 in Chrome/FF23/IE10 using showcase sample and radioButton test app.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Affects Documentation (User Guide, Ref. Guide, etc.),Sample App./Tutorial [ 10003, 10001 ]
              Assignee Priority P1 [ 10010 ] P2 [ 10011 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ] Judy Guglielmin [ judy.guglielmin ]
              Hide
              Permalink
              Judy Guglielmin added a comment -

              rev 40068 to 3.3.0 mtce branch and 37373 for QA on repo

              Show
              Judy Guglielmin added a comment - rev 40068 to 3.3.0 mtce branch and 37373 for QA on repo
              Judy Guglielmin made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Re-opening because of the following errors found in showcase (Firefox only; using Jenkins EE 3 trunk Build # 425):

              1) buttonGroup > Overview:
              Clicking inside the form with the buttonGroup and tabbing through triggers browser console errors when checkboxes gain focus:

              TypeError: e is undefined
              http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=mhw7pq
              Line 38498

              2) checkBoxButton> Custom Style: similar error when clicking in first checkbox and then tabbing through.

              Show
              Carmen Cristurean added a comment - Re-opening because of the following errors found in showcase (Firefox only; using Jenkins EE 3 trunk Build # 425): 1) buttonGroup > Overview: Clicking inside the form with the buttonGroup and tabbing through triggers browser console errors when checkboxes gain focus: TypeError: e is undefined http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=mhw7pq Line 38498 2) checkBoxButton> Custom Style: similar error when clicking in first checkbox and then tabbing through.
              Carmen Cristurean made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              The browser console error is still reproducible in Firefox with EE-3.3.0-maintenance rev.41200:
              TypeError: c is undefined
              http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb
              Line 466

              Show
              Carmen Cristurean added a comment - The browser console error is still reproducible in Firefox with EE-3.3.0-maintenance rev.41200: TypeError: c is undefined http://localhost:8080/showcase/javax.faces.resource/coalesced.js.jsf?ln=ice.core&dgst=zg6ihb Line 466
              Ken Fyten made changes -
              Assignee Judy Guglielmin [ judy.guglielmin ] Mircea Toma [ mircea.toma ]
              Fix Version/s 4.0 [ 11382 ]
              Fix Version/s 4.0.BETA [ 10770 ]
              Affects Version/s EE-3.3.0.GA_P02 [ 11371 ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Make sure to pass in the event object to the ice.ace.checkboxbutton.onAriaKeypress method when wring the keypress event callback.

              The trunk was fixed by ICE-9728.

              Show
              Mircea Toma added a comment - Make sure to pass in the event object to the ice.ace.checkboxbutton.onAriaKeypress method when wring the keypress event callback. The trunk was fixed by ICE-9728.
              Mircea Toma made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Hide
              Permalink
              Carmen Cristurean added a comment -

              Testing with EE-3.3.0-maintenance branch rev. 41221/FF29, Chrome35, IE10, no JS errors have been found.

              Show
              Carmen Cristurean added a comment - Testing with EE-3.3.0-maintenance branch rev. 41221/FF29, Chrome35, IE10, no JS errors have been found.
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  5 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: