ICEfaces
  1. ICEfaces
  2. ICE-9323

ice:panelPopup - Can't select input elements after close of modal popup

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.GA_P01, EE-3.2.0.GA, 3.3, 4.0.BETA
    • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All
    • Assignee Priority:
      P1
    • Salesforce Case Reference:

      Description

      When closing a modal ice:panelPopup that is set in its own form tag, the input elements of a different form can't be interacted with. The tabindex of these input elements remains at -1. If the popup is moved to the same form then this issue isn't seen.


        Activity

        Hide
        Mark Collette added a comment -

        If we put the Ice.modal.start call inside of a setTimeout, that will make it be called after onAfterUpdate, then possibly that would fix things.

        Although, we'd need to think of the timing for calling Ice.modal.stop in relation to the dialog close lifecycle, which itself will do another round of blockUIOnSubmit. In that case, blockUIOnSubmit will then save away the fake handlers setup by Ice.modal.start, and restore them in onAfterUpdate, so our call to Ice.modal.stop needs to happen after that as well. Meaning we need to both render out Ice.modal.stop in a setTimeout, and render our ice.OnElementUpdate to call a setTimeout that then calls Ice.modal.stop.

        Show
        Mark Collette added a comment - If we put the Ice.modal.start call inside of a setTimeout, that will make it be called after onAfterUpdate, then possibly that would fix things. Although, we'd need to think of the timing for calling Ice.modal.stop in relation to the dialog close lifecycle, which itself will do another round of blockUIOnSubmit. In that case, blockUIOnSubmit will then save away the fake handlers setup by Ice.modal.start, and restore them in onAfterUpdate, so our call to Ice.modal.stop needs to happen after that as well. Meaning we need to both render out Ice.modal.stop in a setTimeout, and render our ice.OnElementUpdate to call a setTimeout that then calls Ice.modal.stop.
        Hide
        Mircea Toma added a comment -

        Enable input element callbacks on before update instead of after update. This way the interference with ice:panelPopup who also is disabling and enabling the callbacks is avoided. Mark has already described correctly what is going on.

        Show
        Mircea Toma added a comment - Enable input element callbacks on before update instead of after update. This way the interference with ice:panelPopup who also is disabling and enabling the callbacks is avoided. Mark has already described correctly what is going on.
        Hide
        Carmen Cristurean added a comment -

        Verified using ICEfaces-EE build 14 in Firefox21: no issues found using 'Case12185Example' test case.
        When using 'ICE9323' test case, user must click twice to open popup, but no other issues have been found.

        Show
        Carmen Cristurean added a comment - Verified using ICEfaces-EE build 14 in Firefox21: no issues found using 'Case12185Example' test case. When using 'ICE9323' test case, user must click twice to open popup, but no other issues have been found.
        Hide
        Ken Fyten added a comment -

        Re-opened. 2nd test case is failing now. Mircea, please verify with both tests.

        Show
        Ken Fyten added a comment - Re-opened. 2nd test case is failing now. Mircea, please verify with both tests.
        Hide
        Ken Fyten added a comment -

        Resolved. Both tests are passing now, ICE-9323 test was missing the icepush-ee.jar in the war.

        Show
        Ken Fyten added a comment - Resolved. Both tests are passing now, ICE-9323 test was missing the icepush-ee.jar in the war.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: