ICEfaces
  1. ICEfaces
  2. ICE-931

JS error occurs when using an <f:param name="id"...

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.5
    • Fix Version/s: 1.5.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Operating System: Windows XP
      Platform: PC

      Description

      Seems innocuous, but it's already come up a couple of times in the forum and in
      our own projects. If you have a <f:param name="id" value=".."/> on your
      page, the js blows up when looking for other .id properties. Perhaps we could
      watch for this on parsing pages (or in the <ice:menu> or <ice:commandLink>
      component handlers) and log an ERROR or WARNING.

        Activity

        Hide
        Ted Goddard added a comment -

        Is the problem that the "name" is specifically "id"?

        Show
        Ted Goddard added a comment - Is the problem that the "name" is specifically "id"?
        Hide
        Philip Breau added a comment -

        yes, but let's please not talk about semantics

        Show
        Philip Breau added a comment - yes, but let's please not talk about semantics
        Hide
        Ted Goddard added a comment -

        Is this a general problem for all components?

        Show
        Ted Goddard added a comment - Is this a general problem for all components?
        Hide
        Philip Breau added a comment -

        AFAIK, any components that can use an <f:param>, which includes only the
        <ice:commandLink> I believe, and the <ice:menu> (coming) as I mentioned. Is that
        right Greg?

        Show
        Philip Breau added a comment - AFAIK, any components that can use an <f:param>, which includes only the <ice:commandLink> I believe, and the <ice:menu> (coming) as I mentioned. Is that right Greg?
        Hide
        Greg McCleary added a comment -

        I believe this issue was fixed in rev.#10728 of submit.js
        (Make 'iceSubmit' function more robust)

        Having a param named "id" will nolonger break the ice submit functions.

        It still may be worthwhile to log a warning at parse time.

        Show
        Greg McCleary added a comment - I believe this issue was fixed in rev.#10728 of submit.js (Make 'iceSubmit' function more robust) Having a param named "id" will nolonger break the ice submit functions. It still may be worthwhile to log a warning at parse time.
        Hide
        Ted Goddard added a comment -

        The fix delivered earlier is now in the head; please verify that the customer's application is fixed with
        today's build.

        Show
        Ted Goddard added a comment - The fix delivered earlier is now in the head; please verify that the customer's application is fixed with today's build.
        Hide
        Ken Fyten added a comment -

        Philip,

        Was this issue fixed in v1.5. Please mark the case Resolved Fixed if so.

        Show
        Ken Fyten added a comment - Philip, Was this issue fixed in v1.5. Please mark the case Resolved Fixed if so.
        Hide
        Philip Breau added a comment -

        fixed, verified with 1.5.3

        Show
        Philip Breau added a comment - fixed, verified with 1.5.3

          People

          • Assignee:
            Philip Breau
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: