ICEfaces
  1. ICEfaces
  2. ICE-9293

Showcase - Application specific ACE "Rime"-theme styling issues

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ACE-Components, Sample Apps
          • Labels:
            None
          • Environment:
            ICEfaces 3.x, ICEfaces Showcase sample application, "Rime" ACE theme.
          • Assignee Priority:
            P1

            Description

            When using the ACE "Rime" theme in the ICEfaces Showcase there are a couple of application (and "Rime" theme) specific styling issues:

            1) The "Documentation" ace:menuButton text is extremely small.
            2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.

            These issues are only present when the ACE "Rime" theme is selected via the themeSelector. All other themes are fine.

              Activity

              Ascending order - Click to sort in descending order
              Ken Fyten created issue -
              Hide
              Permalink
              Ken Fyten added a comment -

              See the screen shot for an illustration of this issue (captured on Mac Safari).

              Show
              Ken Fyten added a comment - See the screen shot for an illustration of this issue (captured on Mac Safari).
              Ken Fyten made changes -
              Field Original Value New Value
              Attachment Screen Shot 2013-05-27 at 11.13.00 AM.png [ 15980 ]
              Ken Fyten made changes -
              Assignee Arturo Zambrano [ artzambrano ]
              Ken Fyten made changes -
              Assignee Priority P2 [ 10011 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35634 Tue May 28 09:56:06 MDT 2013 art.zambrano ICE-9293 added custom extensions to the rime theme for the showcase application
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/rime/theme.css
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Committed fix at revision 35634. Added custom extensions to the rime theme for the showcase application. Since, we don't add a class name of the theme name anywhere on the page, it's not possible to know from the CSS code what theme is being used at the moment, so this couldn't be fixed in the showcase app's custom CSS, so I had to add some CSS rules in the rime theme itself that modify a few stylings for a couple of style classes used in the showcase app.

              Show
              Arturo Zambrano added a comment - Committed fix at revision 35634. Added custom extensions to the rime theme for the showcase application. Since, we don't add a class name of the theme name anywhere on the page, it's not possible to know from the CSS code what theme is being used at the moment, so this couldn't be fixed in the showcase app's custom CSS, so I had to add some CSS rules in the rime theme itself that modify a few stylings for a couple of style classes used in the showcase app.
              Arturo Zambrano made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35653 Thu May 30 10:04:29 MDT 2013 art.zambrano ICE-9293 fix to dynamically load custom rime theme extensions only when the theme is in use
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
              Commit graph ADD /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/util/RimeThemeBean.java
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35654 Thu May 30 10:06:11 MDT 2013 art.zambrano ICE-9293 removed showcase extensions from rime theme
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/themes/rime/theme.css
              Hide
              Permalink
              Arturo Zambrano added a comment -

              At revision 35654... removed custom showcase extensions to the rime theme; added technique to dynamically load rime theme extensions on the page only when such theme is in use.

              Show
              Arturo Zambrano added a comment - At revision 35654... removed custom showcase extensions to the rime theme; added technique to dynamically load rime theme extensions on the page only when such theme is in use.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35655 Thu May 30 10:19:20 MDT 2013 art.zambrano ICE-9293 moved rime theme extensions inline; removed rime theme bean
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/main-template.xhtml
              Commit graph DEL /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/java/org/icefaces/samples/showcase/util/RimeThemeBean.java
              Hide
              Permalink
              Ken Fyten added a comment -

              Note that issue #2 is still present:

              2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.

              Show
              Ken Fyten added a comment - Note that issue #2 is still present: 2) The Source Code view ace:panel expansion icons (+/-) are not vertically aligned.
              Ken Fyten made changes -
              Resolution Fixed [ 1 ]
              Status Resolved [ 5 ] Reopened [ 4 ]
              Assignee Priority P2 [ 10011 ] P1 [ 10010 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #35879 Tue Jun 04 13:48:46 MDT 2013 art.zambrano ICE-9293 fix to make buttons in the source panel header appear aligned in the middle, when using the rime theme
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/samples/showcase/showcase/src/main/webapp/resources/templates/content-template.xhtml
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Nils committed fix for documentation menu issues at revision 35664: Switched to in-flow layout. Aligns correctly with any font size (though 10pt font is currently set). Doesn't require rime specific style.

              Committed fix for source code panel header buttons at revision 35879. Added a minimum height, which fixed the problem in rime and doesn't affect the other themes.

              Show
              Arturo Zambrano added a comment - Nils committed fix for documentation menu issues at revision 35664: Switched to in-flow layout. Aligns correctly with any font size (though 10pt font is currently set). Doesn't require rime specific style. Committed fix for source code panel header buttons at revision 35879. Added a minimum height, which fixed the problem in rime and doesn't affect the other themes.
              Arturo Zambrano made changes -
              Status Reopened [ 4 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s 4.0 [ 11382 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Ken Fyten
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: