ICEfaces
  1. ICEfaces
  2. ICE-9273

ace:fileEntry - Add support for Servlet 3 multi-part uploads

    Details

    • Assignee Priority:
      P2
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Compatibility/Configuration

      Description

      file-callback (all browsers): new failure in automation (passed in previous regressions on Tomcat6/Mojarra 2.1)
      Fails manually to return MD5 checksum on file upload; passes with Mojarra 2.1.

      Steps:
      - build file-callback tutorial using Mojarra 2.2, and deploy to tomcat7.
      - click on 'Browse' button to upload file:
      C:\svn\repo\qa\trunk\Regression-Icefaces2\Sparkle\Nightly\fileEntry\web\files\1
      - click on 'Get MD5 Checksum' -> no message is rendered on the page.

        Activity

        Hide
        Mark Collette added a comment -

        Committed everything, which allows for proper uploading in all the scenarios. The only issue being that there is no progress in Servlet 3 + Mojarra 2.2.x, but that has been spun off into ICE-9516.

        icefaces3 trunk
        Subversion 37399

        Show
        Mark Collette added a comment - Committed everything, which allows for proper uploading in all the scenarios. The only issue being that there is no progress in Servlet 3 + Mojarra 2.2.x, but that has been spun off into ICE-9516. icefaces3 trunk Subversion 37399
        Hide
        Mark Collette added a comment -

        Fixed minor regression where the size for failed file upload should be zero.

        icefaces3 trunk
        Subversion 37714

        Show
        Mark Collette added a comment - Fixed minor regression where the size for failed file upload should be zero. icefaces3 trunk Subversion 37714
        Hide
        Arturo Zambrano added a comment -

        Reopening issue.

        After investigating ICE-9589, it was found that code committed for solving this issue (ICE-9273) contains a call to HttpServletRequest.getParts() and use of javax.servlet.http.Part objects, which are only available in the Servlet 3.0 API, and not in previous Servlet versions. Thus, ace:fileEntry is not working on Tomcat 6, for example, and any other server that uses a Servlet API earlier than 3.0. Refactoring this code will be necessary to make ace:fileEntry work with earlier Servler API's.

        Show
        Arturo Zambrano added a comment - Reopening issue. After investigating ICE-9589, it was found that code committed for solving this issue ( ICE-9273 ) contains a call to HttpServletRequest.getParts() and use of javax.servlet.http.Part objects, which are only available in the Servlet 3.0 API, and not in previous Servlet versions. Thus, ace:fileEntry is not working on Tomcat 6, for example, and any other server that uses a Servlet API earlier than 3.0. Refactoring this code will be necessary to make ace:fileEntry work with earlier Servler API's.
        Hide
        Arturo Zambrano added a comment -

        Committed fix at revision 38314. Replaced use of javax.servlet.http.Part with use of Apache Commons FileUpload classes in order to restore compatibility with Servlet 2.5 API.

        Show
        Arturo Zambrano added a comment - Committed fix at revision 38314. Replaced use of javax.servlet.http.Part with use of Apache Commons FileUpload classes in order to restore compatibility with Servlet 2.5 API.
        Hide
        Liana Munroe added a comment - - edited

        The test case in this JIRA is confirmed fixed Tomcat 6, 7, IE 7, 8, 9, 10, FF 3.6, 21, Chrome 29. Revision # 38328.
        Regression tests for fileEntry were run in Tomcat 6 and 7 with FF 21, IE 9 and Chrome 29. All passed manually.

        Show
        Liana Munroe added a comment - - edited The test case in this JIRA is confirmed fixed Tomcat 6, 7, IE 7, 8, 9, 10, FF 3.6, 21, Chrome 29. Revision # 38328. Regression tests for fileEntry were run in Tomcat 6 and 7 with FF 21, IE 9 and Chrome 29. All passed manually.

          People

          • Assignee:
            Ken Fyten
            Reporter:
            Carmen Cristurean
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: