ICEfaces
  1. ICEfaces
  2. ICE-9248

REGRESSION: ace:confirmationDialog > Selected value not updated on page when component is rendered dynamically

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.3
    • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces3 trunk revision# 34818
      Passed at revision# 34719
      Browsers: IE7/8 only (Can't reproduce in IE9/10, Chrome26, Firefox20)
    • Assignee Priority:
      P1

      Description

      To reproduce:
      1) Build / deploy test app located at: http://server.ice:8888/svn/repo/qa/trunk/Regression-Icefaces2/Sparkle/Nightly/confirmationDialog
      2) Load 'ConfirmDialog Dynamic Attribute Test' test page in IE7 or IE8
      3) Click the rendered checkbox
      4) Click Show button to display the confirmationDialog
      5) Click one of the Yes or No buttons
      6) Notice the text on the page doesn't update for the selection
      Expected value: You chose: yes/no
      Actual value: You chose:

        Activity

        Hide
        yip.ng added a comment - - edited

        Seems the framework serializes and submits very different parameters in IE8. Not only are a bunch of parameters missing, most of the rest also have different values. See screenshot. Cross-browser form serialization issues again?

        Show
        yip.ng added a comment - - edited Seems the framework serializes and submits very different parameters in IE8. Not only are a bunch of parameters missing, most of the rest also have different values. See screenshot . Cross-browser form serialization issues again?
        Hide
        Mircea Toma added a comment -

        It seems that in IE the ace:confirmationDialog component blocks the 'click' event from bubbling to the enclosing form. Because of that our submit capturing reacts only to the 'submit' event which is also triggered when one of the buttons (of type=submit) is clicked.

        Show
        Mircea Toma added a comment - It seems that in IE the ace:confirmationDialog component blocks the 'click' event from bubbling to the enclosing form. Because of that our submit capturing reacts only to the 'submit' event which is also triggered when one of the buttons (of type=submit) is clicked.
        Hide
        Mircea Toma added a comment -

        Most probably this is a regression caused by the update of the jQuery library since no changes were made in the submit capturing area in a long time.

        Show
        Mircea Toma added a comment - Most probably this is a regression caused by the update of the jQuery library since no changes were made in the submit capturing area in a long time.
        Hide
        Mircea Toma added a comment -

        Fixed the test at application level, by moving the enclosing form inside confirmationDialog component so that the click events can propagate to the form.

        Show
        Mircea Toma added a comment - Fixed the test at application level, by moving the enclosing form inside confirmationDialog component so that the click events can propagate to the form.
        Hide
        Mircea Toma added a comment -

        The previous fix is really more of a work around. To properly fix the ace:confirmationDialog and allow full flexibility in the markup the jQuery code used for creating and controlling the confirmation dialog will need to be inspected and possibly modified so that the 'click' events are not blocked anymore from propagating to the enclosing form.

        Show
        Mircea Toma added a comment - The previous fix is really more of a work around. To properly fix the ace:confirmationDialog and allow full flexibility in the markup the jQuery code used for creating and controlling the confirmation dialog will need to be inspected and possibly modified so that the 'click' events are not blocked anymore from propagating to the enclosing form.
        Hide
        Arturo Zambrano added a comment -

        Committed fix at revision 35633. Now, the calls to the 'open' and 'close' methods of the jQuery-UI Dialog API are done via a timeout function with a minimal delay, to avoid the problem with event bubbling.

        Also, the workaround in the test app mentioned above was reverted in order to test this fix.

        Show
        Arturo Zambrano added a comment - Committed fix at revision 35633. Now, the calls to the 'open' and 'close' methods of the jQuery-UI Dialog API are done via a timeout function with a minimal delay, to avoid the problem with event bubbling. Also, the workaround in the test app mentioned above was reverted in order to test this fix.

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Cruz Miraback
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: