ICEfaces
  1. ICEfaces
  2. ICE-9187

showcase - ice:outputProgress Style demo - color styling not working

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.2
    • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
    • Component/s: ICE-Components, Sample Apps
    • Labels:
      None
    • Environment:
      ICEfaces-3.3.0 Build11
      Server: Tomcat7
      Browsers: IE10/ Firefox20/ Chrome26
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.), Sample App./Tutorial, Compatibility/Configuration

      Description

      showcase -> ICE Components:
      ice:outputProgress > Style: Changing the style class only changes the font (all browsers).

        Issue Links

          Activity

          Hide
          yip.ng added a comment -

          Nothing to do with component or CSS. Caused by framework's changed loading of style sheets. The showcase override style sheets (demo_template.css, override_styles.css, showcase_styles.css) used to be loaded after rime.css. But now:

          • With coalescing, they get coalesced and coalesced.css loads before rime.css.
          • Even without coalescing, the individual override style sheets still get loaded before rime.css. And one of them (override_styles.css) is loaded out of order as specified in app.

          Note: the order of style classes in the class attribute has no semantic meaning. See my comment in ICE-7868. (All the care we took to render user style classes last was for nothing.)

          Show
          yip.ng added a comment - Nothing to do with component or CSS. Caused by framework's changed loading of style sheets. The showcase override style sheets (demo_template.css, override_styles.css, showcase_styles.css) used to be loaded after rime.css. But now: With coalescing, they get coalesced and coalesced.css loads before rime.css. Even without coalescing, the individual override style sheets still get loaded before rime.css. And one of them (override_styles.css) is loaded out of order as specified in app. Note : the order of style classes in the class attribute has no semantic meaning. See my comment in ICE-7868 . (All the care we took to render user style classes last was for nothing.)
          Hide
          Ken Fyten added a comment - - edited

          Most likely the resource-dependency.xml file for the Showcase application needs to be modified to ensure the showcase css is loaded in the correct sequence. The file is located under src/main/resources/META-INF/resource-dependency.xml.

          More info on resource dependencies: http://www.icesoft.org/wiki/display/ICE/Resource+dependencies

          Show
          Ken Fyten added a comment - - edited Most likely the resource-dependency.xml file for the Showcase application needs to be modified to ensure the showcase css is loaded in the correct sequence. The file is located under src/main/resources/META-INF/resource-dependency.xml. More info on resource dependencies: http://www.icesoft.org/wiki/display/ICE/Resource+dependencies
          Hide
          yip.ng added a comment - - edited

          Doesn't work. rime.css is rendered like this:

          <ice:outputStyle href="./xmlhttp/css/rime/rime.css"/>
          

          How can you translate it into JSF2 resource syntax used in resource-dependency.xml?

          <resource name="?" library="?"/>
          

          Tried various combinations. None of them seemed to work.

          Show
          yip.ng added a comment - - edited Doesn't work. rime.css is rendered like this: <ice:outputStyle href= "./xmlhttp/css/rime/rime.css" /> How can you translate it into JSF2 resource syntax used in resource-dependency.xml? <resource name= "?" library= "?" /> Tried various combinations. None of them seemed to work.
          Hide
          Ken Fyten added a comment -

          Assign to Mircea to consult on how the compat rime.css can be incorporated into the resource ordering file.

          Show
          Ken Fyten added a comment - Assign to Mircea to consult on how the compat rime.css can be incorporated into the resource ordering file.
          Hide
          Mircea Toma added a comment -

          Moved rime, royale and xp css files under META-INF/resources directory where they can be resolved by the JSF resource serving mechanism. Modified image relative paths in the CSS files so they work properly, including when the CSS coalesced. Modified resource-dependency.xml to reflect the new location of the CSS files.

          Show
          Mircea Toma added a comment - Moved rime, royale and xp css files under META-INF/resources directory where they can be resolved by the JSF resource serving mechanism. Modified image relative paths in the CSS files so they work properly, including when the CSS coalesced. Modified resource-dependency.xml to reflect the new location of the CSS files.
          Hide
          Mircea Toma added a comment -

          Make sure the old CSS theme files are still around so that they can be referenced by the application that we don't want to modify anymore.

          Show
          Mircea Toma added a comment - Make sure the old CSS theme files are still around so that they can be referenced by the application that we don't want to modify anymore.
          Hide
          Ken Fyten added a comment -

          We will need to add a README.TXT to the dirs where the compat themes are duplicate to indicate where the copies are located that must also be updated.

          In addition, we will want to document the need to include the compat theme files via JSF2 mechanisms if coalescing or ordering is desired in the Compat theme wiki.

          Show
          Ken Fyten added a comment - We will need to add a README.TXT to the dirs where the compat themes are duplicate to indicate where the copies are located that must also be updated. In addition, we will want to document the need to include the compat theme files via JSF2 mechanisms if coalescing or ordering is desired in the Compat theme wiki.
          Hide
          Ken Fyten added a comment -

          A regression has been found in the showcase application that is caused by the changes made in the following commit for this JIRA:

          svn rvn#34637 : ICE-9187 Make sure the old CSS theme files are still around so that they can be referenced by the application that we don't want to modify anymore.

          The issue is that none of the ACE entry component "Required Styling" demos function correctly. To reproduce:

          1. Load showcase
          2. Navigate to the ace:textEntry demo
          3. Navigate to the "Required Styling" demo
          4. Note that the required fields are set to the default colour, and not the color specified by the ace:simpleSelectOneMenu at the top. This worked correctly with svn rvn#34636.

          Several other showcase demos have basically the same "Required Styling" demo as well, and are also affected (ace:textAreaEntry, ace:maskedEntry, etc.).

          Show
          Ken Fyten added a comment - A regression has been found in the showcase application that is caused by the changes made in the following commit for this JIRA: svn rvn#34637 : ICE-9187 Make sure the old CSS theme files are still around so that they can be referenced by the application that we don't want to modify anymore. The issue is that none of the ACE entry component "Required Styling" demos function correctly. To reproduce: Load showcase Navigate to the ace:textEntry demo Navigate to the "Required Styling" demo Note that the required fields are set to the default colour, and not the color specified by the ace:simpleSelectOneMenu at the top. This worked correctly with svn rvn#34636. Several other showcase demos have basically the same "Required Styling" demo as well, and are also affected (ace:textAreaEntry, ace:maskedEntry, etc.).
          Hide
          Mircea Toma added a comment -

          Modified the order in which the 'showcase' application resources are loaded. The order matches what we had before the refactoring done for the resource coalescing to work.

          Show
          Mircea Toma added a comment - Modified the order in which the 'showcase' application resources are loaded. The order matches what we had before the refactoring done for the resource coalescing to work.

            People

            • Assignee:
              Mircea Toma
              Reporter:
              Carmen Cristurean
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: