ICEfaces
  1. ICEfaces
  2. ICE-9096

ice:dataTable - Don't render tabindex for row when not using an ice:rowSelector

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.GA, EE-1.8.2.GA_P06
    • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All

      Description

      Due to the changes made in ICE-6686, the <tr> tags for the ice:dataTable are rendered with a tabindex=0. This is great for tabbing when using the keybouard for row selection but not so great when trying to tab through inputs in the table.

      When tabbing through focus is set on the row before it is set for the input fields. According to the forum post this is also an issue when using the keyboard and setting keyboardNavigationEnabled="false" on the rowSelector component.

        Issue Links

          Activity

          Arran Mccullough created issue -
          Hide
          Arran Mccullough added a comment -

          Attached test case that shows the behavior.

          Steps:

          • Click in an input field and then tab out, focus is set to the row.
          • Tab again and it will be set to the next input field.
          Show
          Arran Mccullough added a comment - Attached test case that shows the behavior. Steps: Click in an input field and then tab out, focus is set to the row. Tab again and it will be set to the next input field.
          Arran Mccullough made changes -
          Field Original Value New Value
          Attachment Post21826Example.zip [ 15686 ]
          Attachment Post21826ExampleWAR.zip [ 15687 ]
          Ken Fyten made changes -
          Assignee yip.ng [ yip.ng ]
          Fix Version/s 3.4 [ 10770 ]
          Fix Version/s EE-1.8.2.GA_P07 [ 10672 ]
          Assignee Priority P3 [ 10012 ]
          yip.ng made changes -
          Attachment screenshot-01.png [ 15700 ]
          yip.ng made changes -
          Attachment screenshot-01.png [ 15700 ]
          yip.ng made changes -
          Attachment screenshot-01.png [ 15701 ]
          Attachment screenshot-02.png [ 15702 ]
          Hide
          yip.ng added a comment -

          Read ICE-6686 more CAREFULLY. This has nothing to do with ICE-6686 or row selector. It is due to changes in ICE-7678: screenshot-01.png, screenshot-02.png.

          Impossible to revert without wrecking ICE-7678.

          Show
          yip.ng added a comment - Read ICE-6686 more CAREFULLY. This has nothing to do with ICE-6686 or row selector. It is due to changes in ICE-7678 : screenshot-01.png , screenshot-02.png . Impossible to revert without wrecking ICE-7678 .
          Ken Fyten made changes -
          Priority Major [ 3 ] Minor [ 4 ]
          Arran Mccullough made changes -
          Salesforce Case Reference 5007000000QWb2iAAD
          Hide
          Ken Fyten added a comment -

          Linking to ICE-9119 as the same solution should apply to both ice:dataTable and ace:dataTable, ideally.

          Show
          Ken Fyten added a comment - Linking to ICE-9119 as the same solution should apply to both ice:dataTable and ace:dataTable, ideally.
          Ken Fyten made changes -
          Link This issue depends on ICE-9119 [ ICE-9119 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #34666 Thu May 02 09:45:08 MDT 2013 yip.ng ICE-9096: ice:dataTable - Don't render tabindex for row when not using an ice:rowSelector.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/components/src/main/java/com/icesoft/faces/component/ext/HtmlDataTable.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableMeta.java
          Commit graph MODIFY /icefaces3/trunk/icefaces/compat/component-metadata/src/main/resources/conf/ice_properties/ice-dataTable-props.xml
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRowRenderer.java
          Hide
          yip.ng added a comment - - edited

          Done for 3.3 (ice: and ace:). Added attribute (renderRowTabindex) to turn off tabindex if wanted.

          M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableMeta.java#34666
          M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableRowRenderer.java#34666
          M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\HtmlDataTable.java#34666
          M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34666
          M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34666

          Show
          yip.ng added a comment - - edited Done for 3.3 (ice: and ace:). Added attribute (renderRowTabindex) to turn off tabindex if wanted. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableMeta.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableRowRenderer.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\HtmlDataTable.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34666
          Hide
          yip.ng added a comment -

          Same for 1.8.

          M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java#34683
          M: C:\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34683
          M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34683

          Show
          yip.ng added a comment - Same for 1.8. M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java#34683 M: C:\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34683 M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34683
          yip.ng made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #34683 Thu May 02 14:40:49 MDT 2013 yip.ng ICE-9096: ice:dataTable - Don't render tabindex for row when not using an ice:rowSelector.
          Files Changed
          Commit graph MODIFY /icefaces/trunk/icefaces/component-metadata/src/main/resources/conf/ice_properties/ice-dataTable-props.xml
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/renderkit/TableRenderer.java
          Commit graph MODIFY /icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/HtmlDataTable.java
          Ken Fyten made changes -
          Fix Version/s EE-3.3.0.GA [ 10572 ]
          Fix Version/s EE-1.8.2.GA_P07 [ 10672 ]
          Ken Fyten made changes -
          Fix Version/s 4.0 [ 11382 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              yip.ng
              Reporter:
              Arran Mccullough
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: