ICEfaces
  1. ICEfaces
  2. ICE-9096

ice:dataTable - Don't render tabindex for row when not using an ice:rowSelector

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Minor Minor
          • Resolution: Fixed
          • Affects Version/s: EE-3.2.0.GA, EE-1.8.2.GA_P06
          • Fix Version/s: EE-3.3.0.GA, 4.0.BETA, 4.0
          • Component/s: ICE-Components
          • Labels:
            None
          • Environment:
            All

            Description

            Due to the changes made in ICE-6686, the <tr> tags for the ice:dataTable are rendered with a tabindex=0. This is great for tabbing when using the keybouard for row selection but not so great when trying to tab through inputs in the table.

            When tabbing through focus is set on the row before it is set for the input fields. According to the forum post this is also an issue when using the keyboard and setting keyboardNavigationEnabled="false" on the rowSelector component.

              Issue Links

              depends on

              Improvement - An improvement or enhancement to an existing feature or task. ICE-9119 Tabbing to next row leads to focus being not on the first editable element of the next row

              • Major - Major loss of function.
              • Closed

                Activity

                Ascending order - Click to sort in descending order
                Hide
                Permalink
                Arran Mccullough added a comment -

                Attached test case that shows the behavior.

                Steps:

                • Click in an input field and then tab out, focus is set to the row.
                • Tab again and it will be set to the next input field.
                Show
                Arran Mccullough added a comment - Attached test case that shows the behavior. Steps: Click in an input field and then tab out, focus is set to the row. Tab again and it will be set to the next input field.
                Hide
                Permalink
                yip.ng added a comment -

                Read ICE-6686 more CAREFULLY. This has nothing to do with ICE-6686 or row selector. It is due to changes in ICE-7678: screenshot-01.png, screenshot-02.png.

                Impossible to revert without wrecking ICE-7678.

                Show
                yip.ng added a comment - Read ICE-6686 more CAREFULLY. This has nothing to do with ICE-6686 or row selector. It is due to changes in ICE-7678 : screenshot-01.png , screenshot-02.png . Impossible to revert without wrecking ICE-7678 .
                Hide
                Permalink
                Ken Fyten added a comment -

                Linking to ICE-9119 as the same solution should apply to both ice:dataTable and ace:dataTable, ideally.

                Show
                Ken Fyten added a comment - Linking to ICE-9119 as the same solution should apply to both ice:dataTable and ace:dataTable, ideally.
                Hide
                Permalink
                yip.ng added a comment - - edited

                Done for 3.3 (ice: and ace:). Added attribute (renderRowTabindex) to turn off tabindex if wanted.

                M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableMeta.java#34666
                M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableRowRenderer.java#34666
                M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\HtmlDataTable.java#34666
                M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34666
                M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34666

                Show
                yip.ng added a comment - - edited Done for 3.3 (ice: and ace:). Added attribute (renderRowTabindex) to turn off tabindex if wanted. M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableMeta.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\ace\component\src\org\icefaces\ace\component\datatable\DataTableRowRenderer.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\HtmlDataTable.java#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34666 M: C:\svn\ossrepo\icefaces3\trunk\icefaces\compat\components\src\main\java\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34666
                Hide
                Permalink
                yip.ng added a comment -

                Same for 1.8.

                M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java#34683
                M: C:\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34683
                M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34683

                Show
                yip.ng added a comment - Same for 1.8. M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\HtmlDataTable.java#34683 M: C:\svn\ossrepo\icefaces\trunk\icefaces\component-metadata\src\main\resources\conf\ice_properties\ice-dataTable-props.xml#34683 M: C:\svn\ossrepo\icefaces\trunk\icefaces\component\src\com\icesoft\faces\component\ext\renderkit\TableRenderer.java#34683

                  People

                  • Assignee:
                    yip.ng
                    Reporter:
                    Arran Mccullough
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    1 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: