ICEfaces
  1. ICEfaces
  2. ICE-9067

cellEditor renders empty editing fields when dataTable used with ace:ajax in an ace:panel

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.GA
    • Fix Version/s: 3.3
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      n/a

      Description

      When using the dataTable inside an ace:panel, using ace:ajax, the cellEditor renders empty editing fields, except for the last row.

      Tested on trunk.

      [code]
          <h:form id="form">
                  <ace:panel>
                 <ace:dataTable id="carTable"
                                          value="#{dataTableRowEditing.cars}"
                                          var="car">
                                          
                      <ace:ajax event="editStart"/>
                     
                      <ace:column id="name" headerText="Name">
                          <ace:cellEditor>
                              <f:facet name="output">
                                  <h:outputText id="nameCell" value="#{car.name}"/>
                              </f:facet>
                              <f:facet name="input">
                                  <h:inputText id="nameInput" value="#{car.name}"/>
                              </f:facet>
                          </ace:cellEditor>
                     </ace:column>
                     <ace:column id="chassis" headerText="Chassis">
                         <ace:cellEditor>
                              <f:facet name="output">
                                  <h:outputText id="chassisCell" value="#{car.chassis}"/>
                              </f:facet>
                              <f:facet name="input">
                                  <h:inputText id="chassisInput" value="#{car.chassis}"/>
                              </f:facet>
                          </ace:cellEditor>
                     </ace:column>
                     <ace:column id="weight" headerText="Weight (lbs)">
                         <ace:cellEditor>
                              <f:facet name="output">
                                  <h:outputText id="weightCell" value="#{car.weight}"/>
                              </f:facet>
                              <f:facet name="input">
                                  <h:inputText id="weightInput" value="#{car.weight}"/>
                              </f:facet>
                          </ace:cellEditor>
                     </ace:column>
                     
                     <ace:column id="options" headerText="Options">
                         <ace:rowEditor id="editor"/>
                     </ace:column>
                  </ace:dataTable>
                  </ace:panel>
              </h:form>
      [code]

        Activity

        Hide
        Mircea Toma added a comment -

        The issue will occur also using just the ace:ajax tag.

        Show
        Mircea Toma added a comment - The issue will occur also using just the ace:ajax tag.
        Hide
        Mircea Toma added a comment -

        The <ace:ajax event="editStart"/> tag is changing the javax.faces.execute parameter causing the ace:dataTable to run its pre-render phases. So it seems the dataTable changes the render state of the inputText components for some reasons.

        Show
        Mircea Toma added a comment - The <ace:ajax event="editStart"/> tag is changing the javax.faces.execute parameter causing the ace:dataTable to run its pre-render phases. So it seems the dataTable changes the render state of the inputText components for some reasons.
        Hide
        Nils Lundquist added a comment -

        I believe this is due to the difference between iterate() and visitTree() that I noticed in: ICE-9068.

        The fix there appears to have resolved the issue here as well.

        Show
        Nils Lundquist added a comment - I believe this is due to the difference between iterate() and visitTree() that I noticed in: ICE-9068 . The fix there appears to have resolved the issue here as well.
        Hide
        Nils Lundquist added a comment -

        The combination of these components works as expected. Resolved pending a new and complete test case that presents the issue.

        Show
        Nils Lundquist added a comment - The combination of these components works as expected. Resolved pending a new and complete test case that presents the issue.
        Hide
        Sam Gabriel added a comment -

        As per my reply to the thread this issue is not fixed there is still a bug when using the datatable and using the editStart event. Please see my response to the thread.
        http://www.icesoft.org/JForum/posts/list/0/21801.page#79888

        Show
        Sam Gabriel added a comment - As per my reply to the thread this issue is not fixed there is still a bug when using the datatable and using the editStart event. Please see my response to the thread. http://www.icesoft.org/JForum/posts/list/0/21801.page#79888
        Hide
        Ken Fyten added a comment -

        Closing this again as it was fixed for 3.3 and has been released.

        If a similar issue is occurring with 3.3, a new JIRA needs to be created for that.

        Show
        Ken Fyten added a comment - Closing this again as it was fixed for 3.3 and has been released. If a similar issue is occurring with 3.3, a new JIRA needs to be created for that.
        Hide
        Arturo Zambrano added a comment -

        I tested this issue with the 3.3 release jars by simply adding <ace:ajax render="@this" event="editStart" /> to the Row/Cell Editing demo in the showcase. Indeed, this issue wasn't solved in the 3.3 release. However, it is now solved in the 3.3 EE P03 and 4.0 releases.

        Show
        Arturo Zambrano added a comment - I tested this issue with the 3.3 release jars by simply adding <ace:ajax render="@this" event="editStart" /> to the Row/Cell Editing demo in the showcase. Indeed, this issue wasn't solved in the 3.3 release. However, it is now solved in the 3.3 EE P03 and 4.0 releases.
        Hide
        Liana Munroe added a comment -

        Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r45771. Tomcat 7, FF 34, Chrome 43, IE 11, 10, 9, 8, 7

        Show
        Liana Munroe added a comment - Verified ICEfaces 4 trunk, ee-3.3.0 maintenance branch r45771. Tomcat 7, FF 34, Chrome 43, IE 11, 10, 9, 8, 7

          People

          • Assignee:
            Arturo Zambrano
            Reporter:
            Philip Breau
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: