ICEfaces
  1. ICEfaces
  2. ICE-9044

Icefaces3 ACE regressions - panel - Ajax event tests fails (expected values not met)

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 3.3
    • Fix Version/s: 3.3
    • Component/s: ACE-Components, QA
    • Labels:
      None
    • Environment:
      Icefaces3 trunk revision #33715
      Server: tomcat6
      Browser: FF3.6, IE7, GoogleChrome24
      Initially failed on trunk rev# 33715
    • Assignee Priority:
      P1

      Description

      panel - ajax - All event tests' expected value doesn't change on ajax submit

      To reproduce:
      - Build and deploy panel war file from ..\svn\repo\qa\trunk\Regression-Icefaces2\Sparkle\Nightly\panel
      - Deploy app and load on browser
      - Navigate to panel-ajax page
      - follow instructions on page to activate ajax submit on any of the available tests
      - notice that the expected values do not update on ajax submit on any of the available tests

        Activity

        Hide
        Ken Fyten added a comment -

        Nils, any change to ace:ajax or ace:panel that could account for this change in behaviour?

        Show
        Ken Fyten added a comment - Nils, any change to ace:ajax or ace:panel that could account for this change in behaviour?
        Hide
        Nils Lundquist added a comment -

        This is an expected change from the reduction of the default execution scope of ace:panel behaviors from @all to @this.

        As has been previously noted, using getter incremented values to determine if a region is executed or just rendered is a inadvisable technique prone to several sorts of false negatives and unclear results. I thought they had been removed from our tests? Apparently not all.

        They don't serve a strong purpose either, they only serve to show that an execute & render has been large enough to include the given components or not.

        More reliably, the server side should just inspect the request parameters for the execute and render scopes and test there for the desired broadness. This can the result can be rendered to the page for evaluation by selenium (or in the case where there is execute but no render, send result via JavascriptRunner).

        This doesn't test to the same degree as the existing implementation, it assumes the given scopes are executed as indicated, but that is the frameworks responsibility anyhow. What we gain is clarity of expectations and results, and assurance that we won't get false positives / negatives from coincidental getter access.

        Show
        Nils Lundquist added a comment - This is an expected change from the reduction of the default execution scope of ace:panel behaviors from @all to @this. As has been previously noted, using getter incremented values to determine if a region is executed or just rendered is a inadvisable technique prone to several sorts of false negatives and unclear results. I thought they had been removed from our tests? Apparently not all. They don't serve a strong purpose either, they only serve to show that an execute & render has been large enough to include the given components or not. More reliably, the server side should just inspect the request parameters for the execute and render scopes and test there for the desired broadness. This can the result can be rendered to the page for evaluation by selenium (or in the case where there is execute but no render, send result via JavascriptRunner). This doesn't test to the same degree as the existing implementation, it assumes the given scopes are executed as indicated, but that is the frameworks responsibility anyhow. What we gain is clarity of expectations and results, and assurance that we won't get false positives / negatives from coincidental getter access.
        Hide
        Ken Fyten added a comment -

        FYI: A JIRA to establish a more robust test technique for ace:ajax @execute tests has been created: ICE-9054.

        Show
        Ken Fyten added a comment - FYI: A JIRA to establish a more robust test technique for ace:ajax @execute tests has been created: ICE-9054.

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Jerome Ruzol
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: