ICEfaces
  1. ICEfaces
  2. ICE-8939

Remove J2EE6 usage from Showcase as much as possible

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.BETA
    • Fix Version/s: EE-3.2.0.GA
    • Component/s: Sample Apps
    • Labels:
      None
    • Environment:
      WebSphere Application Server 7, ICEfaces-EE 3, Showcase
    • Assignee Priority:
      P1
    • Affects:
      Sample App./Tutorial

      Description

      We should try to limit the J2EE6 usage as much as possible in Showcase.

        Activity

        Hide
        Jack Van Ooststroom added a comment -

        Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableFind.java
        Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableGrouping.java
        Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableRowState.java
        Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableFind.xhtml
        Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableGrouping.xhtml
        Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowState.xhtml
        Sending showcase/src/main/webapp/resources/examples/ace/tree/tree.xhtml
        Sending showcase/src/main/webapp/resources/examples/ace/tree/treeSelection.xhtml
        Transmitting file data ........
        Committed revision 33269.

        Show
        Jack Van Ooststroom added a comment - Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableFind.java Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableGrouping.java Sending showcase/src/main/java/org/icefaces/samples/showcase/example/ace/dataTable/DataTableRowState.java Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableFind.xhtml Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableGrouping.xhtml Sending showcase/src/main/webapp/resources/examples/ace/dataTable/dataTableRowState.xhtml Sending showcase/src/main/webapp/resources/examples/ace/tree/tree.xhtml Sending showcase/src/main/webapp/resources/examples/ace/tree/treeSelection.xhtml Transmitting file data ........ Committed revision 33269.
        Hide
        Jack Van Ooststroom added a comment -

        I resolved the incorrectly used method syntax in EL that have been discovered during WAS 7 testing. There is at least still one left in dataTableGrouping, but that is a known and accepted issue. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - I resolved the incorrectly used method syntax in EL that have been discovered during WAS 7 testing. There is at least still one left in dataTableGrouping, but that is a known and accepted issue. Marking this one as FIXED.
        Hide
        Ken Fyten added a comment -

        The changes Jack committed for ace:tree demos have broken these demos in general now. Need to either fix his changes (and keep the improved EL <2.2 support) or back them out and sacrifice all ace:tree demos to needing EL 2.2. (less desirable).

        Tree - Server Internal Error when clicking on tree component link (also on other app servers such as tomcat).
        Server error:
        ]] Root cause of ServletException.
        java.lang.ClassCastException: java.lang.String cannot be cast to org.icefaces.samples.showcase.example.ace.tree.LocationNodeImpl
            at org.icefaces.samples.showcase.example.ace.tree.TreeBean$1.initializeState(TreeBean.java:73)
            at org.icefaces.ace.model.tree.NodeStateMap.get(NodeStateMap.java:74)
            at org.icefaces.ace.model.tree.NodeStateMap.get(NodeStateMap.java:26)
            at javax.el.MapELResolver.getValue(MapELResolver.java:199)
            at com.sun.faces.el.DemuxCompositeELResolver._getValue(DemuxCompositeELResolver.java:176)
            at com.sun.faces.el.DemuxCompositeELResolver.getValue(DemuxCompositeELResolver.java:203)
            at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
        
        Show
        Ken Fyten added a comment - The changes Jack committed for ace:tree demos have broken these demos in general now. Need to either fix his changes (and keep the improved EL <2.2 support) or back them out and sacrifice all ace:tree demos to needing EL 2.2. (less desirable). Tree - Server Internal Error when clicking on tree component link (also on other app servers such as tomcat). Server error: ]] Root cause of ServletException. java.lang.ClassCastException: java.lang. String cannot be cast to org.icefaces.samples.showcase.example.ace.tree.LocationNodeImpl at org.icefaces.samples.showcase.example.ace.tree.TreeBean$1.initializeState(TreeBean.java:73) at org.icefaces.ace.model.tree.NodeStateMap.get(NodeStateMap.java:74) at org.icefaces.ace.model.tree.NodeStateMap.get(NodeStateMap.java:26) at javax.el.MapELResolver.getValue(MapELResolver.java:199) at com.sun.faces.el.DemuxCompositeELResolver._getValue(DemuxCompositeELResolver.java:176) at com.sun.faces.el.DemuxCompositeELResolver.getValue(DemuxCompositeELResolver.java:203) at com.sun.el.parser.AstValue.getValue(AstValue.java:138)
        Hide
        Nils Lundquist added a comment -

        The broken demos were due to the change from 'stateMap.getSelected()' to 'stateMap.selected'. StateMap.selected is not a bean property, getSelected() is a true method call. This has been fixed.

        Show
        Nils Lundquist added a comment - The broken demos were due to the change from 'stateMap.getSelected()' to 'stateMap.selected'. StateMap.selected is not a bean property, getSelected() is a true method call. This has been fixed.

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Jack Van Ooststroom
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: