ICEfaces
  1. ICEfaces
  2. ICE-8888

ace:dataTable, issue with column pinning when using filtering

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF 3.x

      Description

      Misalignment of the headers and wrong styling can be seen on the ace:dataTable tests using pinning and filtering functionality. Also, JS error occurs when filtering columns after pinning.

      The JS error occurs when after pinning a column, a letter is entered for filtering on a column; additional styling issues are seen, screen shots attached.
      1. 1.png
        102 kB
      2. 2.png
        55 kB

        Issue Links

          Activity

          Nils Lundquist created issue -
          Nils Lundquist made changes -
          Field Original Value New Value
          Assignee Nils Lundquist [ nils.lundquist ]
          Nils Lundquist made changes -
          Link This issue duplicates ICE-8802 [ ICE-8802 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #33130 Fri Jan 18 14:58:53 MST 2013 nils.lundquist ICE-8888 - ace:dataTable reduced unpinning gap and fixed pinning growth misalignment in Chrome & Safari.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #33156 Mon Jan 21 15:07:21 MST 2013 nils.lundquist ICE-8888 - ace:dataTable column pinning - fixed possible gap when unpinning in Chrome / Safari & FF.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Hide
          Nils Lundquist added a comment -

          Most alignment issues resolved in Chrome.

          Firefox is looking very good also. 1 double border bug related to unpinning persists.

          Show
          Nils Lundquist added a comment - Most alignment issues resolved in Chrome. Firefox is looking very good also. 1 double border bug related to unpinning persists.
          Ken Fyten made changes -
          Fix Version/s EE-3.2.0.GA [ 10332 ]
          Ken Fyten made changes -
          Fix Version/s EE-3.2.0.GA [ 10332 ]
          Ken Fyten made changes -
          Assignee Priority P2 [ 10011 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #33350 Wed Feb 06 14:44:07 MST 2013 nils.lundquist ICE-8888 - ace:dataTable column pinning, added fix for particular IE7 installations.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Ken Fyten made changes -
          Fix Version/s 3.4 [ 10770 ]
          Fix Version/s 3.3 [ 10370 ]
          Nils Lundquist made changes -
          Link This issue depends on ICE-9531 [ ICE-9531 ]
          Ken Fyten made changes -
          Assignee Nils Lundquist [ nils.lundquist ] Ken Fyten [ ken.fyten ]
          Ken Fyten made changes -
          Link This issue depends on ICE-8885 [ ICE-8885 ]
          Ken Fyten made changes -
          Summary ace:dataTable column pinning misalignments ace:dataTable column pinning issues
          Ken Fyten made changes -
          Link This issue depends on ICE-9718 [ ICE-9718 ]
          Ken Fyten made changes -
          Fix Version/s 4.0 [ 10770 ]
          Ken Fyten made changes -
          Assignee Ken Fyten [ ken.fyten ]
          Assignee Priority P2 [ 10011 ]
          Ken Fyten made changes -
          Link This issue depends on ICE-9528 [ ICE-9528 ]
          Ken Fyten made changes -
          Link This issue depends on ICE-9729 [ ICE-9729 ]
          Ken Fyten made changes -
          Link This issue depends on ICE-10338 [ ICE-10338 ]
          Ken Fyten made changes -
          Fix Version/s 4.1 [ 11375 ]
          Ken Fyten made changes -
          Fix Version/s 4.2 [ 12870 ]
          Fix Version/s 4.1 [ 11375 ]
          Hide
          Carmen Cristurean added a comment - - edited

          ICEfaces4 trunk r 49367
          Browsers: all

          Misalignment of the headers and wrong styling can be seen on the ace:dataTable tests using pinning and filtering functionality. Also, JS error occurs when filtering columns after pinning.
          These issues can be reproduced also with EE-4.1.0.GA or ICEfaces 4.1.1 release libraries.

          QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable
          ace:dataTable > Column Pinning Advanced / Dynamic Row Styling via RowStyleClass Attribute

          The JS error occurs when after pinning a column, a letter is entered for filtering on a column; additional styling issues are seen, screen shots attached.

          FF47:
          SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data
          http://localhost:8080/dataTable/javax.faces.resource/jquery/jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014
          Line 160

          IE11:
          SCRIPT1014: Invalid character
          File: jquery.c.js.jsf, Line: 160, Column: 49

          Chrome53:
          VM853:1 Uncaught SyntaxError: Unexpected token ' in JSON at position 1(…)d.parseJSON @ jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014:160h.parseJSON @ jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014:195ice.ace.DataTable.readPinningState @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:122ice.ace.DataTable.initializePinningState @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:97ice.ace.DataTable.resizeScrolling @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:95ice.ace.DataTable.setupScrolling @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:72ice.ace.DataTable @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:8ice.ace.create @ ace-core.js.jsf?ln=icefaces.ace&v=4_2_0_161014:4(anonymous function) @ VM852:1runScripts @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1doUpdate @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1response @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1onComplete @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1AjaxEngine.req.xmlReq.onreadystatechange @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1

          Show
          Carmen Cristurean added a comment - - edited ICEfaces4 trunk r 49367 Browsers: all Misalignment of the headers and wrong styling can be seen on the ace:dataTable tests using pinning and filtering functionality. Also, JS error occurs when filtering columns after pinning. These issues can be reproduced also with EE-4.1.0.GA or ICEfaces 4.1.1 release libraries. QA test app: http://dev.icesoft.com/svn/repo/qa/trunk/Regression-Icefaces4/Sparkle/Nightly/dataTable ace:dataTable > Column Pinning Advanced / Dynamic Row Styling via RowStyleClass Attribute The JS error occurs when after pinning a column, a letter is entered for filtering on a column; additional styling issues are seen, screen shots attached. FF47: SyntaxError: JSON.parse: expected property name or '}' at line 1 column 2 of the JSON data http://localhost:8080/dataTable/javax.faces.resource/jquery/jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014 Line 160 IE11: SCRIPT1014: Invalid character File: jquery.c.js.jsf, Line: 160, Column: 49 Chrome53: VM853:1 Uncaught SyntaxError: Unexpected token ' in JSON at position 1(…)d.parseJSON @ jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014:160h.parseJSON @ jquery.c.js.jsf?ln=icefaces.ace&v=4_2_0_161014:195ice.ace.DataTable.readPinningState @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:122ice.ace.DataTable.initializePinningState @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:97ice.ace.DataTable.resizeScrolling @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:95ice.ace.DataTable.setupScrolling @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:72ice.ace.DataTable @ ace-datatable.js.jsf?ln=icefaces.ace&v=4_2_0_161014:8ice.ace.create @ ace-core.js.jsf?ln=icefaces.ace&v=4_2_0_161014:4(anonymous function) @ VM852:1runScripts @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1doUpdate @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1response @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1onComplete @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1AjaxEngine.req.xmlReq.onreadystatechange @ jsf.js.jsf?ln=javax.faces&v=4_2_0_161014:1
          Carmen Cristurean made changes -
          Attachment 2.png [ 22349 ]
          Attachment 1.png [ 22350 ]
          Ken Fyten made changes -
          Fix Version/s EE-4.2.0.GA [ 13071 ]
          Fix Version/s 4.2 [ 12870 ]
          Ken Fyten made changes -
          Fix Version/s 4.3 [ 13096 ]
          Fix Version/s EE-4.2.0.GA [ 13071 ]
          Ken Fyten made changes -
          Assignee Arturo Zambrano [ artzambrano ]
          Hide
          Arturo Zambrano added a comment -

          There's another JIRA for the multiple row column headers (ICE-9718). However, the issue with filtering still exists when not using multiple row column headers.

          Show
          Arturo Zambrano added a comment - There's another JIRA for the multiple row column headers ( ICE-9718 ). However, the issue with filtering still exists when not using multiple row column headers.
          Arturo Zambrano made changes -
          Summary ace:dataTable column pinning issues ace:dataTable, issue with column pinning when using filtering
          Description This issue is to capture any ongoing browser specific or general misalignments of table cells while using the ace:dataTable column pinning feature. Misalignment of the headers and wrong styling can be seen on the ace:dataTable tests using pinning and filtering functionality. Also, JS error occurs when filtering columns after pinning.

          The JS error occurs when after pinning a column, a letter is entered for filtering on a column; additional styling issues are seen, screen shots attached.
          Hide
          Arturo Zambrano added a comment -

          Recasted this JIRA to focus only on the column pinning issue when using filtering.

          Show
          Arturo Zambrano added a comment - Recasted this JIRA to focus only on the column pinning issue when using filtering.
          Hide
          Arturo Zambrano added a comment -

          The commit at revision 52109 for ICE-11374 fixed the Javascript error reported in this JIRA. However, the misalignments still occur.

          Show
          Arturo Zambrano added a comment - The commit at revision 52109 for ICE-11374 fixed the Javascript error reported in this JIRA. However, the misalignments still occur.
          Hide
          Arturo Zambrano added a comment -

          r51125: fix to invoke table.resizeScrolling() on filter requests when column pinning is enabled, in order to fix misalignments

          Show
          Arturo Zambrano added a comment - r51125: fix to invoke table.resizeScrolling() on filter requests when column pinning is enabled, in order to fix misalignments
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #52125 Tue Dec 05 15:51:05 MST 2017 art.zambrano ICE-8888 fix to invoke table.resizeScrolling() on filter requests when column pinning is enabled, in order to fix misalignments
          Files Changed
          Commit graph MODIFY /icefaces4/trunk/icefaces/ace/component/src/org/icefaces/ace/component/datatable/DataTableRenderer.java
          Arturo Zambrano made changes -
          Link This issue blocks ICE-11419 [ ICE-11419 ]
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              Nils Lundquist
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: