ICEfaces
  1. ICEfaces
  2. ICE-8866

Support Mojarra library to 2.1.18

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.2.0.GA, 3.3
    • Fix Version/s: EE-3.2.0.GA, 3.3
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      Mojarra
    • Assignee Priority:
      P1
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Mojarra 2.1.17 was released so we are looking to update our repo to use this latest version since there are many things we'd like to take advantage of since 2.1.6.

        Activity

        Hide
        Deryk Sinotte added a comment -

        The initial smoke test of 2.1.17 shows a problem immediately upon deployment:

        Caused by: java.lang.NullPointerException
            at org.icefaces.util.EnvUtils.getViewParam(EnvUtils.java:750)
            at org.icefaces.util.EnvUtils.isFocusManaged(EnvUtils.java:309)
            at org.icefaces.impl.event.BridgeSetup.<init>(BridgeSetup.java:62)
            at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
            at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)
            at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)
            at java.lang.reflect.Constructor.newInstance(Constructor.java:513)
            at java.lang.Class.newInstance0(Class.java:355)
            at java.lang.Class.newInstance(Class.java:308)
            at com.sun.faces.config.processor.AbstractConfigProcessor.createInstance(AbstractConfigProcessor.java:268)
        

        Some quick troubleshooting shows that code around UIViewRoot.getViewMap has changed. It looks like during the BridgeSetup constructor we look for some information in the view map. Previously this view map likely empty but never null. The new code now returns a valid UIViewRoot but returns null when from getViewMap. This is likely a regression so I'll open up a case with Mojarra as well. In the meantime, a simple null check should get us over the bump.

        After including that change to our code:

        • smoke testing of showcase looks fine
        • the issue in ICE-8851 where QA was getting an NPE during deployment appears to be gone
        • the case we had logged against 2.1.16 appears to be fixed
        Show
        Deryk Sinotte added a comment - The initial smoke test of 2.1.17 shows a problem immediately upon deployment: Caused by: java.lang.NullPointerException    at org.icefaces.util.EnvUtils.getViewParam(EnvUtils.java:750)    at org.icefaces.util.EnvUtils.isFocusManaged(EnvUtils.java:309)    at org.icefaces.impl.event.BridgeSetup.<init>(BridgeSetup.java:62)    at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)    at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:39)    at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:27)    at java.lang.reflect.Constructor.newInstance(Constructor.java:513)    at java.lang. Class .newInstance0( Class .java:355)    at java.lang. Class .newInstance( Class .java:308)    at com.sun.faces.config.processor.AbstractConfigProcessor.createInstance(AbstractConfigProcessor.java:268) Some quick troubleshooting shows that code around UIViewRoot.getViewMap has changed. It looks like during the BridgeSetup constructor we look for some information in the view map. Previously this view map likely empty but never null. The new code now returns a valid UIViewRoot but returns null when from getViewMap. This is likely a regression so I'll open up a case with Mojarra as well. In the meantime, a simple null check should get us over the bump. After including that change to our code: smoke testing of showcase looks fine the issue in ICE-8851 where QA was getting an NPE during deployment appears to be gone the case we had logged against 2.1.16 appears to be fixed
        Hide
        Deryk Sinotte added a comment -

        Committed the change to EnvUtil so that we now check for a null view map. Also committed the Mojarra 2.1.17 library for regression testing. A case has been opened in the Mojarra system for the regression.

        http://java.net/jira/browse/JAVASERVERFACES-2673

        Show
        Deryk Sinotte added a comment - Committed the change to EnvUtil so that we now check for a null view map. Also committed the Mojarra 2.1.17 library for regression testing. A case has been opened in the Mojarra system for the regression. http://java.net/jira/browse/JAVASERVERFACES-2673
        Hide
        Deryk Sinotte added a comment -

        Mojarra 2.1.17 has now gone through our regression tests and looks good to use going forward. Resolving as fixed.

        Show
        Deryk Sinotte added a comment - Mojarra 2.1.17 has now gone through our regression tests and looks good to use going forward. Resolving as fixed.
        Hide
        Ken Fyten added a comment -

        Mojarra 2.1.18 is now supported. An issue exists with 2.1.17 that prevents its use, however.

        Show
        Ken Fyten added a comment - Mojarra 2.1.18 is now supported. An issue exists with 2.1.17 that prevents its use, however.

          People

          • Assignee:
            Deryk Sinotte
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: