ICEfaces
  1. ICEfaces
  2. ICE-8763

Performance bottleneck while cleaning up event handlers

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.2
          • Fix Version/s: EE-3.2.0.BETA, EE-3.2.0.GA, 3.3
          • Component/s: Bridge
          • Labels:
            None
          • Environment:
            IE8

            Description


            Just before the DOM updates are applied the bridge tries to cleanup the event handlers of all the elements that will be gone once update is applied. The cleanup can take a significant amount of time (> 10 seconds) when the updates have a large number of elements.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32129 Tue Nov 13 09:25:22 MST 2012 mircea.toma ICE-8763 Changed the cleanup of event handlers before the update is applied to run only over forms elements, anchors, iframes and forms since these are the types that usually have callbacks attached.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/fixjsf.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #32130 Tue Nov 13 09:28:53 MST 2012 mircea.toma ICE-8763 Modify findAndNotifyUpdatedElements function to use properties on object to define key-value pairs instead of using the Cell object defined in collections.js. This implementation change speeds up the execution since accessing properties on an object is much faster than using the single method dispatch mechanism used by the Cell object.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/javascript/application.js
              Migration created issue -
              Hide
              Permalink
              Mircea Toma added a comment - - edited

              Changed the cleanup of event handlers before the update is applied to run only over forms elements, anchors, iframes and forms since these are the types that usually have callbacks attached.

              Show
              Mircea Toma added a comment - - edited Changed the cleanup of event handlers before the update is applied to run only over forms elements, anchors, iframes and forms since these are the types that usually have callbacks attached.
              Hide
              Permalink
              Ted Goddard added a comment - - edited

              Mistakenly committed this under ICE-8673:
              svn commit . -m "use low-level string manipulation and stored ancestor list to optimize findAndNotifyUpdatedElements (ICE-8673)"
              Sending core/src/main/javascript/application.js
              Transmitting file data .
              Committed revision 32158.
              The optimization was to store the list of ancestor IDs as a string for each element expecting an onUpdate callback. This avoids iterating over the DOM inside the listener check loop. Updates for javax.faces.ViewState and *_fixviewstate are ignored.

              Show
              Ted Goddard added a comment - - edited Mistakenly committed this under ICE-8673 : svn commit . -m "use low-level string manipulation and stored ancestor list to optimize findAndNotifyUpdatedElements ( ICE-8673 )" Sending core/src/main/javascript/application.js Transmitting file data . Committed revision 32158. The optimization was to store the list of ancestor IDs as a string for each element expecting an onUpdate callback. This avoids iterating over the DOM inside the listener check loop. Updates for javax.faces.ViewState and *_fixviewstate are ignored.
              Migration made changes -
              Field Original Value New Value
              Reporter Migration [ remote ] Mircea Toma [ mircea.toma ]
              Migration made changes -
              Assignee Mircea Toma [ mircea.toma ]
              Hide
              Permalink
              Mircea Toma added a comment -

              Modified findAndNotifyUpdatedElements function to use properties on object to define key-value pairs instead of using the Cell object defined in collections.js. This implementation change speeds up the execution since accessing properties on an object is much faster than using the single method dispatch mechanism used by the Cell object.

              Show
              Mircea Toma added a comment - Modified findAndNotifyUpdatedElements function to use properties on object to define key-value pairs instead of using the Cell object defined in collections.js. This implementation change speeds up the execution since accessing properties on an object is much faster than using the single method dispatch mechanism used by the Cell object.
              Migration made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.2.0.GA [ 10332 ]
              Fix Version/s 3.3 [ 10370 ]
              Ken Fyten made changes -
              Fix Version/s EE-3.2.0.BETA [ 10573 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Mircea Toma
                  Reporter:
                  Mircea Toma
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: