Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.2.BETA1
-
Fix Version/s: 3.2
-
Component/s: None
-
Labels:None
-
Environment:ICEfaces
Description
The PushRenderer methods addCurrentSession(String) and removeCurrentSession() aren't seem to be doing what the method name seems to imply.
Basically, when addCurrentSession(String) is invoked it does not add all views associated with the current session to the group, instead it will start adding views to the group created after invocation of this method associated with the current session. On the other hand, when removeCurrentSession(String) is invoked it does not remove all views associated with the current session from the group, instead it will stop adding views to the group created after invocation of this method associated with the current session.
We should either ensure the implementation of these methods are conform the method names, or change the method names.
Basically, when addCurrentSession(String) is invoked it does not add all views associated with the current session to the group, instead it will start adding views to the group created after invocation of this method associated with the current session. On the other hand, when removeCurrentSession(String) is invoked it does not remove all views associated with the current session from the group, instead it will stop adding views to the group created after invocation of this method associated with the current session.
We should either ensure the implementation of these methods are conform the method names, or change the method names.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
The SessionViewManager's State class now has a collection that holds the current views for a particular session. Whenever the addView(...) and removeView(...) methods are invoked, this collection is updated accordingly.
In the case of addCurrentSession(...), all views associated with the current session are now added to the group in addition to start adding new views to the group.
In the case of removeCurrentSession(...), all views associated with the current session are now removed from the group in addition to stop adding new views to the group.
Finally, a convenience method to retrieve a view list for the current session has been added as well.
Marking this one as FIXED.
Show
Ken Fyten
added a comment - The SessionViewManager's State class now has a collection that holds the current views for a particular session. Whenever the addView(...) and removeView(...) methods are invoked, this collection is updated accordingly.
In the case of addCurrentSession(...), all views associated with the current session are now added to the group in addition to start adding new views to the group.
In the case of removeCurrentSession(...), all views associated with the current session are now removed from the group in addition to stop adding new views to the group.
Finally, a convenience method to retrieve a view list for the current session has been added as well.
Marking this one as FIXED.
p>Sending src/main/java/org/icefaces/impl/push/SessionViewManager.java<br/>
Transmitting file data .<br/>
Committed revision 31267.</p></div>