Details
Improvement
Major
Description
When ace:submitMonitor and ice:outputConnectionStatus register for the connection listeners, there's no means for them to de-register from the listeners, when the components clean themselves up when they're removed from the page. This causes a memory leak, and requires the listener methods to flag themselves as defunct, so they'll just return when called, instead of simply being de-registered.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Reporter | Migration [ remote ] | Mark Collette [ mark.collette ] |
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
| Assignee | Mircea Toma [ mircea.toma ] | |
| Fix Version/s | 3.2 [ 10338 ] | |
| Affects | Documentation (User Guide, Ref. Guide, etc.) [ 10003 ] | |
| Assignee Priority | P2 [ 10011 ] | |
| Component/s | Bridge [ 10011 ] | |
| Component/s | Components [ 10012 ] |
| Assignee Priority | P2 [ 10011 ] | P3 [ 10012 ] |
This is required to provide optimal memory management for components, particularly in cases where a single page interface is used over a long duration without navigating between pages.
| Fix Version/s | 3.3 [ 10370 ] | |
| Fix Version/s | 3.2 [ 10338 ] |
Another possible solution is to have variants of these methods where the callback is invoked just once, and automatically de-registered. Then the callback could simply re-add itself in itself, if it wanted to continue getting called.
Show
Mark Collette
added a comment - Another possible solution is to have variants of these methods where the callback is invoked just once, and automatically de-registered. Then the callback could simply re-add itself in itself, if it wanted to continue getting called.
| Repository | Revision | Date | User | Message |
| ICEsoft Public SVN Repository | #33375 | Mon Feb 11 09:51:39 MST 2013 | mircea.toma | |
| Files Changed | ||||
MODIFY
/projects/bridge-support/src/main/javascript/collection.js
MODIFY
/icefaces3/trunk/icefaces/core/src/main/javascript/application.js
|
Modified callback registration functions to return un-registering callback function. When this function is invoked the corresponding callback is removed from the list of registered callbacks.
For example:
//register callback var removeNetworkErrorNotifier = ice.onNetworkError(function() { console.error('we have a network error'); }); ..... ..... //de-registered callback removeNetworkErrorNotifier();
Show
Mircea Toma
added a comment - - edited Modified callback registration functions to return un-registering callback function. When this function is invoked the corresponding callback is removed from the list of registered callbacks.
For example:
//register callback
var removeNetworkErrorNotifier = ice.onNetworkError( function () {
console.error('we have a network error');
});
.....
.....
//de-registered callback
removeNetworkErrorNotifier();
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
This is required to provide optimal memory management for components, particularly in cases where a single page interface is used over a long duration without navigating between pages.