Details
Improvement
Major
Description
When ace:submitMonitor and ice:outputConnectionStatus register for the connection listeners, there's no means for them to de-register from the listeners, when the components clean themselves up when they're removed from the page. This causes a memory leak, and requires the listener methods to flag themselves as defunct, so they'll just return when called, instead of simply being de-registered.
Activity
- All
- Comments
- History
- Activity
- Remote Attachments
- Subversion
This is required to provide optimal memory management for components, particularly in cases where a single page interface is used over a long duration without navigating between pages.
Another possible solution is to have variants of these methods where the callback is invoked just once, and automatically de-registered. Then the callback could simply re-add itself in itself, if it wanted to continue getting called.
Show
Mark Collette
added a comment - Another possible solution is to have variants of these methods where the callback is invoked just once, and automatically de-registered. Then the callback could simply re-add itself in itself, if it wanted to continue getting called.
Modified callback registration functions to return un-registering callback function. When this function is invoked the corresponding callback is removed from the list of registered callbacks.
For example:
//register callback var removeNetworkErrorNotifier = ice.onNetworkError(function() { console.error('we have a network error'); }); ..... ..... //de-registered callback removeNetworkErrorNotifier();
Show
Mircea Toma
added a comment - - edited Modified callback registration functions to return un-registering callback function. When this function is invoked the corresponding callback is removed from the list of registered callbacks.
For example:
//register callback
var removeNetworkErrorNotifier = ice.onNetworkError( function () {
console.error('we have a network error');
});
.....
.....
//de-registered callback
removeNetworkErrorNotifier();
This is required to provide optimal memory management for components, particularly in cases where a single page interface is used over a long duration without navigating between pages.