ICEfaces
  1. ICEfaces
  2. ICE-8549

Thread-safe member access in MainServlet

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-1.8.2.GA_P03
    • Fix Version/s: EE-1.8.2.GA_P05
    • Component/s: Framework
    • Labels:
      None
    • Environment:
      ICEfaces
    • Assignee Priority:
      P2
    • Affects:
      Compatibility/Configuration

      Description


      The following lines in MainServlet are not thread-safe:

      MainServlet.java:185 localAddress
      MainServlet.java:186 localPort
      MainServlet.java:298 coreMessageService
      MainServlet.java:311 coreMessageService
      MainServlet.java:329 coreMessageService

      Thread-safe getter/setter functions for these fields should be added.

        Activity

        Hide
        Jack Van Ooststroom added a comment - - edited

        Sending src/com/icesoft/faces/webapp/http/servlet/MainServlet.java
        Transmitting file data .
        Committed revision 31367.

        Show
        Jack Van Ooststroom added a comment - - edited Sending src/com/icesoft/faces/webapp/http/servlet/MainServlet.java Transmitting file data . Committed revision 31367.
        Hide
        Jack Van Ooststroom added a comment - - edited

        Added a private synchronized method for setting the localAddress and localPort, and added the synchronized keyword to the setUpCoreMessageService() method. Marking this one as FIXED.

        Show
        Jack Van Ooststroom added a comment - - edited Added a private synchronized method for setting the localAddress and localPort, and added the synchronized keyword to the setUpCoreMessageService() method. Marking this one as FIXED.

          People

          • Assignee:
            Jack Van Ooststroom
            Reporter:
            Ted Goddard
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: