ICEfaces
  1. ICEfaces
  2. ICE-8372

blockUIOnSubmit doesn't consistently unblock the UI

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0.RC1
    • Fix Version/s: 3.1
    • Component/s: Bridge
    • Labels:
      None
    • Environment:
      IF 3.x Showcase
    • Assignee Priority:
      P1

      Description

      BlockUIOnSubmit=true doesn't consistently unblock following submit return when used in the showcase app.

        Activity

        Hide
        Ted Goddard added a comment -

        It looks like an ajax update is occurring for the element that is the source of the event. In the past we have resolved this with the following strategy:

        +++ src/main/javascript/application.js (working copy)
        @@ -108,6 +108,15 @@
        }

        function formOf(element) {
        + try

        { + return formOfNode(element); + }

        catch (e)

        { + //page update may have occurred + return formOfNode(document.getElementById(element.id)); + }

        + }
        +
        + function formOfNode(element)

        { return toLowerCase(element.nodeName) == 'form' ? element : enclosingForm(element); }

        This fixes the test case. In the past, DOM operations in the middle of ajax updates have been found to be highly browser-dependent.

        Show
        Ted Goddard added a comment - It looks like an ajax update is occurring for the element that is the source of the event. In the past we have resolved this with the following strategy: +++ src/main/javascript/application.js (working copy) @@ -108,6 +108,15 @@ } function formOf(element) { + try { + return formOfNode(element); + } catch (e) { + //page update may have occurred + return formOfNode(document.getElementById(element.id)); + } + } + + function formOfNode(element) { return toLowerCase(element.nodeName) == 'form' ? element : enclosingForm(element); } This fixes the test case. In the past, DOM operations in the middle of ajax updates have been found to be highly browser-dependent.
        Hide
        Ted Goddard added a comment -

        In the case of ICEmobile, the javax.faces.ViewState is missing from a failed button click, likely indicating that the ViewState was not "fixed" on the previous update, possibly due to a listener not being called.

        Show
        Ted Goddard added a comment - In the case of ICEmobile, the javax.faces.ViewState is missing from a failed button click, likely indicating that the ViewState was not "fixed" on the previous update, possibly due to a listener not being called.
        Hide
        Ted Goddard added a comment -

        Fix for the double back button is being made in ICEmobile: MOBI-271.

        Show
        Ted Goddard added a comment - Fix for the double back button is being made in ICEmobile: MOBI-271 .
        Hide
        Ken Fyten added a comment -

        Carmen confirms that the specific tests that failed Thursday night (as per her comment "Carmen Cristurean added a comment - 20/Jul/12 01:15 PM" above), now pass with this patch in place. Complete regression tests will run Friday night, we'll have results on Monday morning.

        Show
        Ken Fyten added a comment - Carmen confirms that the specific tests that failed Thursday night (as per her comment "Carmen Cristurean added a comment - 20/Jul/12 01:15 PM" above), now pass with this patch in place. Complete regression tests will run Friday night, we'll have results on Monday morning.
        Hide
        Krashan Brahmanjara added a comment -

        Registered again as ICE-9129. I suppose many people has got problems with ice:panelPopup. After closing of this popup gui stops respond in some test cases.

        Show
        Krashan Brahmanjara added a comment - Registered again as ICE-9129 . I suppose many people has got problems with ice:panelPopup. After closing of this popup gui stops respond in some test cases.

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Nils Lundquist
          • Votes:
            3 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: