ICEfaces
  1. ICEfaces
  2. ICE-8215

jQuery :first selector fails in delegated .on() events

          Details

          • Type: Bug Bug
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0.BETA1
          • Fix Version/s: 3.1.0.BETA2, 3.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            IF 3.1
          • Assignee Priority:
            P1

            Description

            Since JQ 1.7 :first and other positional selectors have been broken in delegate .on() listeners. This is due to the jQuery bug reported here: http://bugs.jquery.com/ticket/11315

            It is also reported in the thread above that initializing a delegate that uses :first is comparatively very intensive as well, thus removing :first in favour of liberal use of the > selector has multiple advantages.

            This refactoring has already been applied to list, datatable selection, row editing and panel expansion feature selectors.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29316 Tue Jun 05 14:27:01 MDT 2012 nils.lundquist ICE-8215 - Rewrote selection selectors to remove :first.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Nils Lundquist created issue -
              Nils Lundquist made changes -
              Field Original Value New Value
              Assignee Nils Lundquist [ nils.lundquist ]
              Hide
              Permalink
              Nils Lundquist added a comment -

              There are over 100 individual usages of :first likely applicable for this refactoring.

              Show
              Nils Lundquist added a comment - There are over 100 individual usages of :first likely applicable for this refactoring.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29323 Tue Jun 05 15:42:52 MDT 2012 nils.lundquist ICE-8215 - Removed usages of :first from list where applicable.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/list/ListRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/list/list.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29326 Tue Jun 05 16:17:25 MDT 2012 nils.lundquist ICE-8215 - Removed usages of :first from listControl where applicable.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControlRenderer.java
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/list/list.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/listcontrol/listcontrol.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/src/org/icefaces/ace/component/listcontrol/ListControl.java
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29323
              Committed by nils.lundquist
              2 minutes ago
              ICE-8215 - Removed usages of :first from list where applicable.

              Show
              Nils Lundquist added a comment - Revision #29323 Committed by nils.lundquist 2 minutes ago ICE-8215 - Removed usages of :first from list where applicable.
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29326
              Committed by nils.lundquist
              Moments ago
              ICE-8215 - Removed usages of :first from listControl where applicable.

              Show
              Nils Lundquist added a comment - Revision #29326 Committed by nils.lundquist Moments ago ICE-8215 - Removed usages of :first from listControl where applicable.
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 3.1.0.BETA2 [ 10336 ]
              Assignee Priority P1
              Affects Version/s 3.1.0.BETA1 [ 10335 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29332 Wed Jun 06 10:34:30 MDT 2012 nils.lundquist ICE-8215 - Removed usages of :first from dataTable selectors where applicable.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Hide
              Permalink
              Nils Lundquist added a comment -

              Revision #29332
              Committed by nils.lundquist
              Moments ago
              ICE-8215 - Removed usages of :first from dataTable selectors where applicable.

              Show
              Nils Lundquist added a comment - Revision #29332 Committed by nils.lundquist Moments ago ICE-8215 - Removed usages of :first from dataTable selectors where applicable.
              Hide
              Permalink
              Nils Lundquist added a comment -

              All vulnerable uses of :first have been refactored.

              Show
              Nils Lundquist added a comment - All vulnerable uses of :first have been refactored.
              Nils Lundquist made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Component/s ACE-Components [ 10050 ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29657 Fri Jun 22 14:50:54 MDT 2012 nils.lundquist ICE-8215 - Fixed multicolumn sorting regression related to selector refactor.
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Nils Lundquist
                  Reporter:
                  Nils Lundquist
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: