ICEfaces
  1. ICEfaces
  2. ICE-8215

jQuery :first selector fails in delegated .on() events

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.0.BETA1
    • Fix Version/s: 3.1.0.BETA2, 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      IF 3.1
    • Assignee Priority:
      P1

      Description

      Since JQ 1.7 :first and other positional selectors have been broken in delegate .on() listeners. This is due to the jQuery bug reported here: http://bugs.jquery.com/ticket/11315

      It is also reported in the thread above that initializing a delegate that uses :first is comparatively very intensive as well, thus removing :first in favour of liberal use of the > selector has multiple advantages.

      This refactoring has already been applied to list, datatable selection, row editing and panel expansion feature selectors.

        Activity

        Hide
        Nils Lundquist added a comment -

        There are over 100 individual usages of :first likely applicable for this refactoring.

        Show
        Nils Lundquist added a comment - There are over 100 individual usages of :first likely applicable for this refactoring.
        Hide
        Nils Lundquist added a comment -

        Revision #29323
        Committed by nils.lundquist
        2 minutes ago
        ICE-8215 - Removed usages of :first from list where applicable.

        Show
        Nils Lundquist added a comment - Revision #29323 Committed by nils.lundquist 2 minutes ago ICE-8215 - Removed usages of :first from list where applicable.
        Hide
        Nils Lundquist added a comment -

        Revision #29326
        Committed by nils.lundquist
        Moments ago
        ICE-8215 - Removed usages of :first from listControl where applicable.

        Show
        Nils Lundquist added a comment - Revision #29326 Committed by nils.lundquist Moments ago ICE-8215 - Removed usages of :first from listControl where applicable.
        Hide
        Nils Lundquist added a comment -

        Revision #29332
        Committed by nils.lundquist
        Moments ago
        ICE-8215 - Removed usages of :first from dataTable selectors where applicable.

        Show
        Nils Lundquist added a comment - Revision #29332 Committed by nils.lundquist Moments ago ICE-8215 - Removed usages of :first from dataTable selectors where applicable.
        Hide
        Nils Lundquist added a comment -

        All vulnerable uses of :first have been refactored.

        Show
        Nils Lundquist added a comment - All vulnerable uses of :first have been refactored.

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Nils Lundquist
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: