ICEfaces
  1. ICEfaces
  2. ICE-8145

ACE animations performance improvements in IE 7/8

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0.BETA1
          • Fix Version/s: 3.1.0.BETA2, 3.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any

            Description

            Use of animations in IE 7/8 make applications feel slower, especially if a page is loaded with many components. This issue needs to be addresses by avoiding the use of animations in these browsers or making adjustments to the code to make them run faster.

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Disabled fadeIn, fadeOut, slideDown, and slideUp for IE 7/8 and replaced them by show, hide, show, hide, respectively. Also, made sure to call callback function.

              Also disabled fadeTo(duration, opacity). If opacity > 0, show() is called, otherwise hide() is called.

              Show
              Arturo Zambrano added a comment - Disabled fadeIn, fadeOut, slideDown, and slideUp for IE 7/8 and replaced them by show, hide, show, hide, respectively. Also, made sure to call callback function. Also disabled fadeTo(duration, opacity). If opacity > 0, show() is called, otherwise hide() is called.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Added a submenu registry to keep track of those submenus that are open and only process _hideSubmenu() on those that are actually open.

              Show
              Arturo Zambrano added a comment - Added a submenu registry to keep track of those submenus that are open and only process _hideSubmenu() on those that are actually open.
              Hide
              Permalink
              Ken Fyten added a comment -

              A likely related REGRESSION has been found by QA:

              Icefaces3/trunk revision# 29237

              showcase (tomcat7, Firefox12):
              ContextMenu - Overview fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.
              ContextMenu - Multi-Column fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.

              Show
              Ken Fyten added a comment - A likely related REGRESSION has been found by QA: Icefaces3/trunk revision# 29237 showcase (tomcat7, Firefox12): ContextMenu - Overview fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it. ContextMenu - Multi-Column fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Reverted the removal of the click event listener attached to the document, since that was causing the context menu issues. The submenu registry is still there, avoiding thr processing of the listener if the submenu is not open. Revision 29252.

              Show
              Arturo Zambrano added a comment - Reverted the removal of the click event listener attached to the document, since that was causing the context menu issues. The submenu registry is still there, avoiding thr processing of the listener if the submenu is not open. Revision 29252.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              As of revision # 29261, showcase - contextMenu issues have been resolved.

              Show
              Carmen Cristurean added a comment - As of revision # 29261, showcase - contextMenu issues have been resolved.
              Hide
              Permalink
              Ken Fyten added a comment -

              Primary performance killing issues associated with IE 7/8 and animations have been dealt with. Marking Resolved.

              Show
              Ken Fyten added a comment - Primary performance killing issues associated with IE 7/8 and animations have been dealt with. Marking Resolved.

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: