ICEfaces
  1. ICEfaces
  2. ICE-8145

ACE animations performance improvements in IE 7/8

          Details

          • Type: Improvement Improvement
          • Status: Closed
          • Priority: Major Major
          • Resolution: Fixed
          • Affects Version/s: 3.1.0.BETA1
          • Fix Version/s: 3.1.0.BETA2, 3.1
          • Component/s: ACE-Components
          • Labels:
            None
          • Environment:
            Any

            Description

            Use of animations in IE 7/8 make applications feel slower, especially if a page is loaded with many components. This issue needs to be addresses by avoiding the use of animations in these browsers or making adjustments to the code to make them run faster.

              Activity

              Ascending order - Click to sort in descending order
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29155 Wed May 23 12:59:29 MDT 2012 art.zambrano ICE-8145 disabled fade animations in IE 7/8
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/jquery.js
              Arturo Zambrano created issue -
              Arturo Zambrano made changes -
              Field Original Value New Value
              Assignee Arturo Zambrano [ artzambrano ]
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29157 Wed May 23 14:59:59 MDT 2012 art.zambrano ICE-8145 disabled basic slide animations in IE 7/8
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/jquery.js
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Disabled fadeIn, fadeOut, slideDown, and slideUp for IE 7/8 and replaced them by show, hide, show, hide, respectively. Also, made sure to call callback function.

              Also disabled fadeTo(duration, opacity). If opacity > 0, show() is called, otherwise hide() is called.

              Show
              Arturo Zambrano added a comment - Disabled fadeIn, fadeOut, slideDown, and slideUp for IE 7/8 and replaced them by show, hide, show, hide, respectively. Also, made sure to call callback function. Also disabled fadeTo(duration, opacity). If opacity > 0, show() is called, otherwise hide() is called.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29198 Fri May 25 12:36:21 MDT 2012 art.zambrano ICE-8145 added registry to keep track of open submenus and only close those which are actually open
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Added a submenu registry to keep track of those submenus that are open and only process _hideSubmenu() on those that are actually open.

              Show
              Arturo Zambrano added a comment - Added a submenu registry to keep track of those submenus that are open and only process _hideSubmenu() on those that are actually open.
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29208 Fri May 25 16:50:12 MDT 2012 art.zambrano ICE-8145 commented out click event listener on document object, which as responsible for calling _hideAllMenus()
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29237 Tue May 29 18:15:27 MDT 2012 art.zambrano ICE-8145 ace:tooltip, improvement to only process global listener if there are any open tooltips
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/tooltip.js
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/tooltip/jquery.qtip-1.0.0-rc3.js
              Repository Revision Date User Message
              ICEsoft Public SVN Repository #29252 Wed May 30 14:29:59 MDT 2012 art.zambrano ICE-8145 uncommented click event listener on document object, since not having it was causing issues with ace:contextMenu
              Files Changed
              Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
              Hide
              Permalink
              Ken Fyten added a comment -

              A likely related REGRESSION has been found by QA:

              Icefaces3/trunk revision# 29237

              showcase (tomcat7, Firefox12):
              ContextMenu - Overview fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.
              ContextMenu - Multi-Column fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.

              Show
              Ken Fyten added a comment - A likely related REGRESSION has been found by QA: Icefaces3/trunk revision# 29237 showcase (tomcat7, Firefox12): ContextMenu - Overview fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it. ContextMenu - Multi-Column fails, once context menu opens up, it cannot be closed when clicking on the page. Only selecting a menu item will close it.
              Ken Fyten made changes -
              Salesforce Case []
              Fix Version/s 3.1.0.BETA2 [ 10336 ]
              Fix Version/s 3.1 [ 10312 ]
              Assignee Priority P1
              Hide
              Permalink
              Arturo Zambrano added a comment -

              Reverted the removal of the click event listener attached to the document, since that was causing the context menu issues. The submenu registry is still there, avoiding thr processing of the listener if the submenu is not open. Revision 29252.

              Show
              Arturo Zambrano added a comment - Reverted the removal of the click event listener attached to the document, since that was causing the context menu issues. The submenu registry is still there, avoiding thr processing of the listener if the submenu is not open. Revision 29252.
              Hide
              Permalink
              Carmen Cristurean added a comment -

              As of revision # 29261, showcase - contextMenu issues have been resolved.

              Show
              Carmen Cristurean added a comment - As of revision # 29261, showcase - contextMenu issues have been resolved.
              Hide
              Permalink
              Ken Fyten added a comment -

              Primary performance killing issues associated with IE 7/8 and animations have been dealt with. Marking Resolved.

              Show
              Ken Fyten added a comment - Primary performance killing issues associated with IE 7/8 and animations have been dealt with. Marking Resolved.
              Ken Fyten made changes -
              Status Open [ 1 ] Resolved [ 5 ]
              Assignee Priority P1
              Resolution Fixed [ 1 ]
              Ken Fyten made changes -
              Status Resolved [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Arturo Zambrano
                  Reporter:
                  Arturo Zambrano
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  0 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: