ICEfaces
  1. ICEfaces
  2. ICE-8028

The panelPositioned component does not work if embedded in a scrollbox and the scroll position has been changed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.1, EE-3.0.0.GA
    • Fix Version/s: EE-3.0.0.GA_P01, 3.2
    • Component/s: ICE-Components
    • Labels:
      None
    • Environment:
      All
    • Affects:
      Documentation (User Guide, Ref. Guide, etc.)

      Description

      Noted by a client in the relevant SalesForce case. The provided simple test case shows the problem:

      1) Deploy the test case and navigate to http://localhost:8080/basic/panelPositioned.jsf
      2) Without scrolling, drag items. This should work.
      3) Scroll down in the list and attempt to drag an item. This will not work and the scroll position will reset to the top.

      This has a good chance of being a regression as the positioning works properly in ICEfaces EE 2.0 (although the scroll position still isn't maintained).

        Activity

        Ken Fyten made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Assignee Priority P1 [ 10010 ]
        Mircea Toma made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Applied fixes to maintenance branch.

        Show
        Mircea Toma added a comment - Applied fixes to maintenance branch.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30288 Thu Jul 26 15:07:43 MDT 2012 mircea.toma ICE-8028 Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library.
        Files Changed
        Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
        Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js
        Commit graph MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
        Ken Fyten made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Hide
        Ken Fyten added a comment -

        Please add this to the icefaces-3.0.x-maintenance branch also.

        Show
        Ken Fyten added a comment - Please add this to the icefaces-3.0.x-maintenance branch also.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30174 Mon Jul 23 15:32:34 MDT 2012 mircea.toma ICE-8028 Make sure the ice.includeScrollOffsets is applied after the document has loaded.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Mircea Toma made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Affects [Documentation (User Guide, Ref. Guide, etc.)]
        Resolution Fixed [ 1 ]
        Hide
        Mircea Toma added a comment -

        Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library. Default value of the parameter is 'true'.

        Show
        Mircea Toma added a comment - Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library. Default value of the parameter is 'true'.
        Repository Revision Date User Message
        ICEsoft Public SVN Repository #30168 Mon Jul 23 09:00:29 MDT 2012 mircea.toma ICE-8028 Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library.
        Files Changed
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java
        Commit graph MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js
        Ken Fyten made changes -
        Fix Version/s 3.1 [ 10312 ]
        Ken Fyten made changes -
        Fix Version/s 3.2 [ 10338 ]
        Assignee Priority P2 P1
        Assignee yip.ng [ yip.ng ] Mircea Toma [ mircea.toma ]
        Hide
        yip.ng added a comment - - edited

        Problem first started to appear at revision 25359: ICE-7120, http://server.ice:8888/svn/ossrepo/icefaces2/trunk/icefaces.

        The change was just the addition of a config. setting:
        Position.includeScrollOffsets = true;

        According to comment in ICE-7120, this "Configured PrototypeJS to take into account the scroll offsets when calculating element positions." But in this case it seems to do exactly the opposite.
        (This setting is mentioned in the Scriptaculous docs, but there are some grumblings on the web about its workings.)

        Show
        yip.ng added a comment - - edited Problem first started to appear at revision 25359: ICE-7120, http://server.ice:8888/svn/ossrepo/icefaces2/trunk/icefaces . The change was just the addition of a config. setting: Position.includeScrollOffsets = true; According to comment in ICE-7120, this "Configured PrototypeJS to take into account the scroll offsets when calculating element positions." But in this case it seems to do exactly the opposite. (This setting is mentioned in the Scriptaculous docs, but there are some grumblings on the web about its workings.)
        Hide
        yip.ng added a comment -

        Seems even very old versions of icefaces3 have same problem. (Tree conflicts when updating so can't just update to revision and rebuild, must check out and set up new project. Time-consuming.) Started looking at icefaces2. Seems problem was in icefaces2 already before branching to icefaces3.

        Show
        yip.ng added a comment - Seems even very old versions of icefaces3 have same problem. (Tree conflicts when updating so can't just update to revision and rebuild, must check out and set up new project. Time-consuming.) Started looking at icefaces2. Seems problem was in icefaces2 already before branching to icefaces3.
        Show
        yip.ng added a comment - Revision of http://server.ice:8888/svn/ossrepo/icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces: 24443.
        Ken Fyten made changes -
        Assignee Mircea Toma [ mircea.toma ] yip.ng [ yip.ng ]
        Ken Fyten made changes -
        Assignee Priority P1 P2
        Ken Fyten made changes -
        Assignee Priority P2 P1
        Ken Fyten made changes -
        Fix Version/s EE-3.0.0.GA_P01 [ 10327 ]
        Assignee Priority P2
        Assignee Ken Fyten [ ken.fyten ] Mircea Toma [ mircea.toma ]
        Deryk Sinotte made changes -
        Salesforce Case [5007000000LHMs6]
        Assignee Ken Fyten [ ken.fyten ]
        Deryk Sinotte made changes -
        Attachment basic2.war [ 14326 ]
        Deryk Sinotte made changes -
        Field Original Value New Value
        Attachment basic.war [ 14325 ]
        Hide
        Deryk Sinotte added a comment -

        Attaching test cases. Each is a copy of our samples/core/basic application built with the customer's test bean and page added. The difference is:

        basic.war = The icefaces3/trunk/icefaces/ (this one shows the issue)
        basic2.war = The icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces/ (this one works)

        Show
        Deryk Sinotte added a comment - Attaching test cases. Each is a copy of our samples/core/basic application built with the customer's test bean and page added. The difference is: basic.war = The icefaces3/trunk/icefaces/ (this one shows the issue) basic2.war = The icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces/ (this one works)
        Deryk Sinotte created issue -

          People

          • Assignee:
            Mircea Toma
            Reporter:
            Deryk Sinotte
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: