[ICE-8028] The panelPositioned component does not work if embedded in a scrollbox and the scroll position has been changed - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 3.0.1, EE-3.0.0.GA
Fix Version/s: EE-3.0.0.GA_P01, 3.2
Component/s: ICE-Components
Labels:
None
Environment:
All

Affects:

Documentation (User Guide, Ref. Guide, etc.)

Description

Noted by a client in the relevant SalesForce case. The provided simple test case shows the problem:

1) Deploy the test case and navigate to http://localhost:8080/basic/panelPositioned.jsf
2) Without scrolling, drag items. This should work.
3) Scroll down in the list and attempt to drag an item. This will not work and the scroll position will reset to the top.

This has a good chance of being a regression as the positioning works properly in ICEfaces EE 2.0 (although the scroll position still isn't maintained).

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
basic.war

23/Apr/12 3:32 PM

5.56 MB

Deryk Sinotte
META-INF/MANIFEST.MF 0.1 kB

WEB-INF/web.xml 3 kB

icefaces-subtree.xhtml 2 kB

icefaces.xhtml 3 kB

index.jsp 0.7 kB

nonicefaces.xhtml 3 kB

panelPositioned.xhtml 1.0 kB

WEB-INF/lib/icefaces-compat.jar 2.58 MB

WEB-INF/lib/icefaces.jar 282 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/javax.faces.jar 2.47 MB

WEB-INF/classes/.../common/JIRABugBean.class 1 kB

WEB-INF/classes/org/.../basic/Basic.class 1 kB

Download Zip
Show

basic.war

23/Apr/12 3:32 PM

5.56 MB

Deryk Sinotte
Hide
basic2.war

23/Apr/12 3:38 PM

5.24 MB

Deryk Sinotte
META-INF/MANIFEST.MF 0.1 kB

WEB-INF/web.xml 2 kB

icefaces-subtree.xhtml 3 kB

icefaces.xhtml 3 kB

index.jsp 0.9 kB

nonicefaces.xhtml 3 kB

panelPositioned.xhtml 1.0 kB

WEB-INF/lib/icefaces-compat.jar 2.67 MB

WEB-INF/lib/icefaces.jar 208 kB

WEB-INF/lib/icepush.jar 242 kB

WEB-INF/lib/jsf-api.jar 611 kB

WEB-INF/lib/jsf-impl.jar 1.85 MB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/classes/.../common/JIRABugBean.class 1 kB

WEB-INF/classes/org/.../basic/Basic.class 1 kB

Download Zip
Show

basic2.war

23/Apr/12 3:38 PM

5.24 MB

Deryk Sinotte

Activity

Ascending order - Click to sort in descending order

Deryk Sinotte created issue - 23/Apr/12 3:22 PM

Hide

Permalink

Deryk Sinotte added a comment - 23/Apr/12 3:32 PM

Attaching test cases. Each is a copy of our samples/core/basic application built with the customer's test bean and page added. The difference is:

basic.war = The icefaces3/trunk/icefaces/ (this one shows the issue)
basic2.war = The icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces/ (this one works)

Show

Deryk Sinotte added a comment - 23/Apr/12 3:32 PM Attaching test cases. Each is a copy of our samples/core/basic application built with the customer's test bean and page added. The difference is: basic.war = The icefaces3/trunk/icefaces/ (this one shows the issue) basic2.war = The icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces/ (this one works)

Deryk Sinotte made changes - 23/Apr/12 3:32 PM

Field	Original Value	New Value
Attachment		basic.war [ 14325 ]

Deryk Sinotte made changes - 23/Apr/12 3:38 PM

Attachment

basic2.war [ 14326 ]

Deryk Sinotte made changes - 23/Apr/12 3:44 PM

Salesforce Case		[5007000000LHMs6]
Assignee		Ken Fyten [ ken.fyten ]

Ken Fyten made changes - 23/Apr/12 4:10 PM

Fix Version/s		EE-3.0.0.GA_P01 [ 10327 ]
Assignee Priority		P2
Assignee	Ken Fyten [ ken.fyten ]	Mircea Toma [ mircea.toma ]

Ken Fyten made changes - 26/Apr/12 3:29 PM

Assignee Priority

Ken Fyten made changes - 03/May/12 4:11 PM

Assignee Priority

Ken Fyten made changes - 03/Jul/12 6:30 PM

Assignee

Mircea Toma [ mircea.toma ]

yip.ng [ yip.ng ]

Hide

Permalink

yip.ng added a comment - 12/Jul/12 2:53 PM

Revision of http://server.ice:8888/svn/ossrepo/icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces: 24443.

Show

yip.ng added a comment - 12/Jul/12 2:53 PM Revision of http://server.ice:8888/svn/ossrepo/icefaces-ee/tags/icefaces-ee-2.0.0.GA/icefaces: 24443.

Hide

Permalink

yip.ng added a comment - 12/Jul/12 5:39 PM

Seems even very old versions of icefaces3 have same problem. (Tree conflicts when updating so can't just update to revision and rebuild, must check out and set up new project. Time-consuming.) Started looking at icefaces2. Seems problem was in icefaces2 already before branching to icefaces3.

Show

yip.ng added a comment - 12/Jul/12 5:39 PM Seems even very old versions of icefaces3 have same problem. (Tree conflicts when updating so can't just update to revision and rebuild, must check out and set up new project. Time-consuming.) Started looking at icefaces2. Seems problem was in icefaces2 already before branching to icefaces3.

Hide

Permalink

yip.ng added a comment - 16/Jul/12 5:15 PM - edited

Problem first started to appear at revision 25359: ICE-7120, http://server.ice:8888/svn/ossrepo/icefaces2/trunk/icefaces.

The change was just the addition of a config. setting:
Position.includeScrollOffsets = true;

According to comment in ICE-7120, this "Configured PrototypeJS to take into account the scroll offsets when calculating element positions." But in this case it seems to do exactly the opposite.
(This setting is mentioned in the Scriptaculous docs, but there are some grumblings on the web about its workings.)

Show

yip.ng added a comment - 16/Jul/12 5:15 PM - edited Problem first started to appear at revision 25359: ICE-7120, http://server.ice:8888/svn/ossrepo/icefaces2/trunk/icefaces . The change was just the addition of a config. setting: Position.includeScrollOffsets = true; According to comment in ICE-7120, this "Configured PrototypeJS to take into account the scroll offsets when calculating element positions." But in this case it seems to do exactly the opposite. (This setting is mentioned in the Scriptaculous docs, but there are some grumblings on the web about its workings.)

Ken Fyten made changes - 17/Jul/12 5:41 PM

Fix Version/s		3.2 [ 10338 ]
Assignee Priority	P2	P1
Assignee	yip.ng [ yip.ng ]	Mircea Toma [ mircea.toma ]

Ken Fyten made changes - 17/Jul/12 5:41 PM

Fix Version/s

3.1 [ 10312 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30168	Mon Jul 23 09:00:29 MDT 2012	mircea.toma	~~ICE-8028~~ Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java MODIFY /icefaces3/trunk/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

Hide

Permalink

Mircea Toma added a comment - 23/Jul/12 10:00 AM

Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library. Default value of the parameter is 'true'.

Show

Mircea Toma added a comment - 23/Jul/12 10:00 AM Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library. Default value of the parameter is 'true'.

Mircea Toma made changes - 23/Jul/12 10:00 AM

Status	Open [ 1 ]	Resolved [ 5 ]
Affects		[Documentation (User Guide, Ref. Guide, etc.)]
Resolution		Fixed [ 1 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30174	Mon Jul 23 15:32:34 MDT 2012	mircea.toma	~~ICE-8028~~ Make sure the ice.includeScrollOffsets is applied after the document has loaded.
				Files Changed
				MODIFY /icefaces3/trunk/icefaces/compat/core/src/main/javascript/extras/extras.js

Hide

Permalink

Ken Fyten added a comment - 24/Jul/12 4:09 PM

Please add this to the icefaces-3.0.x-maintenance branch also.

Show

Ken Fyten added a comment - 24/Jul/12 4:09 PM Please add this to the icefaces-3.0.x-maintenance branch also.

Ken Fyten made changes - 24/Jul/12 4:09 PM

Resolution	Fixed [ 1 ]
Status	Resolved [ 5 ]	Reopened [ 4 ]

Repository	Revision	Date	User	Message
ICEsoft Public SVN Repository	#30288	Thu Jul 26 15:07:43 MDT 2012	mircea.toma	~~ICE-8028~~ Introduced org.icefaces.includeScrollOffsets context parameter that can be used to change the way the offsets are calculated by the Prototype library.
				Files Changed
				MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/java/com/icesoft/faces/application/ExtrasSetup.java MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/compat/core/src/main/javascript/extras/extras.js MODIFY /icefaces3/branches/icefaces-3.0.x-maintenance/icefaces/core/src/main/java/org/icefaces/util/EnvUtils.java

Hide

Permalink

Mircea Toma added a comment - 26/Jul/12 4:08 PM

Applied fixes to maintenance branch.

Show

Mircea Toma added a comment - 26/Jul/12 4:08 PM Applied fixes to maintenance branch.

Mircea Toma made changes - 26/Jul/12 4:08 PM

Status	Reopened [ 4 ]	Resolved [ 5 ]
Resolution		Fixed [ 1 ]

Ken Fyten made changes - 30/Nov/12 11:47 PM

Status	Resolved [ 5 ]	Closed [ 6 ]
Assignee Priority	P1 [ 10010 ]

People

Assignee:

Mircea Toma

Reporter:

Deryk Sinotte

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

23/Apr/12 3:22 PM

Updated:

30/Nov/12 11:47 PM

Resolved:

26/Jul/12 4:08 PM