ICEfaces
  1. ICEfaces
  2. ICE-7985

Rowselector delault isKeyboardNavigationEnabled returns invalid value/

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.8.2a
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Environment:
      icefaces 1.8.3 from trunk
    • Workaround Description:
      Hide
      Patch
      public boolean isKeyboardNavigationEnabled() {
              if (keyboardNavigationEnabled != null) {
                  return keyboardNavigationEnabled.booleanValue();
              }
              ValueBinding vb = getValueBinding("keyboardNavigationEnabled");
              Boolean boolVal = vb != null ?
                      (Boolean) vb.getValue(getFacesContext()) : null;
               return boolVal != null ? boolVal.booleanValue() : false;
          }

      Show
      Patch public boolean isKeyboardNavigationEnabled() {         if (keyboardNavigationEnabled != null) {             return keyboardNavigationEnabled.booleanValue();         }         ValueBinding vb = getValueBinding("keyboardNavigationEnabled");         Boolean boolVal = vb != null ?                 (Boolean) vb.getValue(getFacesContext()) : null;          return boolVal != null ? boolVal.booleanValue() : false;     }

      Description

      According to tld keyboardNavigationEnabled should be disabled by default for backward compatibility

      But in file http://anonsvn.icesoft.org/repo/icefaces/trunk/icefaces/component/src/com/icesoft/faces/component/ext/RowSelector.java
      we can see
      public boolean isKeyboardNavigationEnabled() {
      (...)
        return boolVal != null ? boolVal.booleanValue() : true;
      }

      Correct line should return false.

        Activity

        Hide
        Krashan Brahmanjara added a comment -

        This patch can be invalidated after adding patch from ICE-8013

        Show
        Krashan Brahmanjara added a comment - This patch can be invalidated after adding patch from ICE-8013

          People

          • Assignee:
            Unassigned
            Reporter:
            Krashan Brahmanjara
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: