ICEfaces
  1. ICEfaces
  2. ICE-7895

Update jQuery to 1.7.1, jQuery UI 1.8.18 and Wijmo 2.0.5

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0.BETA1, 3.1
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      *
    • Assignee Priority:
      P2
    • Affects:
      Compatibility/Configuration

      Description

      Update to jQuery 1.7.1, jQuery UI 1.8.18 and Wijmo 2.0.5 to fix bugs like ICE-7665 and for other general improvements.

        Issue Links

          Activity

          yip.ng created issue -
          yip.ng made changes -
          Field Original Value New Value
          Salesforce Case []
          Fix Version/s 3.1 [ 10312 ]
          Ken Fyten made changes -
          Salesforce Case []
          Component/s ACE-Components [ 10050 ]
          Affects Version/s 3.0.RC2 [ 10313 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-7856 [ ICE-7856 ]
          Ken Fyten made changes -
          Link This issue blocks ICE-8039 [ ICE-8039 ]
          Ken Fyten made changes -
          Salesforce Case []
          Affects [Compatibility/Configuration]
          Assignee Priority P2
          Assignee Arturo Zambrano [ artzambrano ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28896 Mon Apr 30 23:56:09 MDT 2012 art.zambrano ICE-7895 updated to jQuery 1.7.2; replaced some occurrences of the live() function
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/jquery.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/list/list.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/listcontrol/listcontrol.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28901 Tue May 01 11:20:10 MDT 2012 art.zambrano ICE-7895 replaced occurrences of the live() function in the data table code
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Hide
          Arturo Zambrano added a comment -

          Committed update to jQuery 1.7.2 at revision 28901. Also modified occurrences of calls to live() for on(), and calls to die() for off().

          The following issues were found after this update:

          • The list component is slower.
          • Panel and row expansion feel slower as well.
          • It's not possible to do multi-column sorting (even before removing calls to live()).
          • There's an issue with multiple cell selection when ajax is used (it highlights the cell multiple times when many of them have been selected).
          Show
          Arturo Zambrano added a comment - Committed update to jQuery 1.7.2 at revision 28901. Also modified occurrences of calls to live() for on(), and calls to die() for off(). The following issues were found after this update: The list component is slower. Panel and row expansion feel slower as well. It's not possible to do multi-column sorting (even before removing calls to live()). There's an issue with multiple cell selection when ajax is used (it highlights the cell multiple times when many of them have been selected).
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28909 Tue May 01 18:56:39 MDT 2012 art.zambrano ICE-7895 optimized delegated events performance by using the table's root node; some minor refactoring
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28911 Wed May 02 12:37:51 MDT 2012 nils.lundquist ICE-7895 - Fixed JQ 1.7 metaKey changes by inspecting ctrlKey as well.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/datatable/datatable.js
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28922 Thu May 03 12:42:05 MDT 2012 art.zambrano ICE-7895 updated to jQuery 1.7.1, jQuery UI 1.8.18 and wijmo 2.0.5
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/jquery.js
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/wijmo/wijmo.css
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/jquery/ui/jquery-ui.css
          Hide
          Arturo Zambrano added a comment -

          Committed final update, consisting of jQuery 1.7.1, jQuery UI 1.8.18 and wijmo 2.0.5, at revision 28922.

          Had to update to jQuery 1.7.1 (instead of 1.7.2) since that's the version supported by the latest version of wijmo. Also, jQuery UI 1.8.18 works better than the 1.8.20 version.

          The issue with ace:contextMenu is now fixed with this commit. However, there's still a minor issue in the ICEfaces showcase: in the table integration demo, after one activates a menu item in the context menu (either add rows or undo), the contextMenu doesn't appear again.

          These issues are also present at the moment:

          • In the ace:confirmationDialog showcase demos, every time the button is clicked to show a dialog, all the dialogs that have been opened at some point in the session appear at the same time.
          • There's a Javascript error thrown when trying to activate the ace:resizable listener.
          • ace:dialog and ace:confirmationDialog have larger fonts.
          Show
          Arturo Zambrano added a comment - Committed final update, consisting of jQuery 1.7.1, jQuery UI 1.8.18 and wijmo 2.0.5, at revision 28922. Had to update to jQuery 1.7.1 (instead of 1.7.2) since that's the version supported by the latest version of wijmo. Also, jQuery UI 1.8.18 works better than the 1.8.20 version. The issue with ace:contextMenu is now fixed with this commit. However, there's still a minor issue in the ICEfaces showcase: in the table integration demo, after one activates a menu item in the context menu (either add rows or undo), the contextMenu doesn't appear again. These issues are also present at the moment: In the ace:confirmationDialog showcase demos, every time the button is clicked to show a dialog, all the dialogs that have been opened at some point in the session appear at the same time. There's a Javascript error thrown when trying to activate the ace:resizable listener. ace:dialog and ace:confirmationDialog have larger fonts.
          Hide
          Arturo Zambrano added a comment -

          The issue with ace:resizable is not related to this jQuery update. The fix is straight forward, and it is now documented in ICE-8070.

          Show
          Arturo Zambrano added a comment - The issue with ace:resizable is not related to this jQuery update. The fix is straight forward, and it is now documented in ICE-8070 .
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #28968 Mon May 07 17:03:03 MDT 2012 nils.lundquist ICE-7895 - Fixed regression to ListControl component due change to on instead of live. Problem was due to change in definition of event.currentTarget.
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/listcontrol/listcontrol.js
          Ken Fyten made changes -
          Fix Version/s 3.1.0.BETA1 [ 10335 ]
          Hide
          Arturo Zambrano added a comment -

          Also replaced calls to live() for on() to improve performance.

          Show
          Arturo Zambrano added a comment - Also replaced calls to live() for on() to improve performance.
          Arturo Zambrano made changes -
          Summary Update jQuery to 1.7 Update jQuery to 1.7.1, jQuery UI 1.8.18 and Wijmo 2.0.5
          Salesforce Case []
          Description Update jQuery to 1.7 to fix bugs. E.g. bug in ICE-7665. Update to jQuery 1.7.1, jQuery UI 1.8.18 and Wijmo 2.0.5 to fix bugs like ICE-7665 and for other general improvements.
          Arturo Zambrano made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Repository Revision Date User Message
          ICEsoft Public SVN Repository #29225 Mon May 28 16:28:26 MDT 2012 nils.lundquist ICE-7822 / ICE-7895 - Delegate undelegated .live() listener that had been converted to .on().
          Files Changed
          Commit graph MODIFY /icefaces3/trunk/icefaces/ace/component/resources/icefaces.ace/list/list.js
          Ken Fyten made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Arturo Zambrano
              Reporter:
              yip.ng
            • Votes:
              1 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: