ICEfaces
  1. ICEfaces
  2. ICE-7893

ace:dataTable - issue when changing selectionMode dynamically

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: EE-3.0.0.BETA
    • Fix Version/s: 3.0.1, EE-3.0.0.GA
    • Component/s: ACE-Components
    • Labels:
      None
    • Environment:
      ICEfaces EE 3.0 BETA 09032012

      Description

      When dynamically changing the selectionMode of the ace:dataTable, going from selection disabled (selectionMode=null) to enabled (selectionMode="single") works fine. But when going from enabled to disabled, the rows are still capable of being selected. They have the hover CSS and the selected CSS applied.

        Activity

        Hide
        Arran Mccullough added a comment -

        As a side note, I frequently got the following exception when pressing the buttons in my test case:

        WARNING: For input string: ""
        java.lang.NumberFormatException: For input string: ""
        at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48)
        at java.lang.Integer.parseInt(Integer.java:470)
        at java.lang.Integer.parseInt(Integer.java:499)
        at org.icefaces.ace.component.datatable.DataTableRenderer.decodeMultipleSelection(DataTableRenderer.java:373)
        at org.icefaces.ace.component.datatable.DataTableRenderer.decodeSelection(DataTableRenderer.java:237)
        at org.icefaces.ace.component.datatable.DataTableRenderer.decode(DataTableRenderer.java:66)
        at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:787)
        at org.icefaces.ace.component.datatable.DataTable.processDecodes(DataTable.java:242)
        at javax.faces.component.UIForm.processDecodes(UIForm.java:225)
        at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1176)
        at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1176)
        at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:933)
        at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78)
        at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101)
        at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
        at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
        at org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:393)
        at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)
        at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)
        at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240)
        at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:164)
        at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:462)
        at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164)
        at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100)
        at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:563)
        at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)
        at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:399)
        at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:317)
        at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:204)
        at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:311)
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
        at java.lang.Thread.run(Thread.java:662)

        Show
        Arran Mccullough added a comment - As a side note, I frequently got the following exception when pressing the buttons in my test case: WARNING: For input string: "" java.lang.NumberFormatException: For input string: "" at java.lang.NumberFormatException.forInputString(NumberFormatException.java:48) at java.lang.Integer.parseInt(Integer.java:470) at java.lang.Integer.parseInt(Integer.java:499) at org.icefaces.ace.component.datatable.DataTableRenderer.decodeMultipleSelection(DataTableRenderer.java:373) at org.icefaces.ace.component.datatable.DataTableRenderer.decodeSelection(DataTableRenderer.java:237) at org.icefaces.ace.component.datatable.DataTableRenderer.decode(DataTableRenderer.java:66) at javax.faces.component.UIComponentBase.decode(UIComponentBase.java:787) at org.icefaces.ace.component.datatable.DataTable.processDecodes(DataTable.java:242) at javax.faces.component.UIForm.processDecodes(UIForm.java:225) at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1176) at javax.faces.component.UIComponentBase.processDecodes(UIComponentBase.java:1176) at javax.faces.component.UIViewRoot.processDecodes(UIViewRoot.java:933) at com.sun.faces.lifecycle.ApplyRequestValuesPhase.execute(ApplyRequestValuesPhase.java:78) at com.sun.faces.lifecycle.Phase.doPhase(Phase.java:101) at com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118) at javax.faces.webapp.FacesServlet.service(FacesServlet.java:593) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:304) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:393) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:240) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:164) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:462) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:164) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:100) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:563) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:399) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:317) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:204) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:311) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:662)
        Hide
        Nils Lundquist added a comment -

        Revision #28303
        Committed by nils.lundquist
        9 minutes ago
        ICE-7893 - Selection still enabled when selectionMode was != 'single' or 'multiple'. Leftover event bindings remained on page when selection was disabled also.

        Show
        Nils Lundquist added a comment - Revision #28303 Committed by nils.lundquist 9 minutes ago ICE-7893 - Selection still enabled when selectionMode was != 'single' or 'multiple'. Leftover event bindings remained on page when selection was disabled also.
        Hide
        Aldo Laiseca Fernández added a comment -

        This issue seems to be still there. When going back to null for property selectionMode the rows are still capable to be selected.

        Show
        Aldo Laiseca Fernández added a comment - This issue seems to be still there. When going back to null for property selectionMode the rows are still capable to be selected.
        Hide
        Nils Lundquist added a comment -

        It may be the case that 3.0.1 was released with a regression for this issue within it, and if so, my apologies.

        I have however retested this issue and have confirmed it is fixed in our most recent trunk revision. If acceptable please confirm that our 3.1.0 BETA2 release, launching this week resolves your case.

        Show
        Nils Lundquist added a comment - It may be the case that 3.0.1 was released with a regression for this issue within it, and if so, my apologies. I have however retested this issue and have confirmed it is fixed in our most recent trunk revision. If acceptable please confirm that our 3.1.0 BETA2 release, launching this week resolves your case.
        Hide
        Aldo Laiseca Fernández added a comment -

        Thanks for your comment. I am currently working with IceFaces-EE 3.0.0 GA. How should I proceed to get this fixed? Could I just download the file datatable.js from somewhere and rebuild the iceface-ee-ace.jar library? Or is it more complex than that? Any help would be greatly appreciated.

        Show
        Aldo Laiseca Fernández added a comment - Thanks for your comment. I am currently working with IceFaces-EE 3.0.0 GA. How should I proceed to get this fixed? Could I just download the file datatable.js from somewhere and rebuild the iceface-ee-ace.jar library? Or is it more complex than that? Any help would be greatly appreciated.
        Hide
        Aldo Laiseca Fernández added a comment -

        I downloaded the latest trunk, rebuilt icefaces-ace.jar and I fortunately I can confirm that the issue is gone. My only concern is: can i just replace the original ice faces-ace.jar from the IceFaces-EE 3.00 GA with this new one? No side effects? Thank you very much.

        Show
        Aldo Laiseca Fernández added a comment - I downloaded the latest trunk, rebuilt icefaces-ace.jar and I fortunately I can confirm that the issue is gone. My only concern is: can i just replace the original ice faces-ace.jar from the IceFaces-EE 3.00 GA with this new one? No side effects? Thank you very much.
        Hide
        Arran Mccullough added a comment -

        Aldo,

        If you have a Premium or Professional Support subscription I can provide you with a patched ICEfaces EE 3.0.0 release. If not then you will either need to use the upcoming ICEfaces 3.1.0 release or wait for the subsequent ICEfaces EE 3.1.0 release. We strongly recommend not using the trunk jars for development and/or production as these jars are not completely tested against regressions and could have potential issues.

        Thanks,
        Arran

        Show
        Arran Mccullough added a comment - Aldo, If you have a Premium or Professional Support subscription I can provide you with a patched ICEfaces EE 3.0.0 release. If not then you will either need to use the upcoming ICEfaces 3.1.0 release or wait for the subsequent ICEfaces EE 3.1.0 release. We strongly recommend not using the trunk jars for development and/or production as these jars are not completely tested against regressions and could have potential issues. Thanks, Arran

          People

          • Assignee:
            Nils Lundquist
            Reporter:
            Arran Mccullough
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: