Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: EE-2.0.0.GA
-
Fix Version/s: EE-2.0.0.GA_P01
-
Component/s: ACE-Components
-
Labels:None
-
Environment:ICEfaces EE 2.0 SF 10754
Description
Scenario: All tabs are set as disabled. The selectedIndex for the ace:tabSet is initially set to -1. When the page is loaded all tabs in the tab set can be selected.
Activity
Field | Original Value | New Value |
---|---|---|
Attachment | Case10754Example2.zip [ 14002 ] | |
Attachment | Case10754Example2.war [ 14003 ] |
Salesforce Case | [5007000000JOG3R] |
Summary | Setting selectedIndex on tabSet and allows disabled tabs to be selected | Setting selectedIndex on ace:tabSet allows disabled ace:tabPanes to be selected |
Fix Version/s | EE-2.0.0.GA_P01 [ 10271 ] | |
Assignee Priority | P1 | |
Affects Version/s | EE-2.0.0.GA [ 10263 ] | |
Affects Version/s | 3.0.RC2 [ 10313 ] | |
Assignee | yip.ng [ yip.ng ] |
Comment |
[ Regarding the fix for this, I don't think fixing their issues with using -1 is the right way to solve the problem. Their attempt to use -1 is a workaround for the already acknowledged-as-bugged behaviour of the first tab being loaded when it is disabled. Both require altering YUI, so why fix their workaround when we can fix the actual problem? Nils ] |
Attachment | screenshot-1.png [ 14004 ] |
Attachment | screenshot-2.png [ 14005 ] |
Attachment | screenshot-3.png [ 14006 ] |
Attachment | screenshot-3.png [ 14006 ] |
Attachment | screenshot-3.png [ 14007 ] |
Status | Open [ 1 ] | Resolved [ 5 ] |
Assignee Priority | P1 | |
Resolution | Fixed [ 1 ] |
Status | Resolved [ 5 ] | Closed [ 6 ] |
Step 1 done. No need to change JS (ours or Yahoo's) so far. Just changed renderer to add disabled style class to Tab (<li>) element when a tab is disabled. When creating from pre-rendered HTML, YUI uses style classes (among other things) as config. params. (We were already using the disabled style class, but only when the whole tabset was disabled.) See screenshot-1.
The default for active index and active tab is null. (See screenshot-2.) And YUI won't let you activate a disabled tab. (See sceenshot-3.) So in this case it doesn't matter what active index you are trying to set. It just has no effect.
Note that in the test case the tab contents flash first because clientSide="true".
Modified: C:\svn\ossrepo\icefaces-ee\patches\icefaces-ee-sf-10754\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
Completed: At revision: 27359