[ICE-7689] Setting selectedIndex on ace:tabSet allows disabled ace:tabPanes to be selected - ICEsoft JIRA Issue Tracker

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: EE-2.0.0.GA
Fix Version/s: EE-2.0.0.GA_P01
Component/s: ACE-Components
Labels:
None
Environment:
ICEfaces EE 2.0 SF 10754

Description

Scenario: All tabs are set as disabled. The selectedIndex for the ace:tabSet is initially set to -1. When the page is loaded all tabs in the tab set can be selected.

Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

Hide
Case10754Example2.war

25/Jan/12 11:06 AM

9.06 MB

Arran Mccullough
META-INF/MANIFEST.MF 0.1 kB

META-INF/context.xml 0.1 kB

WEB-INF/classes/com/.../example/Tab.class 1 kB

WEB-INF/classes/.../example/TestBean.class 3 kB

WEB-INF/lib/commons-beanutils.jar 226 kB

WEB-INF/lib/commons-collections.jar 558 kB

WEB-INF/lib/commons-digester.jar 140 kB

WEB-INF/lib/commons-logging.jar 52 kB

WEB-INF/lib/icefaces-ee-ace.jar 2.40 MB

WEB-INF/lib/icefaces-ee-compat.jar 2.67 MB

WEB-INF/lib/icefaces-ee-composite.jar 357 kB

WEB-INF/lib/icefaces-ee.jar 206 kB

WEB-INF/lib/jsf-api.jar 611 kB

WEB-INF/lib/jsf-impl.jar 1.85 MB

WEB-INF/lib/jstl.jar 20 kB

WEB-INF/web.xml 2 kB

css/style.css 0.1 kB

tabControl.xhtml 1 kB

tabFour.xhtml 0.5 kB

tabOne.xhtml 0.5 kB

tabThree.xhtml 0.5 kB

tabTwo.xhtml 0.5 kB

welcomeICEfaces.xhtml 2 kB

Download Zip
Show

Case10754Example2.war

25/Jan/12 11:06 AM

9.06 MB

Arran Mccullough
Case10754Example2.zip

25/Jan/12 11:06 AM

21 kB

Arran Mccullough

screenshot-1.png

119 kB

25/Jan/12 4:23 PM
screenshot-2.png

221 kB

25/Jan/12 4:27 PM
screenshot-3.png

216 kB

25/Jan/12 4:50 PM

Activity

Descending order - Click to sort in ascending order

Hide

Permalink

yip.ng added a comment - 31/Jan/12 12:46 PM

From Arran:

The customer has found an issue when they are disabling or enabling a tab and also trying to select it or another tab in the same call. When this occurs it throws a JavaScript error: "tabset is undefined". This seems to occur only when they are also toggling the disabled attribute. It doesn't seem to cause the component from working correctly after though, at least in my tests so far.

Show

yip.ng added a comment - 31/Jan/12 12:46 PM From Arran: The customer has found an issue when they are disabling or enabling a tab and also trying to select it or another tab in the same call. When this occurs it throws a JavaScript error: "tabset is undefined". This seems to occur only when they are also toggling the disabled attribute. It doesn't seem to cause the component from working correctly after though, at least in my tests so far.

Hide

Permalink

yip.ng added a comment - 30/Jan/12 4:56 PM

From Arran:

Perfect, that works much better, thanks. This looks to help the latest issue they have.

Show

yip.ng added a comment - 30/Jan/12 4:56 PM From Arran: Perfect, that works much better, thanks. This looks to help the latest issue they have.

Hide

Permalink

yip.ng added a comment - 30/Jan/12 4:54 PM - edited

Try something like this:

function selectTabFromServer(clientId, index) {
var callback = function (tabset)

{ tabset.selectTab(index) // or tabset.set('activeIndex', index); }

;
ice.component.tabset.getInstance(clientId, callback);
}

But there may be problems if client side obejcts and states (e.g. JSContext) are not kept in sync.

Show

yip.ng added a comment - 30/Jan/12 4:54 PM - edited Try something like this: function selectTabFromServer(clientId, index) { var callback = function (tabset) { tabset.selectTab(index) // or tabset.set('activeIndex', index); } ; ice.component.tabset.getInstance(clientId, callback); } But there may be problems if client side obejcts and states (e.g. JSContext) are not kept in sync.

Hide

Permalink

yip.ng added a comment - 30/Jan/12 4:50 PM

From Arran:

The latest issue they are having now is that when the client-side tab is changed and they try and make a tab change on the server side, the server-side action isn't displayed on the client side.

Show

yip.ng added a comment - 30/Jan/12 4:50 PM From Arran: The latest issue they are having now is that when the client-side tab is changed and they try and make a tab change on the server side, the server-side action isn't displayed on the client side.

Hide

Permalink

yip.ng added a comment - 27/Jan/12 11:35 AM

Can't apply changes to icefaces-ee-2.0.0-dev branch. Versions in icefaces-ee-2.0.0-dev too different. Looks like some other JIRA changes haven't been applied there yet.

Show

yip.ng added a comment - 27/Jan/12 11:35 AM Can't apply changes to icefaces-ee-2.0.0-dev branch. Versions in icefaces-ee-2.0.0-dev too different. Looks like some other JIRA changes haven't been applied there yet.

6 older comments

Hide

Permalink

yip.ng added a comment - 25/Jan/12 5:14 PM - edited

Step 1 done. No need to change JS (ours or Yahoo's) so far. Just changed renderer to add disabled style class to Tab (<li>) element when a tab is disabled. When creating from pre-rendered HTML, YUI uses style classes (among other things) as config. params. (We were already using the disabled style class, but only when the whole tabset was disabled.) See screenshot-1.

The default for active index and active tab is null. (See screenshot-2.) And YUI won't let you activate a disabled tab. (See sceenshot-3.) So in this case it doesn't matter what active index you are trying to set. It just has no effect.

Note that in the test case the tab contents flash first because clientSide="true".

Modified: C:\svn\ossrepo\icefaces-ee\patches\icefaces-ee-sf-10754\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java
Completed: At revision: 27359

Show

yip.ng added a comment - 25/Jan/12 5:14 PM - edited Step 1 done. No need to change JS (ours or Yahoo's) so far. Just changed renderer to add disabled style class to Tab (<li>) element when a tab is disabled. When creating from pre-rendered HTML, YUI uses style classes (among other things) as config. params. (We were already using the disabled style class, but only when the whole tabset was disabled.) See screenshot-1. The default for active index and active tab is null. (See screenshot-2.) And YUI won't let you activate a disabled tab. (See sceenshot-3.) So in this case it doesn't matter what active index you are trying to set. It just has no effect. Note that in the test case the tab contents flash first because clientSide="true". Modified: C:\svn\ossrepo\icefaces-ee\patches\icefaces-ee-sf-10754\icefaces\ace\component\src\org\icefaces\component\tab\TabSetRenderer.java Completed: At revision: 27359

People

Assignee:

yip.ng

Reporter:

Arran Mccullough

Votes:

0 Vote for this issue

Watchers:

0 Start watching this issue

Dates

Created:

25/Jan/12 11:04 AM

Updated:

28/Mar/12 6:26 PM

Resolved:

27/Jan/12 10:39 AM